From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wPuMB+Ih8mKYrQAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 10:59:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QGBdB+Ih8mIaQAEAauVa8A (envelope-from ) for ; Tue, 09 Aug 2022 10:59:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A39A739211 for ; Tue, 9 Aug 2022 10:59:13 +0200 (CEST) Received: from localhost ([::1]:41238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLL4y-0003XC-3V for larch@yhetil.org; Tue, 09 Aug 2022 04:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLL4p-0003Wb-1A for guix-patches@gnu.org; Tue, 09 Aug 2022 04:59:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLL4o-0003oQ-O3 for guix-patches@gnu.org; Tue, 09 Aug 2022 04:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLL4o-0001tN-Hd for guix-patches@gnu.org; Tue, 09 Aug 2022 04:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56989] [PATCH v3] gnu: Add dbqn. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Aug 2022 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56989 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez Cc: 56989@debbugs.gnu.org Received: via spool by 56989-submit@debbugs.gnu.org id=B56989.16600355397264 (code B ref 56989); Tue, 09 Aug 2022 08:59:02 +0000 Received: (at 56989) by debbugs.gnu.org; 9 Aug 2022 08:58:59 +0000 Received: from localhost ([127.0.0.1]:42492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLL4i-0001t4-Nu for submit@debbugs.gnu.org; Tue, 09 Aug 2022 04:58:59 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:59774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLL4g-0001su-VW for 56989@debbugs.gnu.org; Tue, 09 Aug 2022 04:58:56 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id 5Lys2800420ykKC01Lyspv; Tue, 09 Aug 2022 10:58:53 +0200 Message-ID: Date: Tue, 9 Aug 2022 10:58:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US References: <20220805022023.5044-1-yewscion@gmail.com> <20220806022022.24054-1-yewscion@gmail.com> <00125176-9e1f-6d91-21d8-0d2fd9558aca@telenet.be> <87h72mx0t7.fsf@gmail.com> From: Maxime Devos In-Reply-To: <87h72mx0t7.fsf@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------u4CMBsVRYXVjky7xwuEineku" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660035533; bh=TSOlNQr+t67EEGBriegSycCMkceuts4cBGq0zQg5B0g=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=jEV33HZbBuFdsZChImXFanHjSNXrdXPQ2/s30D18RgYAgft4ElkNVXFwbCOm4cBoW lqIRBrHby1kLe1eDDj2LlhiptSrivGjDlLrV5WPimBzk6Ix1arHfII4Kdg71iH3nuB K9myVmlKmOYZi8/QBipfbD5fhOcuiVFSBkix1hOa564TWztlRsH6zwe7LVs3G+hfyZ 0x1ranc3NH/Cv3ILGDQZgzmfn6HcZJMjj9eRbeLU5KkSBfHCD6mvQ+sGZm/sypIuFu +KiIQooMVi9VA4De1N5G7pvi6JpXnOKGoGMGAarWkyLll1nbtmV/2LLNoN01q08JpX GJeu7yGcakmNQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660035553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TAYFKonrEJ4tXCXwHNyACYv+qEQCDwwX5RkHATO+KA8=; b=Pejc8kFSsyQwhVf3bLd/HcNCQh5tpmqTPxvCv7SJyL0fH3G4rsTQ51LMD7NdJHItHF79VH MYCmBqCCOcTfLiUtGH6B6GsseB1sqOEHql9hl3EQd6D0quH1HTRNGMp0wdGIvsppgXLUzX D0fMoOEdPKYY92PCf+KGLnJwR1fEcsqdQS6azn6aEnsLzOSI8bK0ABdOOqAil0+B5/LYEh N4IbzRnBtL9eXJRWYPH6FDnqOV2ZmunhyuKDkJxfRhn+goU7S/wZIvgGcSBxwCuxOryS+e 9xl+GfAFOmvC41qIrGM0UEUcYsuViOdVdMUhKpev3xtw9TFlNcSnntq8JKqDWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660035553; a=rsa-sha256; cv=none; b=Jx053W/CadgZJJj2yVTjRG6YrzSfRYOENiGJljQDbqwMoj95MRI+PK+fMtl3i3BAPrLlY1 KwCqatdURVIhxIRqeuv14aDrb2UUs80kl8Se7cC4QaEuyBjfIpjFI7yuFZy/Tsl1twEuwi 0UHmmhP29aCiOnq90rx1dodi7zSdZkqa48djxabWFrlC2X6wmL7v5rTj5JypsbhrJjRgn/ KR1EtsGZ35DTDxFUASXK/a/XenQg/TQ0EYxKaxk06KgAoyvEHRZzLMXEtiT6ZiisRWJqI8 X/QfvLPAVqV+oKAjmNkyKE+mP4ekpv7O5nOkXAWXK/bRJmgqubarSO76x3f+gQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=jEV33HZb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=jEV33HZb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A39A739211 X-Spam-Score: 4.21 X-Migadu-Scanner: scn1.migadu.com X-TUID: CVCXKv2yyswX This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------u4CMBsVRYXVjky7xwuEineku Content-Type: multipart/mixed; boundary="------------UwXpjglw54fwba7Dzw0cS2j0"; protected-headers="v1" From: Maxime Devos To: Christopher Rodriguez Cc: 56989@debbugs.gnu.org Message-ID: Subject: Re: [bug#56989] [PATCH v3] gnu: Add dbqn. References: <20220805022023.5044-1-yewscion@gmail.com> <20220806022022.24054-1-yewscion@gmail.com> <00125176-9e1f-6d91-21d8-0d2fd9558aca@telenet.be> <87h72mx0t7.fsf@gmail.com> In-Reply-To: <87h72mx0t7.fsf@gmail.com> --------------UwXpjglw54fwba7Dzw0cS2j0 Content-Type: multipart/mixed; boundary="------------xYlFrdLPTJUWUxvVzUrZhHOd" --------------xYlFrdLPTJUWUxvVzUrZhHOd Content-Type: multipart/alternative; boundary="------------EOcFeC3Dz8eUrSOMCG0s3EgN" --------------EOcFeC3Dz8eUrSOMCG0s3EgN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwOC0wOC0yMDIyIDE1OjU0LCBDaHJpc3RvcGhlciBSb2RyaWd1ZXogd3JvdGU6DQo+ Pj4gKyAgICAgICAgIChjb21taXQgImZkMTdiMTQ0NDgzNTQ5ZGJkMmJjZjIzZTNhMzdhMDky MTkxNzFhOTkiKQ0KPj4+ICsgICAgICAgICAoaGFzaCAiMXJyNGw3aWp6Y2cyNW4yaWdpMW16 eWE2cWxsaDV3c3JmM201aTQyOXJsZ3d2MWZ3dmZqaSIpDQo+Pj4gKyAgICAgICAgICh2ZXJz aW9uIChnaXQtdmVyc2lvbiB0YWcgcmV2aXNpb24gY29tbWl0KSkpDQo+PiBJJ20gbm90IHNl ZWluZyBhICcwJyB0YWcgYW55d2hlcmUgaW4gdGhlIHJlcG9zaXRvcnkgLS0gSSBkb250IHNl ZSBhbnkgdGFncyBhdA0KPj4gYWxsIHRlcmUuDQo+IFRoZXJlIGFyZSBub25lOyBJIHRob3Vn aHQgdGhlIGFic2VuY2Ugb2YgYW55IHRhZ2UgbmVjZXNzaXRhdGVzIGEgJzAnIGZvcg0KPiB0 aGUgdmVyc2lvbiBudW1iZXIsIGFuZCB3YW50ZWQgdG8ga2VlcCB0aGUgZGVmaW5pdGlvbnMN Cj4gc3RhbmRhcmRpemVkLiBTaG91bGQgSSBpbmxpbmUgdGhlIDAgaW5zdGVhZCBpbiB0aGUg Z2l0LXZlcnNpb24/DQo+DQpZZXMsIGlmIHVwc3RyZWFtIGRvZXNuJ3QgZG8gdmVyc2lvbmlu ZyB3ZSB1c2UgIjAiIG9yIHNvbWV0aW1lcyAiMC4wIiwgaW4gDQpjb21iaW5hdGlvbiB3aXRo IGdpdC12ZXJzaW9uIChvciBoZy12ZXJzaW9uLCAuLi4pLiBIb3dldmVyLCAiMCIgaXMgbm90 IGEgDQp0YWcsIHNvIHRoZSB2YXJpYWJsZSAndGFnJyBuZWVkcyB0byBiZSByZW5hbWVkIG9y IGlubGluZWQuwqAgQXMgaXQgaXMgDQpvbmx5IHVzZWQgaW4gYSBzaWdubGUgcGxhY2UsIEkg d291bGQgcmVjb21tZW5kIGlubGluaW5nIGl0LiBMaWtld2lzZSBmb3IgDQondmVyc2lvbicu DQoNCkFkZGl0aW9uYWxseSwgJ2hhc2gnIG5lZWRzIHRvIGJlIGlubGluZWQgLS0gbm90IG9u bHkgYmVjYXVzZSBpdCBpcyB1c2VkIA0KaW4gYSBzaW5nbGUgcGxhY2UsIGJ1dCBhbHNvIGJl Y2F1c2UgdGhlcmUgaXMgc29tZSBjb21waWxlLXRpbWUgZXJyb3IgDQpjaGVja2luZyBmb3Ig aGFzaGVzIHRoYXQgb25seSBjYW4gd29yayB3aGVuIGl0IGlzIGlubGluZWQuDQoNCkFsc28s IEkndmUgc2VlbiBhIHYyIGZvciB0aGUgZmlyc3QgcGF0Y2gsIGJ1dCB3aGF0IGhhcHBlbmVk IHRvIDIvNSwgMy81LCANCjQvNSBhbmQgNS81Pw0KDQpHcmVldGluZ3MsDQpNYXhpbWUuDQoN Cg== --------------EOcFeC3Dz8eUrSOMCG0s3EgN Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 08-08-2022 15:54, Christopher Rodriguez wrote:
+         (commit "fd17b=
144483549dbd2bcf23e3a37a09219171a99")
+         (hash "1rr4l7ijzcg25n2igi1mzya6qllh5wsrf3m5i429rlgwv1fwvfji")
+         (version (git-version tag revision commit)))

I'm not seeing a '0' tag a=
nywhere in the repository -- I dont see any tags at
all tere.

There are none; I thought th=
e absence of any tage necessitates a '0' for
the version number, and wanted to keep the definitions
standardized. Should I inline the 0 instead in the git-version?

Yes, if upstream doesn't do versioning we use "0" or sometimes "0.0", in combination with git-version (or hg-version, ...). However, "0" is not a tag, so the variable 'tag' needs to be renamed or inlined.=C2=A0 As it is only used in a signle place, I w= ould recommend inlining it. Likewise for 'version'.

Additionally, 'hash' needs to be inlined -- not only because it is used in a single place, but also because there is some compile-time error checking for hashes that only can work when it is inlined.

Also, I've seen a v2 for the first patch, but what happened to 2/5, 3/5, 4/5 and 5/5?

Greetings,
Maxime.

--------------EOcFeC3Dz8eUrSOMCG0s3EgN-- --------------xYlFrdLPTJUWUxvVzUrZhHOd Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------xYlFrdLPTJUWUxvVzUrZhHOd-- --------------UwXpjglw54fwba7Dzw0cS2j0-- --------------u4CMBsVRYXVjky7xwuEineku Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvIhywUDAAAAAAAKCRBJ4+4iGRcl7o7i AQCRGBXy2SaT3lbDXxizWSUtnRNKEQn/OW3tYL79YQjLngEAlYSYrpZGaeSqkYXJneB9MQgFCpqS oxCwWkK4kp875Ak= =ci3P -----END PGP SIGNATURE----- --------------u4CMBsVRYXVjky7xwuEineku--