From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WOqjKIg/P2WzSgAA9RJhRA:P1 (envelope-from ) for ; Mon, 30 Oct 2023 06:30:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WOqjKIg/P2WzSgAA9RJhRA (envelope-from ) for ; Mon, 30 Oct 2023 06:30:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 201E75829F for ; Mon, 30 Oct 2023 06:30:48 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EZylvqhO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698643848; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XN0QBIBKO8CnMhmQGhW0DKpRcEAktCGmdaSL6JKxZao=; b=uGt1U5PCNiuwzdt+vz62D0IGsDwSbonW6aee6ea3cecB/GA0e39lP0j/MSdWuYc+SrXeWS zXkHiZH/fJM6zl1fVIbqTioKawSKojplDxgdYglqV7s9CRIGv8v/Xlty3FlF487tIBcH0k 4yIsfB5jOWU7hzzfaBKThkGoaMYM6hR+Y9vo4T4HCXnYh3n5nzTXhMbLnJ2/zGEh40S7vk 0o/mEFtDSdf6zRPoKz8Y74MTSVpsEtle++AUecWOgz+JDw6GqDTK3lyf+FBt/pYYy/y+Ln CDJa1KHo3mAYJtcqgTsm3XhaKG3tyHNCT0zrDjvmqoacod59mzfdsJNp+DZAbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EZylvqhO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698643848; a=rsa-sha256; cv=none; b=DOdIRDT6i0bRcUIMDiGfEIxcRFR0Dn5lyzJrB0rN5sAoprRbffkX7l/DiwyKMYeZkepIu1 TD5wFberq2Xltvpdzm4iKoWpvvzAJN9+JgsATZzO61N0l7dmlO1EwU6hxTAmpeufw77Ff2 bdCK1o409i6Jw/PrZiiXkwjig5jxrlxiDWrJa1FqNPmqbZL0yn9fPA6OfV+e6CBh/T/RIn 7WA5/ER9YKw87L5AMRdY/o7aOtPfzhCikddY7OSSTZaN0STICdrtdi768fCCrTbyH9veJA KQ1eZ47il6dNWlWa7wbPPSst0NEl3p2GWhiEor5IJR/Qu2onF83ZEeJIjkxDrg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxKrA-0008HI-DT; Mon, 30 Oct 2023 01:30:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxKr7-0008GW-Eu for guix-patches@gnu.org; Mon, 30 Oct 2023 01:30:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxKr7-0004T4-7D for guix-patches@gnu.org; Mon, 30 Oct 2023 01:30:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxKrd-0000kP-Vz for guix-patches@gnu.org; Mon, 30 Oct 2023 01:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66801] [PATCH va3e5ae0f..37252e07 01/32] rebar-build-system and packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Oct 2023 05:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Cc: 66801@debbugs.gnu.org Received: via spool by 66801-submit@debbugs.gnu.org id=B66801.16986438212513 (code B ref 66801); Mon, 30 Oct 2023 05:31:01 +0000 Received: (at 66801) by debbugs.gnu.org; 30 Oct 2023 05:30:21 +0000 Received: from localhost ([127.0.0.1]:44161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxKqy-0000eT-Up for submit@debbugs.gnu.org; Mon, 30 Oct 2023 01:30:21 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:58567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxKqs-0000e8-Ru for 66801@debbugs.gnu.org; Mon, 30 Oct 2023 01:30:19 -0400 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-9c5b313b3ffso602465866b.0 for <66801@debbugs.gnu.org>; Sun, 29 Oct 2023 22:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698643775; x=1699248575; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XN0QBIBKO8CnMhmQGhW0DKpRcEAktCGmdaSL6JKxZao=; b=EZylvqhOP+KKO2C+JmrF/uhDBh5swP5Q0TK9JCI2SmOpaR+vdVuUW8tlhThAzJ7VsP Ged4Jrtie2z6GTyJFqbZ3ig5Ee51qCBX7K6VhWIFdkgLx3O8RB2GtXeRc5HT3k4U8C/3 323iX3upEzRRCspW+gb6+d3/2a2KFLv8ByfiFdTE94PbGL/nVH1lFUzoG3KcpAOFuqLO L/rUNdCuH6tauKUuaEC8yc4upix8HgXNKHiyWMB8PG7QwNP/K3NukmdkXEiOLit7Spl0 PxprpR/aD7iJmFI6H+WnlQMCvQ2oUAn34hXC00OmAZVxCNI4wNEUec8UYmgtcUTORvHL OGcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698643775; x=1699248575; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XN0QBIBKO8CnMhmQGhW0DKpRcEAktCGmdaSL6JKxZao=; b=geJUig2RXDVKf85G6JGp/e1D3hEpvZA3HAWsgeHITxg9BmAPcDRv6Z/bHsrv83M1VY Nw8ITAYPCrxNmX/ax3ZY0zQ2Nd0AwPFk4IeX/XSc+Ooy/HsduKq4+FThs1y8oP13/mp0 9aZ7llJs2x9zJWLPHigX+hFJj47TniZSg/Zbc9vcz91cOnqdy6DuL+LqVEvCcYnlyDnr krXtEmvpegikPwu/k+bqed+o4C51RewAMSo/9ZVayF4OQaqX2jMRlaPjtptrgu+no5eR HQB2oH9DS5B1gOXEf10VY7RJzwmAqe+7nMboWhEcof2whDCyEyoYfWGnZ2snYcvsGlHT /8xw== X-Gm-Message-State: AOJu0YwiYHcfNEMr11FqynWSxa/YDj2bHz2nU4ytzKjkSdVU+ZETpq1b inKh7wK1rifqjUko0WiJXTE= X-Google-Smtp-Source: AGHT+IHegu8EtzxqLLe1WoOpscZWaLH+GzQK+pZsih6nFYtJyzOTLqXUYZjUOoiqFG+o/o5+nBCoow== X-Received: by 2002:a17:906:fd8b:b0:9bf:30e8:5bfd with SMTP id xa11-20020a170906fd8b00b009bf30e85bfdmr7911776ejb.48.1698643775144; Sun, 29 Oct 2023 22:29:35 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id hu11-20020a170907a08b00b009d22a1422a7sm2978521ejc.42.2023.10.29.22.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 22:29:34 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Mon, 30 Oct 2023 06:29:32 +0100 In-Reply-To: References: <7ceab0dcbe069f664377786b5bb531e2196fffc1.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 4.40 X-Spam-Score: 4.40 X-Migadu-Queue-Id: 201E75829F X-Migadu-Scanner: mx10.migadu.com X-TUID: to+2GQfZ7UpT Am Sonntag, dem 29.10.2023 um 23:14 +0100 schrieb Pierre-Henry Fr=C3=B6hring: > n [PATCH v2]. So this time, it will be [PATCH v3]. >=20 > > Emacs, Rust, etc., build systems just strip out the prefix.=C2=A0 No > > need to go all fancy regexpy :)=E4=BD=95=E3=81=A7=EF=BC=9F >=20 > WAITING: Well, it makes the warning message completely explicit, for > example: > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > =E2=94=82 AssertionWarning 4dcbff27 > =E2=94=82 =C2=A0 Assertion: re matches name. > =E2=94=82 =C2=A0 =C2=A0 re =3D ^erlang-(.*) > =E2=94=82 =C2=A0 =C2=A0 name =3D something-else > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > Is it OK if it stays like this? You can use a shorter error and explain the problem better:=C2=A0 "~a does not start with \"erlang-\"" name >=20 > > Uhm, how are you improving the status quo here? >=20 > WAITING: comment updated with: > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > =E2=94=82 ;; =C2=A0 If these directories exist, then no error occurs. So,= we make > sure > =E2=94=82 ;; =C2=A0 they exist. > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > Is this OK? >=20 >=20 > [...] > > You might want to look into possible PATH variables or put these > > sources into a special folder so that you can use search-path-as- > > list. >=20 > WAITING: Perhaps an idea: > 1) If we require all Erlang packages to have an output =E2=80=9Csrc=E2=80= =9D > something > =C2=A0 =C2=A0like: /gnu/store/=E2=80=A6elixir-pkg-1.2.3/src/elixir/src/= =E2=80=A6, > 2) then (search-path-as-list '("src/elixir/src") > =C2=A0 =C2=A0'("/gnu/store=E2=80=A6elixir-pkg-1.2.3" =E2=80=A6)) would re= turn > =C2=A0 =C2=A0'("/gnu/store=E2=80=A6elixir-pkg-1.2.3/src/elixir/src" =E2= =80=A6) =E2=89=A1 lst-src. > 3) Given lst-src, it would be enough to install each source under > =C2=A0 =C2=A0_checkouts, i.e., _checkouts/lib-name/src. It is probably fe= asible > to > =C2=A0 =C2=A0retrieve lib-name from somewhere. > What do you think? Rather than require, you can add a phase to ensure that this is the case. I'm not sure whether we should make that an extra output, however; there might be many packages for which we don't need those sources and where we do need them, we could potentially add them as native-inputs. =20 Another alternative would be to keep the sources in=C2=A0 lib/erlang/lib/lib-name/src so that it gets symlinked by the phase we have. Though at that point we can surely go with a less surprising install directory. > > Also, IIUC, erlang-depends already does something rather similar.=C2=A0 > > Is there any reason it's broken for you? >=20 > WAITING: Without that (i.e., _checkouts/lib-name/src), rebar3 will > not compile things. Is this a satisfaying explaination? I mean, ideally we would store these things in some other directory, given that _checkouts/lib-name already contains the precompiled stuff after erlang-depends. However, if the tooling insists on storing both in the same place, you could simply amend the existing erlang-depends phase to 1. Copy instead of symlinking 2. Also copy the sources Cheers