From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0PPMD1ZJo2EO7AAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 10:18:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KFFdC1ZJo2GUegAAbx9fmQ (envelope-from ) for ; Sun, 28 Nov 2021 09:18:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C4D646C93 for ; Sun, 28 Nov 2021 10:18:13 +0100 (CET) Received: from localhost ([::1]:39692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrGK4-0003Hc-OL for larch@yhetil.org; Sun, 28 Nov 2021 04:18:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrGJv-0003FX-B3 for guix-patches@gnu.org; Sun, 28 Nov 2021 04:18:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrGJu-0000yt-2t for guix-patches@gnu.org; Sun, 28 Nov 2021 04:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrGJt-0002GH-S2 for guix-patches@gnu.org; Sun, 28 Nov 2021 04:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51534] [PATCH v2] gnu: Add smplayer. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51534 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai , 51534@debbugs.gnu.org Received: via spool by 51534-submit@debbugs.gnu.org id=B51534.16380910798686 (code B ref 51534); Sun, 28 Nov 2021 09:18:01 +0000 Received: (at 51534) by debbugs.gnu.org; 28 Nov 2021 09:17:59 +0000 Received: from localhost ([127.0.0.1]:34932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrGJr-0002G1-Dh for submit@debbugs.gnu.org; Sun, 28 Nov 2021 04:17:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrGJl-0002Fk-Gl for 51534@debbugs.gnu.org; Sun, 28 Nov 2021 04:17:56 -0500 Received: by mail-wr1-f66.google.com with SMTP id u1so29449195wru.13 for <51534@debbugs.gnu.org>; Sun, 28 Nov 2021 01:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=iCktzbjh6c3sL4qtl77nVD3Q4vNFmIJFac/AO0SS4To=; b=RC9LYOjrDONxhfgiPXo80cjONbPNMYOUWvvODYK5wqleYLqxgXr/Qm+LBQK87QcK0l 4jjiPOXFWKiIN4z9QogRsMA4MgzMx68XhlschYE0kpEZWy0Xy1DJyE1vEkFr2fxkvJKt l20SW9+xTJW8oelcLy6yuiR/PSawd0VsFmgsA+IBovPZb2IXjZrkVTXQXKqU+9dh4l9P GEsEMbtvUUi+myqF65+FbKtct0pwaz6Vf9g4z+vBbMxreKBmnaVlds5rRBqsvhNHvKkO /iRov5H11Kxt5CHwAZLUL91U+ISvjB99jaVGbZh1mxFTyVPZcg3gFov8D8mbj0iTALFd ZjyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=iCktzbjh6c3sL4qtl77nVD3Q4vNFmIJFac/AO0SS4To=; b=AJWd1ij1kAfm1FQUpf7MZBOZdNEkZFbxK7O/Z+/DhlUdZRzkWlROJOObxOqwstMlh6 NkQLV6miDawcs3SFTO3qLkocCa3oj9OWrn7ecXOrc3bKh7S6hEqelcLbGKfJEjNtxmQM G1ipaSN6v2v6vxLZyw2oAMSkdL44vUzdp+ElO9+y5lkGAtmqd+Sp3B0KijrwCFFZwn2S aafzLo2aTa002gzKvOjfyNIZxzNpxGa5m3vhsQKuzFHIdbTuh3Mr1MTZGYy12OdWO3Q3 H8fVLGEUvTEPeS5w+sYTgVnmGjbkOt7g9uxzzldgXrb0w917cTgx31cQsBBcB4Vjhq+3 oa5g== X-Gm-Message-State: AOAM533dWcVRfmezRWUPmgmYCA+BnGPCvBIMvGt4Y+Emb5beOO0O0iQx 2T0UsSQw+54mV6t+AnvfiM4= X-Google-Smtp-Source: ABdhPJxihsoqfP8MeVUfzac0wr0zL88VzBtRnBlJbGv9HFDUxOUurSukFTn7bEytJ6rAogefPjwY4A== X-Received: by 2002:adf:f352:: with SMTP id e18mr26537072wrp.39.1638091067713; Sun, 28 Nov 2021 01:17:47 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l5sm12728467wrs.59.2021.11.28.01.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 01:17:47 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sun, 28 Nov 2021 10:17:45 +0100 In-Reply-To: <20211101010411.10306-1-attila@lendvai.name> References: <20211101010411.10306-1-attila@lendvai.name> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638091094; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iCktzbjh6c3sL4qtl77nVD3Q4vNFmIJFac/AO0SS4To=; b=nyJnV61b1waEw98Tsg8Ux4W7aCK3k3GnnPJncBLN9fZGuCPdHqN7UOPAfmzIJjr3Jc1B/K hIOEJwbRlQNfJnMfQP3mMIYqfQwhy8Ks9vmEwGq7zf7zn9B1cIApXeMqsl4XJbhblb0Oa1 rVemZmmVqCn0JRHBeuqkF/7fnGN8Dj/+J6Y06aXo1M4bk2kgkz0uY/I3CncghBIUQVixRJ eZ/4KNTypJK6vVujkj27luuOc52dh94kVWMZHpUn+HHLPhJsEhKNyOYbBnE1YUthAhWmgM f9X20+9py0JooMP8muvo/LMiwJI4Mp/YODktcvOH7kbgvcanvzrz/ZNFXMYJxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638091094; a=rsa-sha256; cv=none; b=RMmd+s709UFpuZ/kHSnw1KaFVhwlQbDxXlp6g1+yriDC8mlFNseOog07G7EdIGic8MQ8Pf lj/zn4rmnkK/F3u7nAbvRPtWfNYMxbG4WzdYZVXzPWpQN9nKJhKbKcEekJX7jz51VQ+qpY AWzfjchmyptHtx677cQnoCeYC7Yh8GSr1N9GWd2Ux48gq4jWa85kLrjozBsezXXyFZCYgw +zBsARt05iUmsX2IS5ZGaEkqnbGdT6JH4EQxrsd5dKSTmHcukpYKv0VrrkAld88cabjC7U WNalkI5BxF2Kq459+7+IkV18ZnLpuk4OeyfKnNRxRTqS2AFLIORryUaS0MtysA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RC9LYOjr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RC9LYOjr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C4D646C93 X-Spam-Score: -1.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: jpNZtWli+LpL Hi, Am Montag, den 01.11.2021, 02:04 +0100 schrieb Attila Lendvai: > * gnu/packages/video.scm (smplayer): New variable. > --- > > i forgot to double check the licence, it's gpl2+, not gpl3+. > otherwise, it's the same as the previous patch. > > gnu/packages/video.scm | 60 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 245007f294..2915f85352 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -2092,6 +2092,66 @@ (define-public mplayer > SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.") > (license license:gpl2))) > > +(define-public smplayer > + (package > + (name "smplayer") > + (version "21.10.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://sourceforge/smplayer/SMPlayer/" > version > + "/smplayer-" version ".tar.bz2")) > + (sha256 > + (base32 > + "12nvcl0cfix1xay9hfi7856vg4lpv8y5b0a22212bsjbvl5g22r > c")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("qttools" ,qttools))) > + (inputs > + `(("qtbase" ,qtbase-5) > + ("zlib" ,zlib) > + ("mplayer" ,mplayer))) > + (arguments > + `(#:modules (,@%gnu-build-system-modules > + (srfi srfi-26)) > + #:tests? #false ; no tests > + #:make-flags (list (string-append "PREFIX=" (assoc-ref > %outputs "out")) > + (string-append "CC=" ,(cc-for-target)) > + ;; A KLUDGE to turn off invoking lrelease > on the > + ;; project for now, because it fails > consistently > + ;; with "WARNING: Could not find qmake > spec > + ;; 'default'". See below. > + "LRELEASE=true") > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + ;; Due to the above, we must run lrelease separately on > each .ts file > + ;; (as opposed to running `lrelease-pro smplayer.pro` for > the entire > + ;; project, as the Makefile does normally without the above > kludge). > + (add-after 'build 'compile-ts-files > + (lambda _ > + (for-each (cut invoke "lrelease" <>) You might want to spell out that cut to avoid needing SRFI 26. If you do want to use SRFI 26 I'm pretty sure that cute is the more efficient variant here. > + (find-files "./" "\\.ts$"))))))) > + (home-page "https://www.smplayer.info") > + (synopsis "Complete front-end for MPlayer, a media player") > + (description "SMPlayer is a free media player for Windows and > Linux > +with built-in codecs that can play virtually all video and audio > formats. > +It doesn't need any external codecs. Just install SMPlayer and > you'll be > +able to play all formats without the hassle to find and install > codec packs. > + > +One of the most interesting features of SMPlayer: it remembers the > +settings of all files you play. So you start to watch a movie but > you have > +to leave... don't worry, when you open that movie again it will be > resumed > +at the same point you left it, and with the same settings: audio > track, > +subtitles, volume... > + > +SMPlayer is a graphical user interface (GUI) for the award-winning > +MPlayer, which is capable of playing almost all known video and > audio > +formats. But apart from providing access for the most common and > useful > +options of MPlayer, SMPlayer adds other interesting features like > the > +possibility to play Youtube videos or download subtitles.") Descriptions are for describing, not for advertising. Please cut it down to the meaningful bits. > + (license license:gpl2+))) > + I haven't built or ran the package, but from my lexical analysis I did infer it was a more or less standard Qt thing. I'm not sure if you need to wrap some Qt-specific variables here similar to how it's done in qt-build-system. Otherwise LGTM. Cheers