From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8O42EuCQGGQZWQEASxT56A (envelope-from ) for ; Mon, 20 Mar 2023 17:59:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id Ix47EuCQGGT+eAAA9RJhRA (envelope-from ) for ; Mon, 20 Mar 2023 17:59:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D076213ADD for ; Mon, 20 Mar 2023 17:59:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peIpi-0005vT-2q; Mon, 20 Mar 2023 12:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peIpe-0005uc-KM for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peIpe-0002HB-CP for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peIpe-0002hA-6P for guix-patches@gnu.org; Mon, 20 Mar 2023 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62156] [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62156@debbugs.gnu.org Cc: Sergey Trofimov , Felix Lechner Received: via spool by 62156-submit@debbugs.gnu.org id=B62156.167933145810321 (code B ref 62156); Mon, 20 Mar 2023 16:58:02 +0000 Received: (at 62156) by debbugs.gnu.org; 20 Mar 2023 16:57:38 +0000 Received: from localhost ([127.0.0.1]:55607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peIpF-0002gP-Uh for submit@debbugs.gnu.org; Mon, 20 Mar 2023 12:57:38 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:49950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peIpB-0002g0-7k for 62156@debbugs.gnu.org; Mon, 20 Mar 2023 12:57:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=D8ikgbx9065o6pv cXlvVkkW15a2MxFYRWM5taKshdGY=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=KEyjPmhLWRxT+VSEZlrXS2uLklvI1rjg+KZyMPhD t/xmDl3O4gwKcKKiCfHB2Hujm3ocVP+n75budIPM/DxI7A3Lhsp1DYXT07aiE6jM3vAoMy ZsogHIuXnCGrhCBEx4QdyLP3rzFDPpvZyT7PAR4SEWC0AyW47Dy3gvP8ubOyo= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 4d86524f (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 20 Mar 2023 16:57:32 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fdb59c85; Mon, 20 Mar 2023 16:57:32 +0000 (UTC) Date: Mon, 20 Mar 2023 09:57:19 -0700 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679331551; a=rsa-sha256; cv=none; b=cDZXaEBYXsO/T7g8vzJum73A55FbWPVSrq6KgQ3EZRK/dWdaJ7nWGwmZ9m0lNOZr2dtwoS H557DDAL8BbdeQ6BsAJO452jwVJEWtw+7ffG34vRiyj1MoDuKLGCO5rxIAs30djIdp14xB RY+fJzauB51F1A90bhtrZIVVR143rQQL0NIoJ12+BJQPK7JdL7zJQZW1mFh1dQBZhtoXAo QMjg4wk0gre55GgLMvmZVdVdLsxRcFlX46v6kLCpLh/wy0+VLRfTilQt/Uj/S+UARvHOov b9MZQ0voBEVGKh6OkV6oHwm16H/ZVuIXEPu2LQ5KQDA9lU5ljpfMHeXw4Cb5eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=KEyjPmhL; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679331551; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JPTmToKvT/G2kp6QmoIMqP4Epi1n7h550VqxunHZYRs=; b=mMUgoku/xG2Bg9EQfBpyKz8oRlW3aE6m46I4oNYosSjnUPYyYcRqh/CKKYeqnFugj2R+Cg VR4baEEFKsfcyNYvdUujKCjfbohT8fojcmMZyYF+cWWqxytirdVnrzFxdJqdbKxPD4mv9b BpI8GnFP1980c/Ozp5AbwTXsxG3LAgZWNFq2zJ4/nPlvTIO2KeIQUU6qKJem8noF8vKuxl k5cB0UCVbyVgNhtpBnOqo0cDiXmVub6CxZ8Fn/6b7+DYLV0mPxqwmEdY10hnGucIMP8APK 1Ce0T5e+ufWZJcuz/2kFkR8/0Gfi0fVnXiLDnXpTWPU1+2a7EjNUaqo+wQm1gg== X-Migadu-Spam-Score: -3.26 X-Spam-Score: -3.26 X-Migadu-Queue-Id: D076213ADD Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=KEyjPmhL; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: dzw3Ym3C2qhQ For the atftp package added in the preceeding commit, lint produced this warning: gnu/packages/networking.scm:2924:5: atftp@0.8.0: URI https://git.code.sf.net/p/atftp/code not reachable: 404 ("Not Found") Thanks to Sergey Trofimov for suggesting a fix! [1] [1] https://issues.guix.gnu.org/62156#3 It was implemented here, and the warning disappeared. * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url. Co-authored-by: Sergey Trofimov --- guix/lint.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guix/lint.scm b/guix/lint.scm index a1a27873d9..394d68c472 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -1224,7 +1224,9 @@ (define (warnings-for-uris uris) '()))) ((git-reference? (origin-uri origin)) (warnings-for-uris - (list (string->uri (git-reference-url (origin-uri origin)))))) + (list (string->uri (string-append + (git-reference-url (origin-uri origin)) + "/info/refs"))))) ((or (svn-reference? (origin-uri origin)) (svn-multi-reference? (origin-uri origin))) (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin)))) -- 2.39.1