all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#71751] [PATCH] gnu: python-trio: Disable failing test.
@ 2024-06-24 17:18 Juliana Sims via Guix-patches via
       [not found] ` <handler.71751.B.171924974921821.ack@debbugs.gnu.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Juliana Sims via Guix-patches via @ 2024-06-24 17:18 UTC (permalink / raw)
  To: 71751
  Cc: Juliana Sims, Lars-Dominik Braun, Marius Bakke, Munyoki Kilyungi,
	Sharlatan Hellseher, Tanguy Le Carrour, jgart

Hello,

This test has begun failing, causing the build of python-trio to fail as well.

Oddly, there doesn't appear to be any change in the Trio code that should
trigger a new test failure, so this may not be the best solution. However, the
code for is_main_thread() relies on signals working properly, which, as the
adjacent comment points out, does not work at build time.

If anyone has a better idea of what's going on here and, therefore, how to fix
it, feel free to offer input or a better patch. In the meantime, this should get
python-trio and its dependants building again.

Thanks,
Juli

* gnu/packages/python-xyz.scm [arguments]: Disable failing test.

Change-Id: I8a066fd17654ce8b1dfb0411d8df621e0f45a63d
---
 gnu/packages/python-xyz.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9ad89b8c32e..341b0c6feaf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -28882,6 +28882,7 @@ (define-public python-trio
                          " and not test_for_leaking_fds"
                          ;; Signals don’t work in the build sandbox.
                          " and not test_open_signal_receiver"
+                         " and not test_is_main_thread"
                          ;; These try to raise KeyboardInterrupt which does not work
                          ;; in the build environment.
                          " and not test_ki_self"

base-commit: ac105faf4ceb67468c7011505a07a67b0c1b045f
-- 
2.45.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#71751] Acknowledgement ([PATCH] gnu: python-trio: Disable failing test.)
       [not found] ` <handler.71751.B.171924974921821.ack@debbugs.gnu.org>
@ 2024-06-24 17:29   ` Juliana Sims via Guix-patches via
  2024-07-01 16:48     ` Juliana Sims via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Juliana Sims via Guix-patches via @ 2024-06-24 17:29 UTC (permalink / raw)
  To: 71751

I happened to be reading the NEWS file for Guile 3.0.10 when my system 
reconfigure failed, leading me to notice and fix this failing build. 
After submitting this bug, I returned to reading that file and noticed 
a mention of signal handling in child processes[1]. Could this be 
related to the present issue of signals at build time?

-Juli

[1] http://git.savannah.gnu.org/cgit/guile.git/tree/NEWS#n206







^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#71751] Acknowledgement ([PATCH] gnu: python-trio: Disable failing test.)
  2024-06-24 17:29   ` [bug#71751] Acknowledgement ([PATCH] gnu: python-trio: Disable failing test.) Juliana Sims via Guix-patches via
@ 2024-07-01 16:48     ` Juliana Sims via Guix-patches via
  0 siblings, 0 replies; 3+ messages in thread
From: Juliana Sims via Guix-patches via @ 2024-07-01 16:48 UTC (permalink / raw)
  To: 71751

It appears that whatever was causing this build to fail no longer is.






^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-01 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 17:18 [bug#71751] [PATCH] gnu: python-trio: Disable failing test Juliana Sims via Guix-patches via
     [not found] ` <handler.71751.B.171924974921821.ack@debbugs.gnu.org>
2024-06-24 17:29   ` [bug#71751] Acknowledgement ([PATCH] gnu: python-trio: Disable failing test.) Juliana Sims via Guix-patches via
2024-07-01 16:48     ` Juliana Sims via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.