From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id mF2/NsGhPGeBPQAA62LTzQ:P1 (envelope-from ) for ; Tue, 19 Nov 2024 14:33:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mF2/NsGhPGeBPQAA62LTzQ (envelope-from ) for ; Tue, 19 Nov 2024 15:33:37 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TMgJXmaa; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=X4n7hBv7; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732026817; a=rsa-sha256; cv=none; b=JOwg01hcx5oWYAuJvDsnUIrs3SYYXUQcFn6h3s+iV5ithkoPdLVeyOoq0MGR55//Xz3hQG +lLKZGIQSneMI7ynoZmS1uUwYaNko5Mxb1/Bixo1+YmPwti3amINOd0CpW+WXo5QTHT8VD 5zSBSDHYNdjO7EXzXABzJTapHhWxMxXUjNzZzNIiwplhx4rdQd0Q0ocTYk1vXhOXYRtBKv BXtz9pK+G3qggCXvqk+RUQORYNfzMXyvMav61V/0ZAFLUX+pLoCyUr8zk3UgOlyCXLzPw5 yoNAMgfUHkiFqLRLcb8b/gcXbEIZD5Sf0SeGKyvO4pQZ7y9uNCgm1Jdp3QmPnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TMgJXmaa; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=X4n7hBv7; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732026817; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3KzxGDH5Y+5Fa5l2UNxRLyTKPlYRnBaF3oZwCb8CLk0=; b=PeydLt/2UKCIZUsRlj20QVyV37tIhQA1iYpyGKIt1SnCwO9snvF1cA5dK/3HSqQo9RnIIc tVoCsQQZaOZzVXAnPTWfb5Rh7nJZj9wsAy8NfBTpr6xN5fXsaSbNFz9uq07dJsixGNY99T ZM7kTb4iTqhr6t5MjbkWF95TzuhOlfDdpVv9qRyoxrGQdHUPPZXuOmr7TZZIo1CC5dTcNU RETYWp3HnYpKwBUY3I1NgoH2OWSbrM38z7aIcWLJvXO6IMdH+XasvrcQfv4iyRuFZLMeoX GitsGlAEndHW1vb+Wo8ExeV0bPjVwmSArVhtv0xrhMqf2FKXzdhcRm6cuW8WFA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6664F818EE for ; Tue, 19 Nov 2024 15:33:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDPHy-00080m-Pv; Tue, 19 Nov 2024 09:33:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDPHs-000803-LD for guix-patches@gnu.org; Tue, 19 Nov 2024 09:33:07 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDPHr-0007F7-Qk for guix-patches@gnu.org; Tue, 19 Nov 2024 09:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=3KzxGDH5Y+5Fa5l2UNxRLyTKPlYRnBaF3oZwCb8CLk0=; b=TMgJXmaaRP5bavCau3+7p0J61cy5gELapaQvqAwoBUqtk3YHcy6TooUdT9ASU7g4tAioPfNSO1u5AGoQ/gyjqS0A/Gf7uwUgAxoQPaGDIu4ZhCMDFqJ2szw5Xr1JmQ4Ebo138759KtWaRWi+sUi2i2A2xZovY4e6UXuJwfDgQTEFRxaGTN8tW+2165sxYQtWiTgOw+HcKJKkwO/+gzf1qQdFWV98jNHUVyVRgePBa7ZXCLOrhX3WSSemuYn2FdBrPKEPhpIF9pLObNE/6vljo+euHtIXExW/kkCWrGqhp+NJSwMGHTX+TEz8ZBpg94rrAqmqtxrjBqqdUJhanV1asQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDPHr-0000bW-3w for guix-patches@gnu.org; Tue, 19 Nov 2024 09:33:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Nov 2024 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier , 74225@debbugs.gnu.org Cc: Christopher Baines , Josselin Poiret , Tobias Geerinckx-Rice , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe Received: via spool by 74225-submit@debbugs.gnu.org id=B74225.17320267762305 (code B ref 74225); Tue, 19 Nov 2024 14:33:02 +0000 Received: (at 74225) by debbugs.gnu.org; 19 Nov 2024 14:32:56 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDPHj-0000b7-9l for submit@debbugs.gnu.org; Tue, 19 Nov 2024 09:32:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:58827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDPHg-0000ag-87 for 74225@debbugs.gnu.org; Tue, 19 Nov 2024 09:32:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0EF2B240028 for <74225@debbugs.gnu.org>; Tue, 19 Nov 2024 15:32:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732026766; bh=t6jlU7zv5VsB4JF+rXwP+tH6CvjDFZdoReZTrpI1Anw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=X4n7hBv77nZiwnAmLXyMGaH3EHSCHSSXanL4Gi4UXFbwN1umN0+zNZfYnAa+L2AO+ /3W75s2YxTRyFm+xgtFGUo6yEQ1PnLGnixCcoO8mCwFlBAsSasIauH+WMaELrzmG3u xw1B7PEwGY82umEIhhGtq512Je6IqGkhxh8tfzUCqGufGxgiwAb0fQRjZ/iu2K24rB VC9QWi9Zzem5izNcOC8hBUtqKOWFSWS/fwQnvip8Lf4f9H88rppjdbZo1B4oU1PQnc q26pSeUhTUuO6QoO0Rjn+DhZ5s2aP6/SKVqVIJjssjslkF9ZvwaP2cCA33W8Mo4ooa Yw5WTEXBNu7lw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xt6Qz124Rz6v0H; Tue, 19 Nov 2024 15:32:43 +0100 (CET) Message-ID: Date: Tue, 19 Nov 2024 14:32:33 +0000 MIME-Version: 1.0 References: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> <87ed3bbnz9.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87ed3bbnz9.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.49 X-Spam-Score: 0.49 X-Migadu-Queue-Id: 6664F818EE X-Migadu-Scanner: mx10.migadu.com X-TUID: wYH7i9PhcS01 Hi Simon, On 16.11.24 09:07, Simon Tournier wrote: > Hi, > > On Wed, 06 Nov 2024 at 10:46, Dariqq wrote: > >> diff --git a/guix/lint.scm b/guix/lint.scm >> index 8c6c20c723..4ba728da33 100644 >> --- a/guix/lint.scm >> +++ b/guix/lint.scm >> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) >> (match delta >> (`(replace 'check ,expression) >> (check-check-procedure expression)) >> + (`(add-after ,_ 'check ,expression) >> + (check-check-procedure expression)) >> + (`(add-before ,_ 'check ,expression) >> + (check-check-procedure expression)) > > Please note that 'check here is up to packagers. They might pick the > symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or > whatever else. To my knowledge, there is no real convention. > Of course this is not perfect because the name of the phase to run the tests is arbitrary but this (simple) change catches this problem in 38 packages currently in guix (and 'check seems to be convention in guix) This came out of a frustration with failing tests in u-boot-tools which implements a custom 'check phase after 'install which before e6ec657c497cdfe9130b7bf5bdfb717a823bf02b were unskipable but passed the lint check. > Well, I do not know. > > Cheers, > simon Dariqq