From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix Date: Wed, 06 Jul 2016 13:08:24 -0500 Message-ID: References: <87vb1yjj2u.fsf@gnu.org> <20160610163849.GA4631@thebird.nl> <8737oimkt4.fsf@gnu.org> <87eg77izg8.fsf@gnu.org> <87oa6bl603.fsf@elephly.net> <20160706115458.GA27492@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKrFb-0003Gm-4Z for guix-devel@gnu.org; Wed, 06 Jul 2016 14:08:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKrFZ-00012B-3S for guix-devel@gnu.org; Wed, 06 Jul 2016 14:08:42 -0400 In-Reply-To: <20160706115458.GA27492@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org, Dennis Mungai , Guix-devel On 2016-07-06 06:54, Efraim Flashner wrote: > On Wed, Jul 06, 2016 at 06:55:56AM +0200, Ricardo Wurmus wrote: >>=20 >> Roel Janssen writes: >>=20 >> >>From 451d93eaaab6166e38e33f0556fe40f83afefc5c Mon Sep 17 00:00:00 20= 01 >> > From: brainiarc7 >> > Date: Tue, 5 Jul 2016 22:42:24 +0200 >> > Subject: [PATCH] gnu: Add LLVM 3.8. >> > >> > * gnu/packages/llvm.scm (llvm-3.8): New variable. >> > * gnu/packages/llvm.scm (clang-runtime-3.8): New variable. >>=20 >> Please split this into two commits. One for adding the =E2=80=9Clicen= se:=E2=80=9D >> prefix, and another to add the new variables. >>=20 >> Other than that it looks good to me. Thank you, Roel and Dennis! >>=20 >> ~~ Ricardo >>=20 >=20 > Do we want to change the default llvm and clang to 3.8 also? Yes, I think we should. And fix the fallout from that change. I have a few other issues with this patch: 1) It copy-pastes too much from the llvm package, rather than relying on=20 a simple inherit like other versions. 2) It introduces cmake flags for things that are default, e.g.=20 "-DLLVM_ENABLE_PIC=3DON" 3) It uses the "-DCMAKE_BUILD_TYPE=3DRelease" flag rather that our=20 cmake-build-system's #:build-type keyword. 4) It adds libffi and zlib inputs. These are not strictly necessary for=20 the build, so I would prefer they be added in a separate commit. Also,=20 there's a missing "-DLLVM_ENABLE_FFI:BOOL=3DTRUE" flag, so the build=20 system doesn't use the new input. 5) It doesn't also add a clang@3.8.0 package. While this could be done=20 later, I'd prefer it be done at the same time, like previous llvm=20 updates. I have been working on this update in parallel. I've incorporated some=20 parts of this patch, and I'll post the series here soon. --=20 `~Eric