From: Manolis Ragkousis <manolis837@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27307-done@debbugs.gnu.org
Subject: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.
Date: Mon, 10 Jul 2017 17:18:51 +0300 [thread overview]
Message-ID: <f8a3638c-054c-e8f9-b5c2-c172599f3004@gmail.com> (raw)
In-Reply-To: <87shj7ltp6.fsf@fastmail.com>
Hey Marius
On 06/10/2017 06:59 PM, Marius Bakke wrote:
> manolis837@gmail.com writes:
>
>> * gnu/packages/compression.scm: Remove incorrect '"'.
>
> Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..."
>
> [...]
>
>> - (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\"
>> + (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\
>> unshield-avigomanager11b22.zip?dl=1"))
>
> I guess you can also remove string-append here? Alternatively, quoting the
> next line and indenting it would look a little better IMO.
I went with your second suggestion, I liked it more as well :)
Pushed the updated patch to master.
>
> Sorry for the review failure! :-)
>
I should have been more careful :P Thank you for your time and help!
Manolis
prev parent reply other threads:[~2017-07-10 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 13:23 bug#27307: [PATCH] gnu: unshield: Remove incorrect '"' manolis837
2017-06-10 14:26 ` Ludovic Courtès
2017-06-10 15:59 ` Marius Bakke
2017-07-10 14:18 ` Manolis Ragkousis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a3638c-054c-e8f9-b5c2-c172599f3004@gmail.com \
--to=manolis837@gmail.com \
--cc=27307-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.