From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@openmailbox.org>
Subject: Re: [PATCH 4/4] services: Add network-manager-service.
Date: Thu, 26 Nov 2015 14:01:24 +0800
Message-ID: <f755e4bccc80cf304f52269c62eddf0a@openmailbox.org>
References: <1447653973-3839-1-git-send-email-iyzsong@gmail.com>
	<1447653973-3839-4-git-send-email-iyzsong@gmail.com>
	<87twok7gza.fsf@gnu.org>
Reply-To: iyzsong@member.fsf.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a1pch-0002Y5-OA
	for guix-devel@gnu.org; Thu, 26 Nov 2015 01:01:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a1pce-0003Ns-I7
	for guix-devel@gnu.org; Thu, 26 Nov 2015 01:01:39 -0500
Received: from smtp14.openmailbox.org ([62.4.1.48]:49409)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1a1pce-0003Nb-CU
	for guix-devel@gnu.org; Thu, 26 Nov 2015 01:01:36 -0500
In-Reply-To: <87twok7gza.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ludo@gnu.org
Cc: guix-devel@gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>

On 2015-11-18 00:01, ludo@gnu.org wrote:
> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>=20
>> * gnu/services/networking.scm (network-manager-service): New=20
>> procedure.
>> (network-manager-service-type, %network-manager-activation): New=20
>> variables.
>> (network-manager-dmd-service): New procedure.
>=20
> [...]
>=20
>> +(define (network-manager-dmd-service network-manager)
>> +  "Return a dmd service for NETWORK-MANAGER."
>> +  (list (dmd-service
>> +         (documentation "Run the NetworkManager.")
>> +         (provision '(networking))
>> +         (requirement '(user-processes dbus-system loopback))
>> +         (start #~(make-forkexec-constructor
>> +                   (list (string-append #$network-manager
>> +                                        "/sbin/NetworkManager")
>> +                         "--no-daemon")))
>> +         (stop #~(make-kill-destructor)))))
>=20
> I guess that even if NM can be activated by dbus-daemon, we prefer to
> start it explicitly like this, right?
>=20
> I suppose relying on dbus activation means that you could end up with=20
> no
> networking until you actually start network-manager-applet or one of
> these clients.
I haven't test the dbus activatation, at lease nmcli won't do that.
Yes, and having a dmd service is convenient.

>=20
>> +                       ;; Add network-manager to the system profile.
>> +                       ;; XXX: Should we add network-manager-applet?
>> +                       (service-extension profile-service-type=20
>> list)))))
>=20
> I think network-manager-applet could be added to profile-service-type,
> but only as part of %desktop-services.  WDYT?
OK, that make sence.
>=20
> Otherwise LGTM!
>=20
> In a subsequent patch, you can add network-manager-service to
> %desktop-services I guess.  :-)
I only push this, because %desktop-services aleadly contains=20
wicd-service.
And more important, I haven't test wireless network (my card don't work=20
with linux-libre).

Thanks for the review!