From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cLxEOQ7plmWbIQAAkFu2QA (envelope-from ) for ; Thu, 04 Jan 2024 18:21:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id eBiLNA7plmV4cQEAe85BDQ (envelope-from ) for ; Thu, 04 Jan 2024 18:21:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Es7UZqPw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704388878; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BiutayVm6NPbRf78pJg3KD7ojgiyCyhxuOrtuONUdeo=; b=X8dHwkjWOA+WlhZtfvDWsuepuvmEa7uQW/dHdGhv0mKZpngiaCM7PqcLinJ9W3mlhUEEmd WcFwv7Sd19RSMKFWxlafpShmYNt/P0qPpjpqpNoCFgL7ad0Pyg3hmN7/v1+bUo43d32mTz ippDwRtLEGVvXKE0fRo+6fyra16d2JAE8dYhLfFmL9HRK3YinAipwklWP2CXGuhNYZ/514 SmjSYxorVOtmWZm3eTeRwlKguOdF9ETyLctA+qOuJM2qEFG1Du33+5hRTBXUqDJjaWyLk3 Evb0zagPPrU0tub2OpaY8GrxW5XDjx/A53xjvNMRS/NJkTPHJtN6euFc+/OLOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Es7UZqPw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704388878; a=rsa-sha256; cv=none; b=bUIGSaixWhqY6y7kjvTLoGgrrApjnLgbqHLpPAMaJtlPKq4OuQUo7VrkC+yzXZgVV+rxwZ lXWLOXz8Dv4nClVqxhNY6CPlY1RMEGbhvTbnNs3aG6GCas8mK/rjRCsnmK7iQyudlKl9pi CqZddRAaappr56c6kY4kpPHDKMKlg+2UXUdRVYHPP6zu/g89st4NipUhtTnBB8J8s32w+y kWFmXtGplNiGDcQST50J2+hriSAEnTBJmFfeQSNbvIYEFHL4y0LPpv3yb4UH3hrXF0i4J6 fjmGn4Da/YV/mt41ouHxWbEEriRlDb3NwcURuP5y3Kpl+wTk+7KnLLS3wBDE5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83BA16683C for ; Thu, 4 Jan 2024 18:21:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLROv-0006zp-G4; Thu, 04 Jan 2024 12:21:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLROs-0006ze-PN for guix-patches@gnu.org; Thu, 04 Jan 2024 12:20:58 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLROs-0000TA-He for guix-patches@gnu.org; Thu, 04 Jan 2024 12:20:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLROw-00030J-3E for guix-patches@gnu.org; Thu, 04 Jan 2024 12:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67681] [PATCH] gnu: Add node-commander. Resent-From: hrn Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 Jan 2024 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67681 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Maxim Cournoyer Cc: 67681@debbugs.gnu.org Received: via spool by 67681-submit@debbugs.gnu.org id=B67681.170438884111514 (code B ref 67681); Thu, 04 Jan 2024 17:21:02 +0000 Received: (at 67681) by debbugs.gnu.org; 4 Jan 2024 17:20:41 +0000 Received: from localhost ([127.0.0.1]:55593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLROb-0002ze-CI for submit@debbugs.gnu.org; Thu, 04 Jan 2024 12:20:41 -0500 Received: from mout01.posteo.de ([185.67.36.65]:47537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLROY-0002zO-Nw for 67681@debbugs.gnu.org; Thu, 04 Jan 2024 12:20:39 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 41B20240028 for <67681@debbugs.gnu.org>; Thu, 4 Jan 2024 18:20:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704388828; bh=kXz6NbeD2UU9AH8RUMIqXxon9U2VPSF1PjtSdUa91s8=; h=MIME-Version:Content-Transfer-Encoding:Date:From:To:Cc:Subject: Message-ID:From; b=Es7UZqPwMaAXDqzAC0YoZqeFvEZhCzmnvgHP+C+PC9pJXhVWi/Lib90sfllheKewT JgiVmfe9vxXEPOCVlsgqh5gZKNU+sFieK8JP0HuKYUjK9K9NEKI6WKuP5JCsMkm4PP j9+xsmvvg2rRTsyeaDU3/YqC167L30bgMYW1FHg+Drf4i2F4zS8tQ8weRVT/bBXICn zQAOYAAv1kOiPCpr4dXQvLFGIO38/aQ2JHSW4iXeHBqTfr8h6vKC+Wn8l2Jadiy56q 7NeXua4grJfRELdl0lDBHcNL+r/3vJQd2E2VA3JZMfqUDNXAUu3t5xlIEH3mQPbNAo P2z+2ZR0qfxiQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T5YJC5TQNz6tvk; Thu, 4 Jan 2024 18:20:27 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 04 Jan 2024 17:20:27 +0000 From: hrn In-Reply-To: <87bka14vva.fsf@gmail.com> References: <5309647d34306d09dba21177002f96a7d7f39e74.1701937716.git.hrn@posteo.net> <87bka14vva.fsf@gmail.com> Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.17 X-Spam-Score: -5.17 X-Migadu-Queue-Id: 83BA16683C X-Migadu-Scanner: mx10.migadu.com X-TUID: dm5uXDSyHDLg Hi, Thanks for reviewing! > Why is the test suite disabled? A comment (explaining a good reason) > is > needed :-). This is what many node packages in node-xyz.scm does. I think this is because the tests are difficult to bootstrap. The dependency chains for the tests are typically large and circular. > A comment explaining why these are removed would help. This is also the norm in node-xyz.scm. The excluded dependencies are for development and can in many cases be very difficult to bootstrap. To be able to make progress with packaging node packages it seems to me that the general strategy has been to disable tests and dependencies needed for tests. My assumption might be wrong though. Do you still think I should add comments? > Could you please expand a bit on the description? What features does > it > have? Keep it factual; "The complete solution ..." sounds like > marketing language. I agree that this needs to be changed. I blindly copied what the package said about itself. Best regards, Rikard