From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 2JfoJF+0U2VpyAAA9RJhRA:P1 (envelope-from ) for ; Tue, 14 Nov 2023 18:54:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2JfoJF+0U2VpyAAA9RJhRA (envelope-from ) for ; Tue, 14 Nov 2023 18:54:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4794D17A14 for ; Tue, 14 Nov 2023 18:54:39 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=R1aK92qo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699984479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GITUEuvGJS7vJ9BpurNBLvcJSIRM/h+hHyB7xN8moj4=; b=Kh/e4Unc6WovJ2H+nQU0zNzOgPuKpYi0l80otZU/l9lzYIXUyTQUbKxVrgNvH//DSKQ/5/ e7Lzc18lzRllhE5NtrLdqXEb9X+J6ZBEWBy3ZWTEy5XJA5lQJVCb4FtrW5n8vVmEqvi1RQ D8ALsulYzKvjSpf2IOROZXrV2w9S7TP81G/tr6qOsbs8p9o2zm2Agocj2zeNYdXcYfTe7H Zn3wC/tUMvMR/MeVEKzm4Hb1g91g5cgpJTGBYzFbJ4csA73FCaSCUKAeuSuP1LGnh+lXx1 TncCsU9l4QFkYdmUUaCw7OijdHHfgD/02jTIF9R3qse0LoE2Tk73HHDUc8N49A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=R1aK92qo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699984479; a=rsa-sha256; cv=none; b=VX0YFwakR2eP6EJNdCw1BAWZIHOuI5CPEgA5CSJdZT3ohsTyI2UOCXnfk/94xDxROAcX/X uA6nCIi6uctdmLzZlofmRH7Ea418gnRi3tM3wwcVBRSdC/7YFICdPwphhRzqHB6v/zp1SS br3nRUUyr47BOTCqUtM51kFcMOqF9ZeBYQxjSlXH7BqZh15vsa6Uo+gK5CAttJqnWW+AFC rRe0/XB/xtXjF1sP1p5Q/YXWLBYv4KsrZflSIQ/5zz95el2j1Emm7VQuW6xtxYx5lU3cSO CPnAQy34QIzPaasuPdOlpE6wwxJY4eohL0wPmaZh86nyIML/OIL5VLV7UhA4TQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2xcE-0002F1-UP; Tue, 14 Nov 2023 12:54:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2xcC-0002Ei-6D for guix-patches@gnu.org; Tue, 14 Nov 2023 12:54:20 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2xcB-0007eU-Ub for guix-patches@gnu.org; Tue, 14 Nov 2023 12:54:19 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2xcs-0003KP-5P for guix-patches@gnu.org; Tue, 14 Nov 2023 12:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66801] ['PATCH v2' 01/14] build-system: Add mix-build-system. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Nov 2023 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= , 66801@debbugs.gnu.org Received: via spool by 66801-submit@debbugs.gnu.org id=B66801.169998445512731 (code B ref 66801); Tue, 14 Nov 2023 17:55:02 +0000 Received: (at 66801) by debbugs.gnu.org; 14 Nov 2023 17:54:15 +0000 Received: from localhost ([127.0.0.1]:34143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2xc6-0003JH-TH for submit@debbugs.gnu.org; Tue, 14 Nov 2023 12:54:15 -0500 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:50508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2xc5-0003J3-6H for 66801@debbugs.gnu.org; Tue, 14 Nov 2023 12:54:13 -0500 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-5435336ab0bso9213302a12.1 for <66801@debbugs.gnu.org>; Tue, 14 Nov 2023 09:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699984405; x=1700589205; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GITUEuvGJS7vJ9BpurNBLvcJSIRM/h+hHyB7xN8moj4=; b=R1aK92qobO/I5QqHU70R/hwdb+5ocCm546Nvuh9E5RxiBcmgjjRJtOa56FC9B6dBP/ wvfvfEA4XPhtu6GjdLDB/nZuTZlIc84JKK2qh7BAI380UbmAbWaBZd5WDP4F+v4OfxJ7 BSOCLCN0n9/pLhRbshjP2GI9PaFtZF1MZmTC0Xn4pqkA8xXJqJEPQVBDAHazkz0/10oQ E1atTAu5b2RpG0Rb53rkFnH9YH8T6KMXjX9x+S3tXpdYxHgmtEEHDAmjT/IxT7ayFegN k9EzhMbe5/ZgVmYfX7ubwwmn2Q+2cvGBa3SMziA0E8D6fCnhHLhRtg6RAqCaz51a43zd ChLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699984405; x=1700589205; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GITUEuvGJS7vJ9BpurNBLvcJSIRM/h+hHyB7xN8moj4=; b=fZFXNOwG0mrzGPwaszDItQ7p91BStU8DmdDCrN8AqLkIyIoc5i3ByywRq8rF/fdYYV JEyZ9kLjA99Qkdk+v48umvwoQXSlZa8fYcnU1oCP8dlWND/AKjTSL/LSBwq1JAYBIbVl MqR7cxME3SQMYTLr+AFImWnUTuaR4bkOmkdVqNgfTJVgGOsukcrKs6EMIQrZ+Af2PoG2 gRdAHD2Gx/xpVSPW8DHJQEM0K7fjkSTbwe9GYS9gGksxF2J2cn7lFZXSiR2m4LS1pVev x6eVFbZjFGQYdM8PKy37YQFM6GTDrMBV57KyBMg3pl9cyo1RFqG9880Lfj7tkGB/J/IK wE3w== X-Gm-Message-State: AOJu0Yw1zLvjg5ZfQ2q/nhe81NoNjKxMU2+6YSsXzYa/t5H9kI3jklRM VlemMk7lrVR0jXBMVqZXMEs= X-Google-Smtp-Source: AGHT+IGlwSH8WwUJCmjqvAPUlw6pOIzTosQg04DokIaEOXJDBeHtWRr28xgrFRE8MzWlV+dsQPIHWQ== X-Received: by 2002:a17:906:34cc:b0:9e0:2319:16f2 with SMTP id h12-20020a17090634cc00b009e0231916f2mr7672000ejb.43.1699984404812; Tue, 14 Nov 2023 09:53:24 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id y10-20020a1709064b0a00b009dd7bc622fbsm5845954eju.113.2023.11.14.09.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 09:53:23 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 14 Nov 2023 18:53:22 +0100 In-Reply-To: References: <26ef9c0f4bf2ff942ba2b42e1fadeb6174bbaa6a.1699906775.git.phfrohring@deeplinks.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.91 X-Spam-Score: 2.91 X-Migadu-Queue-Id: 4794D17A14 X-Migadu-Scanner: mx10.migadu.com X-TUID: 1HFzV19v5szR Am Dienstag, dem 14.11.2023 um 11:37 +0100 schrieb Pierre-Henry Fr=C3=B6hring: > > > +(define-module (guix build-system mix) > > > + =C2=A0#:use-module (gnu packages base) > > > + =C2=A0#:use-module (gnu packages elixir) > > > + =C2=A0#:use-module (gnu packages elixir-xyz) > > > + =C2=A0#:use-module (gnu packages erlang) > > You probably want to resolve those imports rather than use-modules > > them. >=20 > You mean something like this? > #+begin_src scheme > (define-module (guix build-system mix) > =C2=A0 #:use-module ((gnu packages base) #:select (glibc make-glibc-utf8- > locales)) > =C2=A0 #:use-module ((gnu packages elixir) #:select (elixir elixir-hex)) > =C2=A0 #:use-module ((gnu packages erlang) #:select (rebar3)) > #+end_src >=20 > I have moved `elixir-hex' to elixir.scm to avoid a circular > dependency. No. Look at all the other build systems. None of them use submodules of (gnu packages), for a good reason. > > > +(define (input=3D? input1 input2) > > > + =C2=A0"Tell whether inputs INPUT1 and INPUT2 are equal." > > > + =C2=A0(define pkg1 (match input1 ((_ pkg) pkg))) > > > + =C2=A0(define pkg2 (match input2 ((_ pkg) pkg))) > > > + =C2=A0(string=3D? (package-name pkg1) (package-name pkg2))) > > Again, checking for label equivalence is a bad idea. >=20 > OK, after reading a bit more about Guile, I understand that `equal?' > is what should be used here, right? The intent is to remove > duplicated inputs in the code below: >=20 > #+begin_src scheme > (define all-propagated-inputs > =C2=A0 =C2=A0 ((compose > =C2=A0 =C2=A0 =C2=A0 (cut delete-duplicates <> equal?) ;<-- Here > =C2=A0 =C2=A0 =C2=A0 (cut filter erlang-or-elixir-input? <>) > =C2=A0 =C2=A0 =C2=A0 (cut append-map package-transitive-propagated-inputs= <>) > =C2=A0 =C2=A0 =C2=A0 (cut map cadr <>)) > =C2=A0 =C2=A0 =C2=A0(append inputs native-inputs))) > #+end_src Yep, that would work. Note that delete-duplicates is O(n^2), though.=20 We have a little bit of code where it's done in (I assume) O(n*log(n)) with vhashes. >=20 > > > +(define (elixir-input? X.Y input) > > > + =C2=A0"Determines if the given INPUT is an Elixir input." > > > + =C2=A0(match input > > > + =C2=A0 =C2=A0((label . path) > > > + =C2=A0 =C2=A0 ;; XXX: The second condition may be enough. > > > + =C2=A0 =C2=A0 (and (elixir-name? label) > > > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(directory-exists? (path->elixir-= lib path X.Y)))))) > > Ahem, search-path-as-list. > > Also, leaking the version is kinda bad, API-wise. >=20 > Does this mean that build artifacts should be installed under > `$out/lib/elixir/$libname` instead of `$out/lib/elixir/X.Y/$libname`? Not necessarily, but you want a different way of building $out/lib/elixir/X.Y/ that doesn't leak through the function signature. Btw. I think that you're resolving transitive inputs twice; once on the build system code and once by fattening the outputs. You probably only need either of those, not both. Cheers