From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YPxPHIzskWMdrQAAbAwnHQ (envelope-from ) for ; Thu, 08 Dec 2022 14:54:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EP5DHIzskWPQPwEA9RJhRA (envelope-from ) for ; Thu, 08 Dec 2022 14:54:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 248FB8F70 for ; Thu, 8 Dec 2022 14:54:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3HLh-0002YK-96; Thu, 08 Dec 2022 08:54:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3HLf-0002Y8-9K for guix-patches@gnu.org; Thu, 08 Dec 2022 08:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3HLf-0004vC-1P for guix-patches@gnu.org; Thu, 08 Dec 2022 08:54:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3HLe-0003DD-J5 for guix-patches@gnu.org; Thu, 08 Dec 2022 08:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Dec 2022 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines , 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167050760212340 (code B ref 59513); Thu, 08 Dec 2022 13:54:02 +0000 Received: (at 59513) by debbugs.gnu.org; 8 Dec 2022 13:53:22 +0000 Received: from localhost ([127.0.0.1]:56907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3HL0-0003Cy-4O for submit@debbugs.gnu.org; Thu, 08 Dec 2022 08:53:22 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:42524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3HKx-0003Cs-Pq for 59513@debbugs.gnu.org; Thu, 08 Dec 2022 08:53:20 -0500 Received: by mail-ej1-f68.google.com with SMTP id n21so4069221ejb.9 for <59513@debbugs.gnu.org>; Thu, 08 Dec 2022 05:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Gz+Py6+GwKDjr8m8JPbQOzIjV+uhuFCcJ1uxGROPivo=; b=VtRKp8ahTPY8w5KfQ82FoCixhOVZcsAowoX0Us6MGpYWwmx7gosV39ARA3PenbskqW Yr8IgouYhMiuoj2TU3MIurclpSSOC+pLMfl2Oecf8SgY1jx2hcny60L8ASEqK3zozqkD A4wBjFdMfxzu0+iE02YGad5wjG43Hq62TnR2MIiUkF71G+n6X1tnBv/oRN70NF5whLCw kpTiC+ENCvMztg8fPU2KgJHL7+s9qSgvcgI9ED7AT1iwIvTPCIa9W9P7WhX1BnGcu5II dm3BYO/dDjS2cIACpiLoZwTk3r2gYJ7BSVTzIc5KdCP3rl9ftiQhldC3Sp6CHi70eSk7 hgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gz+Py6+GwKDjr8m8JPbQOzIjV+uhuFCcJ1uxGROPivo=; b=nXyeAlckQJxxSm/vH5NstmExBXWOK18+t/WxC843qLA9zupc3rnyG3iMluSWCbjqQJ O4fSeYXywmEEs4cYP/tY8st/DKjUyZO2XGZDTrnL+cc/SXB4lJ3f7Lkdp/YWBUHl6SIt mCeu+q3Imn2zFy1mcTuSVuoqDO0HvQotj+cOGG2157yRBHuRIF2sY09N/ei+fKDZXGX2 sCAMv7RWScsp7sv7huuetaK00gx8qdlpPvVQgIfVTNNSrdbUbodIKIcwkUChkvhjh2/f P/NxqttckPZW4gMDbEiAK6Ewc3uydEqxD2oHS5zacs4pfwexwC30DccHZLhqVeeFe1Et H0VQ== X-Gm-Message-State: ANoB5pnCxXdzO589twYtReX7IytpQB8nQnPNJ5ATgxf9lDNB8qR58/Ub Ms/WX5J2dCYiT/Oh/WQBSsk= X-Google-Smtp-Source: AA0mqf5SFzJ8Wkxh43CpxZRI7y1cYYMY9cKHruoLUNcVP4Urz1mk5/yV4Z4XNAviyyENQ8TFpjxGAw== X-Received: by 2002:a17:906:b142:b0:7c1:b65:8d0f with SMTP id bt2-20020a170906b14200b007c10b658d0fmr8451385ejb.445.1670507593734; Thu, 08 Dec 2022 05:53:13 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g25-20020a056402115900b0046cbcc86bdesm3423277edw.7.2022.12.08.05.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 05:53:13 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Thu, 08 Dec 2022 14:53:12 +0100 In-Reply-To: <20221208112051.5019-1-mail@cbaines.net> References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670507660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Gz+Py6+GwKDjr8m8JPbQOzIjV+uhuFCcJ1uxGROPivo=; b=RxhN3Kj+T2AOV5/kBaiJIYzDxGXE+PanJGGmtIVSCNk2mPbZONyWNzRpAsXUdshvRRzgTh +y1smrYj9t2IcO+cGtgfo2/UOJ6BFtVYIUdWTbQKeeFS6FRTQA7kjFxIZnOQLKrVTJNbal V2ZFYsy7ZmxwpHhKc04mZqT+uiUv1Oj55d3Aqu7eiOvZ5jKpKzP3YU+w3lUngDfngZAHfF VyIJaOHNbvFerQwGaTqVIjYmi0yvX7FzOclQYAuz14oUggNmVsXyu34/KcWwduXUh5VFMc xSMtlQgSxOfrorMcaOZC/Dx3NTLf5jPV599RMl8hhAwPFb015g6FQctPnpdYSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670507660; a=rsa-sha256; cv=none; b=S8F1nn6XRM+fdsho5c8aHqKn+K/N18gfxZcOLrFZFq5PbOfxOOHGFv/V0z02/M5BDt2j3X QQF0iBx20yNX0SIXlJkZ+/mwvB5z3L74FdhlO/q1r0mPYCzeXePoJyoj/XTssNZecCfN8Z Rb0ac/EPp6m+OJSff5XanX/BjUM7iOWdpnMQDwr2rC6QdPluKo6Xukc/BG+26Um7YMDdN8 qhM3Mb1PAH0aJu0xFKQUwmK7btBImWVgn2theyoEiKn24owj/g7FpQLfXUkVykjggdo5C3 MQu8DjiSf3dv0F/LuWqaGbNDI6Y8a0vNrH03SQCiU/iqFQf+t2OzdjWVgUtk1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VtRKp8ah; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VtRKp8ah; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 248FB8F70 X-Spam-Score: 6.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: hDqnwQYy0vRR Am Donnerstag, dem 08.12.2022 um 11:20 +0000 schrieb Christopher Baines: > Add more examples of when it can be appropriate to push changes > without > review, as I think this can be appropriate in the case of trivial > changes (as > mentioned before), but also non-trivial fixes. >=20 > No longer suggest pushing simple new packages or package upgrades > (that don't cause lots of rebuilds) without sending to guix-patches. > Now there's some automation for testing changes sent to guix-patches, > sending changes there before pushing can mean that more rigerious rigorous > testing takes place and help speed up substitutes becoming available. > This is true, even if no human review takes place. >=20 > Only suggest waiting one week for review for simpler changes, wait > two weeks > for more significant changes. >=20 > Also, reorder some of the information in this section so it's grouped > together > better. >=20 > * doc/contributing.texi (Commit Policy): Tweak. > --- > =C2=A0doc/contributing.texi | 41 ++++++++++++++++++----------------------= - > =C2=A01 file changed, 18 insertions(+), 23 deletions(-) >=20 > diff --git a/doc/contributing.texi b/doc/contributing.texi > index 6a8ffd6524..d2e7abba98 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -1824,23 +1824,26 @@ It additionally calls @code{make check- > channel-news} to be sure > =C2=A0 > =C2=A0@subsection Commit Policy > =C2=A0 > -If you get commit access, please make sure to follow > -the policy below (discussions of the policy can take place on > +If you get commit access, please make sure to follow the policy > below > +(discussions of the policy can take place on > =C2=A0@email{guix-devel@@gnu.org}). > =C2=A0 > -Non-trivial patches should always be posted to > -@email{guix-patches@@gnu.org} (trivial patches include fixing typos, > -etc.).=C2=A0 This mailing list fills the patch-tracking database > -(@pxref{Tracking Bugs and Patches}). > - > -For patches that just add a new package, and a simple one, it's OK > to > -commit, if you're confident (which means you successfully built it > in a > -chroot setup, and have done a reasonable copyright and license > -auditing).=C2=A0 Likewise for package upgrades, except upgrades that > trigger > -a lot of rebuilds (for example, upgrading GnuTLS or GLib).=C2=A0 We have > a > -mailing list for commit notifications (@email{guix- > commits@@gnu.org}), > -so people can notice.=C2=A0 Before pushing your changes, make sure to ru= n > -@code{git pull --rebase}. > +Changes should be posted to @email{guix-patches@@gnu.org}.=C2=A0 This > mailing > +list fills the patch-tracking database (@pxref{Tracking Bugs and > +Patches}).=C2=A0 It also allows patches to be picked up and tested by th= e > +quality assurance tooling; the result of that testing eventually > shows > +up on the dashboard at > +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where > +@var{number} is the number assigned by the issue tracker.=C2=A0 Leave > time > +for a review, without committing anything (@pxref{Submitting > Patches}). > +If you didn=E2=80=99t receive any reply after one week (two weeks for mo= re > +significant changes), and if you're confident, it's OK to commit. I would reword that so=C2=A0 (not significant =E2=88=A7 confident =E2=88=A7 qa_green) =E2=86=92 good a= fter 1 week whereas (not significant =E2=88=A7 confident =E2=88=A7 qa_unknown) =E2=86=92 good= after 2 weeks and significant changes should anyway take 2 weeks. Cheers