From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wXbkAnpqVGA0aQAA0tVLHw (envelope-from ) for ; Fri, 19 Mar 2021 09:10:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EH+5OXlqVGDXUQAAbx9fmQ (envelope-from ) for ; Fri, 19 Mar 2021 09:10:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A0E2160BF for ; Fri, 19 Mar 2021 10:10:17 +0100 (CET) Received: from localhost ([::1]:34588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNB94-0003hZ-PJ for larch@yhetil.org; Fri, 19 Mar 2021 05:10:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNB8s-0003gz-Du for guix-patches@gnu.org; Fri, 19 Mar 2021 05:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNB8s-0004G8-6V for guix-patches@gnu.org; Fri, 19 Mar 2021 05:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNB8r-0002hp-TV for guix-patches@gnu.org; Fri, 19 Mar 2021 05:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47187] [PATCH] gnu: Add c-lightning. Resent-From: =?UTF-8?Q?L=C3=A9o?= Le Bouter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Mar 2021 09:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ZmnSCPxj Cc: "47187@debbugs.gnu.org" <47187@debbugs.gnu.org> Received: via spool by 47187-submit@debbugs.gnu.org id=B47187.161614499110375 (code B ref 47187); Fri, 19 Mar 2021 09:10:01 +0000 Received: (at 47187) by debbugs.gnu.org; 19 Mar 2021 09:09:51 +0000 Received: from localhost ([127.0.0.1]:48804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNB8g-0002hH-Qr for submit@debbugs.gnu.org; Fri, 19 Mar 2021 05:09:51 -0400 Received: from mail.zaclys.net ([178.33.93.72]:44567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNB8f-0002h3-3y for 47187@debbugs.gnu.org; Fri, 19 Mar 2021 05:09:50 -0400 Received: from guix-xps.local (lsl43-1_migr-78-195-19-20.fbx.proxad.net [78.195.19.20] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12J99g2C015709 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 19 Mar 2021 10:09:42 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12J99g2C015709 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1616144982; bh=21UpkHw09Cgw8ty0inCCFHERmfRqbd8icEmU3bZoff4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=iuBt2SZjw9UMRU/IhC3hirQGYWUAzOaYvVa7eccly6v9KEw3a2XsX5iM3k9C2MQvZ 7H7uO9khcdVdkcM5YDYgsAc8alqJhXfaTf4tslv6zKyQVkQyL4Mb2+qDaYJ/y6hPbd WsPH8sRbGZB8dbbti9pdeNehHqOuM9oCPxPplmTY= Message-ID: Date: Fri, 19 Mar 2021 10:09:38 +0100 In-Reply-To: References: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> <8f7d4c04d96fdf8cf1239c476c4c869f92446ada.camel@zaclys.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-v/b35G6QPGcKktIeHPzr" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?L=C3=A9o?= Le Bouter X-ACL-Warn: , =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches From: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616145017; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=21UpkHw09Cgw8ty0inCCFHERmfRqbd8icEmU3bZoff4=; b=l1REL1MeK2Cy2BiPFdqnSOCuQO+YnCSiY8zsCXabzDxAvWiTG+kHaRhIgvFrc6cPd09UTZ GbAtw5yn6MxsadzRKpgfz9n7NFdP5TQoe1GBqEjFec7NcbBqif2SYYeBXqzpbY1+fvle2C ThmnNGEoGCrfTLeABhN9n9N1EkNkGeMCpSoPqcIMe4Dz/u6mlX56Vu4JvMNPfvOOl5Mqbx UF3h6IPyABq8lYo2pgXUyVLfZ9n/433rS7CtjsB6tflDKG6PIeDDMfQZOlyGBlIsCPq9/4 Nzh9V3iGxeWo2U3eJqQtmIeDaObN8R+JoGhKz/aLHZpSuxt//OzdNyWvgPURtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616145017; a=rsa-sha256; cv=none; b=cZCXrd7+uCvMh53ZvHbonuXvKLJlvcncXZSeKKEdNLGzmBT2gjNqDi+Ke5Wpo0LE51ZD4Q 6vR7wqrkkp1evxc6YWcdySfXcsL0zqXfH3ygxGFBHnXy7mozkOmLs5/U8mKZ4ARTtWdSid eXIeuW46IgDmxVFf8wP31AceDKDa9KGlJyWh+W12fivYgTXldx63O1Uj9Fle6pq4G44c+D Uykt7cCovPtDwdrl0DTISen/Q4c9Ipaprd0T5Evlndc3efiGsGPTcXmf1QzAwvYqnY1ZM1 IfhWjDZcVy+jmV9ihN1Drp7gSHDtMs40w8x/827LWVJP1yJ1hSr33/weut1HOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=iuBt2SZj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=iuBt2SZj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3A0E2160BF X-Spam-Score: -5.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: MipxeVM5uDna --=-v/b35G6QPGcKktIeHPzr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2021-03-18 at 16:54 +0000, ZmnSCPxj wrote: > That would not be simple I think, but let me see what can be done. > For one, it would be fairly difficult to test it outside of a patched > Guix, as the packages are not usually available in most distros > (which is why we ship the source build with them); e.g. we do not > know how to actually find the "system" libbacktrace as no existing > system I know of actually ships the libbacktrace we use (Debian ships > a libbacktrace for android development, and is not the same package > as what we use). > Of the external packages we use, only libsodium is available on > Debian (and older Debian/Ubuntu, as mentioned, have an older version > that does not have a functionality we require, which is why it is > included in our source build as well), so that is the only external > we have that we can plausibly say "we can use the system version", > because all the others are not available on most systems. We can package every of those in GNU Guix, there's not as much bureaucracy as Debian when it comes to inclusion, as long as Free Software and freedom-non-controversial. The "system" thing is just so handy for us build-system wise we can just provide it as an input and it will find things automatically, I don't say that "system" lookup should imply to take any available library in general, in the context of GNU Guix we can give it a particular version and stick to it, unlike Debian's who can't have or with great difficulty, multiple versions of the same library installed. > Also --- we would be somewhat wary of taking the "system" > `libsecp256k1`, as this is very consensus-critical, and we know that > our program works with a very specific version, but cannot assure > this to be true if the "system" `libsecp256k1` is not the exact > version. > (Note that we cannot take the `libsecp256k1` from `bitcoin-core` > because (1) the `bitcoin-core` package uses a vendored > `libsecp256k1`, the separate Guix `libsecp256k1` is actually only > used by `electrum` and related projects and (2) the interface > `bitcoin-core` uses may be different from the interface we use, it > would require review before we would be able to assure that the > interfaces they use are exactly the same; this would be mitigated by > running the full test suite as it also tests consensus-criticality.) > Is there an easy way to ensure that any `libsecp256k1` that gets fed > into the `c-lightning` build as an `inputs` is of a specific `git` > commit? Yes we can package yet another variant like Bitcoin Core at a specific commit for c-lightning. > Hmm do you mean something like: >=20 > (origin > ; whatever... > (snippet > '(begin > (delete-file-recursively "external/gheap") > (delete-file-recursively "external/jsmn") > (delete-file-recursively "external/libbacktrace") > (delete-file-recursively "external/libsodium") > (delete-file-recursively "external/libwally-core")))) >=20 > ? Yes! > How do you mix in a build system? > Would `python-pyqt` be a good example of such "mix in"? Maybe? I'm no expert here. > Regards, > ZmnSCPxj FYI, I'm not as available for GNU Guix as I'd like, I am looking at the Python deps, just it will take me some time to actually do it (not at home now). I see python-mako is already packaged, python-wallycore I am packaging it, python-mrkd also looking. Also if we want to provide the Python bindings (?) to c-lightning we also have the option of creating a separate package based on the same sources but with different build-system (like python-build-system), and also it can have c-lightning as an input.=20 L=C3=A9o --=-v/b35G6QPGcKktIeHPzr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBUalIACgkQRaix6GvN EKZmrg//UNk1WwUwLeZlabzdnVwe2athHoxiuI6mN6eeiAXJL+QEmNTvtdPYvvEG jhIH9oPsUEyE+sSOe2tYLUW5cms0duyf5vsCmgvmCU++WKfeGICntaCstb6GTvMk VYTyBH2VoCL49bbRNFHXN68iFgz8NFxZmm5DuT3Cj4eTNub20knqXe29947kqvhX WxMYHcSegjncIAnDbG7VKba+sJeu44uRsgQDVpB09EhPABZIkyN3r7/Zjm8CYLc1 HxP+UKI63a3p6MYccD6wHmdaxoav//vinOw7llggqIZiBHw7FD2HsOt84ZT4ViSD 6c+10XB1WGj9VzBa1oTuGDGjjSCwBjhALn137D9MqimT55uXTJx/hbXirGmQkehj uBxq/+jcpERcwlPaZfOJNrdP08MgWmnkC/uY2LZ8dBOEPwhcX0OX3U+LXTsOJ6VA Q3d8qIUJu+Udy66DhL2Z4/HWVhVtvXp8XAVGf6kKNuU5BtZF6grZvRt3ImTUJxW+ D9qRm8TqM2kBctDnAyXQ8umoCZHwdVPdjnN2rKNg/ElEG/Y4Pm52HD3uJx1Q65V4 xynaEBSrW7DSY4nlpQ2HIhwoG9bQIzY5fDIBG4kA4MmZ2ctxJYU1eegM3slxkzBM iYfwVTgkQ1S5JtDYf1WSyGqfmYsZhB/t9yH+nt8I+6iod6qUASQ= =hSvx -----END PGP SIGNATURE----- --=-v/b35G6QPGcKktIeHPzr--