From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
Subject: Re: cmake-build-system: modify-phases picks up wrong %standard-phases
Date: Thu, 23 Jan 2020 14:55:39 +0100
Message-ID: <f4d32119-f369-a4d1-8f8c-aa500cf6010a@crazy-compilers.com>
References: <284cb228-6878-b078-957d-e6bd7d62d66b@crazy-compilers.com>
 <87a76iij06.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:54068)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <h.goebel@crazy-compilers.com>) id 1iucxY-0006Dr-7i
 for guix-devel@gnu.org; Thu, 23 Jan 2020 08:55:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <h.goebel@crazy-compilers.com>) id 1iucxX-0004A0-2K
 for guix-devel@gnu.org; Thu, 23 Jan 2020 08:55:48 -0500
In-Reply-To: <87a76iij06.fsf@gnu.org>
Content-Language: en-US
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>

Hi Ludo,

thanks for the explanation.
> If you do:
>
>   #:modules ,%cmake-build-system-modules
>
> then you=E2=80=99re also putting (guix build gnu-build-system) in scope=
, hence
> the collision for the =E2=80=98%standard-phases=E2=80=99 binding.

I wonder whether this could this be avoided by changing the order:

=C2=A0 (define %cmake-build-system-modules
=C2=A0=C2=A0=C2=A0 `((guix build cmake-build-system)
=C2=A0=C2=A0 =C2=A0=C2=A0 ,@%gnu-build-system-modules))

into

=C2=A0 (define %cmake-build-system-modules
=C2=A0=C2=A0=C2=A0 `(,@%gnu-build-system-modules
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (guix build cmake-build-system)))

Or whether we should change `%standard-phases` int
`%camek-standard-phases` (and reps. for the other build-systems)

--=20
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |