From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GFKENDB8eWJ1zQAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 22:40:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +BSWNDB8eWItcgEA9RJhRA (envelope-from ) for ; Mon, 09 May 2022 22:40:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85BC232587 for ; Mon, 9 May 2022 22:40:16 +0200 (CEST) Received: from localhost ([::1]:44896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noAAx-0001mt-K7 for larch@yhetil.org; Mon, 09 May 2022 16:40:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noAAk-0001mj-PZ for guix-patches@gnu.org; Mon, 09 May 2022 16:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1noAAk-0002Nj-Gr for guix-patches@gnu.org; Mon, 09 May 2022 16:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1noAAk-0007hI-Dp for guix-patches@gnu.org; Mon, 09 May 2022 16:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55242] [PATCH 10/10] guix: import: go: Better handling of /v2 in the module path. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55242 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai , 55242@debbugs.gnu.org Received: via spool by 55242-submit@debbugs.gnu.org id=B55242.165212878929561 (code B ref 55242); Mon, 09 May 2022 20:40:02 +0000 Received: (at 55242) by debbugs.gnu.org; 9 May 2022 20:39:49 +0000 Received: from localhost ([127.0.0.1]:59570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noAAW-0007gi-Lv for submit@debbugs.gnu.org; Mon, 09 May 2022 16:39:48 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:58934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noAAU-0007gW-1h for 55242@debbugs.gnu.org; Mon, 09 May 2022 16:39:46 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id Ukfj2700A4UW6Th01kfjfa; Mon, 09 May 2022 22:39:44 +0200 Message-ID: From: Maxime Devos Date: Mon, 09 May 2022 22:39:38 +0200 In-Reply-To: <20220503114301.9524-10-attila@lendvai.name> References: <20220503114301.9524-2-attila@lendvai.name> <20220503114301.9524-10-attila@lendvai.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-kG+Nad+LzOuQ6UhNqLJ4" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652128784; bh=t3botso+O2SuRjbJZSCYVd6ICjQogyr6ZlznbK5zm1E=; h=Subject:From:To:Date:In-Reply-To:References; b=Nc7mIV0bEDi4kC1F984fzXB88WMTjEImN4F2GjX84sB2W9DWkYMCKQ2nq0szTQSTG BrnHL+JsCUx0QsWakN0bUL50I1k2Za8pvWz1HrNFU9RHtSV91XA9U5nDe62FXpQs+i 0jbWp8jrIJLB1OJJxMnNAPQ6ndEKuIoX+vIEWzYjzoPImLOJkYLzWGBYLu5Qc8xvi6 wVy9bSFwDiAFxEToybCx7gbvnQFUZb3+PqHZpjoEJ2NZ07+GqEV9mUUZGLSxN1g+aa qb1eP2UbmoUWyP5pX+USXCPjoJo5wXObEqcQmk4ZGEe1ysPZtFDgo4NRK6VhSITN75 LvLV7SxxeSNOA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652128816; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=t3botso+O2SuRjbJZSCYVd6ICjQogyr6ZlznbK5zm1E=; b=D2PTHf6QHlm2d5Hns21Vyop7Ps1YlYVIbrRxc/2MJuW0UUZVGmH38ZngkPflNUc2ar3OBS P8wKAt7yQMU8yki6rBm/XHT9pSLurY/ULF31JF68kXcAbTMlDEnA+APt2SVyaAk3eCZfhJ YQ5p7TN72S2ejukyFG964rJZw6Wz1Hmoy7eFmcSlzohTLStgmqGa/C3lNZG7g3L/6C2A1D /0YgtLrshx8hogYfbBdt7U190EEUDyWpbl+Cm72pQ5m6PFr0vIfTztGIZb8oU7uqIWHm/g 2VrntTJup3xtgM4/PFnpwKiqRmm6o8Lq9v5PG47QTx0o40iBwnV6wdsaPChUKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652128816; a=rsa-sha256; cv=none; b=qHlx7Xpqf/perxUUCxPp88q+PzokdQ7ZMed225nRdJZX5sh/5vGApt48e5QLNfntquyZnT gpqr1nnsbmI1oZVdL/pFPMC0eJZ1sltby9PZqWvZynJZdozzQP/evpu1Nw9YY7G0TB2h26 Y7db5N+9KJp9HOgIwTibhXOoIINxCFurWDheQslvuRxhLK+g+pfTpYIu6Vp6GcSy9ulNlb q88Jcd3xDafWqg5xq1VjvTR395LWNAdxHdzc/KWT0+6LAGkAgZH+C++a06aXc4qApSfN2j ChefOOdRTCWq2wfksvcbsB9igkL+KqTjwkp+xQkll98SzW+5KOUvZIhcSZT+fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Nc7mIV0b; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Nc7mIV0b; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 85BC232587 X-Spam-Score: 3.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: U23QrX7mHmZC --=-kG+Nad+LzOuQ6UhNqLJ4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attila Lendvai schreef op di 03-05-2022 om 13:43 [+0200]: > +(define *module-path->import-path* In (Guile) Scheme (at least as used in the Scheme code I've seen), *earmuffs* are typically used for mutable variables, not for global constants. Though guix/self.scm uses *system-modules* for not-really- constant-but-not-mutated lexical variables so maybe ... FWIW, I would write (define %module-path->import-path ...) here, not that it really matters. > +=C2=A0 ;; There's no other way to derive this information, at least that= I know of. > +=C2=A0 '(("github.com/google/go-cmp" . "github.com/google/go-cmp/cmp") > +=C2=A0=C2=A0=C2=A0 ("github.com/sergi/go-diff" . "github.com/sergi/go-di= ff/diffmatchpatch") > +=C2=A0=C2=A0=C2=A0 ("github.com/davecgh/go-spew" . "github.com/davecgh/g= o-spew/spew") > +=C2=A0=C2=A0=C2=A0 ("github.com/beorn7/perks" . "github.com/beorn7/perks= /quantile") > +=C2=A0=C2=A0=C2=A0 ("github.com/census-instrumentation/opencensus-proto"= . > +=C2=A0=C2=A0=C2=A0=C2=A0 "github.com/census-instrumentation/opencensus-p= roto/gen-go"))) About the =E2=80=98is this controversional=E2=80=99 bit: these kind of mapp= ings and sets have precedent, see e.g. 'known-vcs' in (guix import cran), %builtin-mods in (guix import minetest), default-r-packages in (guix import cran). Greetings, Maxime. --=-kG+Nad+LzOuQ6UhNqLJ4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnl8ChccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jjvAP9QIc+zxtNflCWJ016k5MLpkFG2 kADgmIrdtMFXaX9wEwD/apAf+KB+UWzgCRtepf7n2sCmXnaJwG0HTDyPZ2AW+wk= =j4Jt -----END PGP SIGNATURE----- --=-kG+Nad+LzOuQ6UhNqLJ4--