From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8D1jBWM9N2GB/QAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 12:22:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CHkyAWM9N2FiMQAA1q6Kng (envelope-from ) for ; Tue, 07 Sep 2021 10:22:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A2F76C0D for ; Tue, 7 Sep 2021 12:22:26 +0200 (CEST) Received: from localhost ([::1]:54046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNYFF-0004TN-Fh for larch@yhetil.org; Tue, 07 Sep 2021 06:22:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNYEu-0003ke-4G for guix-patches@gnu.org; Tue, 07 Sep 2021 06:22:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNYEs-0002Xj-GQ for guix-patches@gnu.org; Tue, 07 Sep 2021 06:22:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNYEs-0004fX-6m for guix-patches@gnu.org; Tue, 07 Sep 2021 06:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50425] [PATCH] gnu: Add minetest-advtrains. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50425 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vivien Kraus , 50425@debbugs.gnu.org Received: via spool by 50425-submit@debbugs.gnu.org id=B50425.163101007217875 (code B ref 50425); Tue, 07 Sep 2021 10:22:02 +0000 Received: (at 50425) by debbugs.gnu.org; 7 Sep 2021 10:21:12 +0000 Received: from localhost ([127.0.0.1]:55455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNYE3-0004eF-Nj for submit@debbugs.gnu.org; Tue, 07 Sep 2021 06:21:11 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:43776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNYE0-0004e3-UR for 50425@debbugs.gnu.org; Tue, 07 Sep 2021 06:21:10 -0400 Received: from butterfly.local ([188.188.3.227]) by xavier.telenet-ops.be with bizsmtp id qyM22500c4tskic01yM5ZN; Tue, 07 Sep 2021 12:21:07 +0200 Message-ID: From: Maxime Devos Date: Tue, 07 Sep 2021 12:20:58 +0200 In-Reply-To: References: <87a6kqm6f3.fsf@planete-kraus.eu> <031b52f03cac2218f9250882e5b8d3fe56cc7f49.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-mkq9wkW/Sy38ABT/5q7J" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1631010067; bh=BpIZqCpjc1xB90yUDMEnaWZ2G4p0Sgm4JJuo3YlOF2g=; h=Subject:From:To:Date:In-Reply-To:References; b=mnlC0yQJFIr5GlAjdQqIQe9wrE37KwmMVZ+uXnCmv9fSuJOiEcwS4sLULcdPmI4aq RWYuAytPtGgiQgwPpRT4LE28IfdlYhFoL9PPHvrGrXjIDKdOHWKCrmygXPOyNVVLOb /fBSrI6ksVIcoo0JRvyveoEpDUIrZ7/sOFbn4lFptKFcNHBbCS5UmIeBfbHHTwMvju cW6YwRNz4avPExa+vbNP6ZmBQ8cwPzjR9A/YPwvEucdfcT4qGNYemrtRyaj4bcbR39 L3wUcTdSYwguIRi+nbwyR53cC8Y2D0xpL5yaUSkQguwCd5D9w4FYLXoZPMXilrobfj db5KfLesuFoIg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631010146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BpIZqCpjc1xB90yUDMEnaWZ2G4p0Sgm4JJuo3YlOF2g=; b=B+pto28JKPXfwYhZEWWO8krGcoNAoCAuWy0fCAj0DSrldL61iwA3SU8JeM+tt2pM81BRlj WPhuKLs6IjOusJtQaQ1J6t2CkGwkXORJXh+rq8xWoovhE1/lXV44DoM54O6ase5mwJVeGd PfF6QCdSTbb0qXoJv8cqFfTpBUvM2gsR2L+yUlrIMA6+ofsE1yEH7xz7NDE2VY5b/glkAk HxcDnRt1OKkxiOzc2BGplAvOCBSreEVTL5fHU6mbw9Pua9bv7Qwu2rlDFHnHSymE/W59E+ lnMfl2WqxN7+Bx6pxyGRKKAEvqRjWCgtZAYiwt82JzuB4LXXNx0VXwnafhWagA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631010146; a=rsa-sha256; cv=none; b=XJetYWK1RpY4X8GXPtNxs49RBeCD6FZj1f1Jpoktft1E6yRFhw+y1klvb77JTxuo5bfVAD qGWcaHyS74MA98Ehc2tTecInh1X8IM3/kh6vnh97eoocwsAMWMY0yZ1NubH3ei5rqpO/Ub u8XBVBr3K08MPUbphRg29OXtdZJ+z/2hRWZeIB7InsuzAD91aEudWJx9OicBjAsRuQxyln MMBb/6x4WhDHOa7r/D6PfoLbvh7Ww9od0nfulCWrtBzdLT23oy9R6CfY35eE2YWEDpb1jw 1hw8qKe6XYsrGduWcBqiiGqu51PQkfv6n1JEtEz52whkCTV+t/j6N2/XQQ9MqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=mnlC0yQJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=mnlC0yQJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8A2F76C0D X-Spam-Score: -1.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: XN5VxLEo2EzC --=-mkq9wkW/Sy38ABT/5q7J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vivien Kraus schreef op ma 06-09-2021 om 13:56 [+0200]: > Hello Maxime, >=20 > Le lundi 06 septembre 2021 =C3=A0 13:17 +0200, Maxime Devos a =C3=A9crit = : > > Did the minetest importer work well for you? > I noticed 3 minor things: > 1. The advtrain dependency on basic-trains was duplicated, I had to > remove one occurence; I can reproduce this with =E2=80=98guix import minetest --recursive orwell/= basic_trains=E2=80=99. Presumably the issue is that advtrains is listed twice in the dependencies on ContentDB, as =E2=80=98advtrains=E2=80=99 and =E2=80=98advtrains_train_t= rack=E2=80=99. I'll send a patch to remove duplicates. > 2. The version number came prefixed with a "v" that I had to remove; The importer uses the =E2=80=98release title=E2=80=99 as version number. A= pparently the release titles for orwell/advtrains include a "v" prefix. I'll send a patch to remove the prefix. > 3. It was not able to get the commit ID and the hash for minetest- > advtrains, I had to fill it in myself (it was set to #f). Presumably > because of the exotic tag name. FWIW, the minetest importer doesn't look at git tag names, it just copies the commit from ContentDB. And in case of advtrains, the commit is not available there, so the importer sets it to #false. . > [...] >=20 > Also, when I run ./etc/indent-code.el gnu/packages/minetest, there are > some re-indentations that happen for othe minetest packages. Thus, I=E2= =80=99m > not sure what indentation and general style I should adopt. Hopefully > this problem will be fixed by guix style :) The indentation from "./etc/indent-code.el" should be good. Feel free to precedede the =E2=80=98gnu: Add minetest-advtrains=E2=80=99 patch with a= patch fixing the indentation. Greetings, Maime. --=-mkq9wkW/Sy38ABT/5q7J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYTc9ChccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mc6AP9PWWXF38dKNjLmkU5p8jfj0lbt cgH/8bVl1QgCCXxcCAD+KcUdUg+A6AgweGaHeK3a/8Msl7QiZNldgbgHWDwHowc= =shVi -----END PGP SIGNATURE----- --=-mkq9wkW/Sy38ABT/5q7J--