From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oE7lIY7oK2FbVAEAgWs5BA (envelope-from ) for ; Sun, 29 Aug 2021 22:05:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mEpzHY7oK2H1OAAAbx9fmQ (envelope-from ) for ; Sun, 29 Aug 2021 20:05:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17B9517783 for ; Sun, 29 Aug 2021 22:05:34 +0200 (CEST) Received: from localhost ([::1]:34524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKR3d-0004xE-3u for larch@yhetil.org; Sun, 29 Aug 2021 16:05:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKR38-0004vL-FT for guix-patches@gnu.org; Sun, 29 Aug 2021 16:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKR38-0006cn-7q for guix-patches@gnu.org; Sun, 29 Aug 2021 16:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKR37-000675-Ou for guix-patches@gnu.org; Sun, 29 Aug 2021 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50054] [PATCH] gnu: Add bgfx Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Aug 2021 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50054 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 50054@debbugs.gnu.org Received: via spool by 50054-submit@debbugs.gnu.org id=B50054.163026745323435 (code B ref 50054); Sun, 29 Aug 2021 20:05:01 +0000 Received: (at 50054) by debbugs.gnu.org; 29 Aug 2021 20:04:13 +0000 Received: from localhost ([127.0.0.1]:57465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKR2L-00065v-0O for submit@debbugs.gnu.org; Sun, 29 Aug 2021 16:04:13 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:36122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKR2I-00065i-Vg for 50054@debbugs.gnu.org; Sun, 29 Aug 2021 16:04:12 -0400 Received: from nijino.local (194-118-34-199.adsl.highway.telekom.at [194.118.34.199]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GyPY32Vqfz1LBCr; Sun, 29 Aug 2021 22:04:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GyPY32Vqfz1LBCr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1630267447; bh=jFmJLwPZ9kofvFf7unXYTo2cHURpjuI+xaBo/JEa6ZY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qHFSrAUWqiRTtEiFsHday2DX9I7Kozx38pY3OpXrLelnPW8rkuLnMYtDxW0kDvpby xfp+RSVG4KfJZUgGFQHAwZ8Z0KMynTLPAI75DPBkHkJ29RpR2bbFJ1K6apo1CFbprY jQKGm7JO4HUF43F4TXnx38g0NnAiBDLAlEJyfRUI= Message-ID: From: Leo Prikler Date: Sun, 29 Aug 2021 22:04:06 +0200 In-Reply-To: References: <06bebf1e2ab2d17f465e0c48c58a82e38a88fe94.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630267534; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jFmJLwPZ9kofvFf7unXYTo2cHURpjuI+xaBo/JEa6ZY=; b=vAqM9df16dMp19GEoS9JQIt9dDJuPFUYd8qS73rOEkbnV39qUBek049WxRb22XGUsCB/AP SWU3Rj5oIcaTVpO/IS7xvmnFuhdsjxIHNE8vTGpObniIuYvbksgP8ygPiFoOk2LOAJGuuC kqk25SH5xb1koDQ5NVjHrVsl/FeTwq1LbBfNzdQTvTCjDcS9lcUFhZ8FJDZesw1/dbdQXT 6anGVoTLkd4zWiTNNu+U/KrmyIyV6QGwNqC1w5yVZECkx4I/dNcsrMCro7ZZLj0yDMq64q gF9wlN24HJIqbFEMTxKsg/psqAz2RANuCpd9aznN6n9RvCRX6NQyTYBfPhm3Pw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630267534; a=rsa-sha256; cv=none; b=JJSqxiPZ+Pj19VkkE7keCpf5pG8NNm2ptFWscLnrmKyh9nOQXiYhf3tHRS0pTz56xaCPOd 60ECBrISyY8qQY33xVKUsDgkiXsr/A5rkAtRNgz0M4ezxl0lgFF0Y22+C1x2R4PpAVOu4T G8NpgckcrCfnVORU8R9Ryfqg9Y4uKR9Vljo0q1CbHnMkvtqw34m0qiC1rRZ0+hLryhz3aN GmTAneYkl6YoyturCLtKXecptLvaEtEYeIwrcHKFxU2pxRZhZdPhpe132VJ6/sxg9m4FWL KuBwOLgvBFf9niJfs5+O2ND/BfJB+rDAS6PP1C4IP9i8TbSMqQYLaYjkXOlT8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=qHFSrAUW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=qHFSrAUW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 17B9517783 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: kR5LeCQfOCCr Hi Am Sonntag, den 29.08.2021, 11:21 -0700 schrieb Andy Tai: > > First things first, this still does a build of everything at once > > rather than one package per repo. Have you looked into the one > > package > > per repo thing and decided that it's not possible or do you simply > > continue with the package as-is because it builds? > > > > Hi, the author of the upstream is very opinionated; this is how how > arranges the things for this package and his documentation on how to > build mentions checking out all three repos and build them together. I wouldn't read too much into that. Just because they put those directories next to each other doesn't mean Guix is forced to do the same. Many people have their shells in /bin/bash. Some use /usr/bin/bash. Neither exists in Guix and we still manage to somehow ship bash. Plus, according to upstream, the CMake structure is literally an alternative build system and there are several versions of it, suggesting that it shouldn't be particularly hard to adapt bgfx to something else. > I can look into his build system setup to try to build each repo > separately but that means I need to maintain custom build inside the > package and normally I don't think distribution package maintainers > want to go into inside the package to setup alternative build > processes separate from upstream--what goes inside the package is > best left to the author. If you maintain essentially separate build > scripts in the original package in terms of cmake or genie, that is > outside the scope of guix and hard to maintain as you need to keep up > with new releases. People have rolled their own Makefiles for decades and Guix has a way of coping with that. You simply need to delete bootstrap and configure from gnu-build-system or replace them with whatever command upstream uses. > > Even if you want to do a merged build, binaries, vendored > > dependencies, > > etc. ought to be removed in the origins, not at build time. I > > suggest > > you use a computed origin to merge the three and remove all those > > things. > > > > Is there a "computed origin" example in existing package receipts in > guix? There are few examples, as computed origins are typically only used with huge pieces of software that need large patches to throw away proprietary blobs. See the linux kernel or chromium. Regards