From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnTTh-0003DJ-U4
	for guix-patches@gnu.org; Thu, 31 Aug 2017 13:42:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnTTe-00028r-R4
	for guix-patches@gnu.org; Thu, 31 Aug 2017 13:42:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57476)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dnTTe-00028i-Nl
	for guix-patches@gnu.org; Thu, 31 Aug 2017 13:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dnTTe-00069S-Cf
	for guix-patches@gnu.org; Thu, 31 Aug 2017 13:42:02 -0400
Subject: [bug#28281] [PATCH] gnu: Add os-prober.
Resent-Message-ID: <handler.28281.B28281.150420130623623@debbugs.gnu.org>
Message-Id: <f421cceb.AEQAPWOEMfwAAAAAAAAAAAPmNSgAAAACwQwAAAAAAAW9WABZqEpX@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 31 Aug 2017 23:11:26 +0530
In-reply-to: <87lglzrhr7.fsf@gnu.org>
References: <ed473f83.AEAAPIjTtawAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZpbtV@mailjet.com>
	<87lglzrhr7.fsf@gnu.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 28281@debbugs.gnu.org


> For clarity, what about (1) using ‘find-files’ instead of ‘ftw’

I started with something like that and switched to `ftw' for slightly
shorter code. But, I guess clarity is more important.

> (2) separating code that builds the list of files from code that calls
> ‘install-file’?

Sure, will do. I'll send an updated patch with both changes
incorporated.

This package is really so messed up. I don't know why they couldn't have
just provided us with a Makefile for installation. Sigh...