From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH] gnu: go: Update to 1.8.1 Date: Mon, 17 Apr 2017 19:55:35 +0200 Message-ID: References: <7f4cf1ee6c558899e8c9457102c2e0d4@mykolab.ch> <20170417135418.0bf12c87@sf> <1e60418d89b070a52d90ef4b3f08eba3@mykolab.ch> <20170417171822.GA8224@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0AsJ-0004qV-0s for guix-devel@gnu.org; Mon, 17 Apr 2017 13:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0AsF-0002xc-3w for guix-devel@gnu.org; Mon, 17 Apr 2017 13:55:43 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:38112 helo=mx-out02.mykolab.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0AsE-0002ug-TE for guix-devel@gnu.org; Mon, 17 Apr 2017 13:55:39 -0400 In-Reply-To: <20170417171822.GA8224@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Hi Leo, Good point! As the build succeeded I didn't think any of it. This could be important for other architectures than what Sergei and I are using. However, > find /tmp/go/src/cmd/ -name '*asm\.c*' doesn't return any file. Looks like they've removed these files. I'm pretty sure they're working to "free" their source of C code, so I wouldn't expect these files to reappear in a later release either. With this information I think it's safe to remove the asm.c substitution. Best, Petter On 2017-04-17 19:18, Leo Famulari wrote: > On Mon, Apr 17, 2017 at 03:37:49PM +0200, Petter wrote: >> Hi Sergei, >> >> I definitely think your fix deserves recognition. Without it I would >> certainly have been unable to build 1.8(.1)? this month. While editing >> the >> recipe is trivial mechanical wise, figuring out what to change was not >> :) >> >> Sorry to hear about your issues; I'm on x86_64 and Linux as well >> though... >> >> > $ /gnu/store/b4gflqj64yvksq7959r6m22mf9lzdy69-go-1.8.1/bin/go version >> > go version go1.8.1 linux/amd64 >> >> Hope you'll be able to work this out! >> >> Thanks for fixing Go 1.8 :) > > Yes, thanks to both of you for picking this up :) > >> @@ -300,8 +301,8 @@ sequential processes (CSP) concurrent programming >> features added.") >> (("/etc/services") (string-append net-base >> "/etc/services"))) >> (substitute* "time/zoneinfo_unix.go" >> (("/usr/share/zoneinfo/") tzdata-path)) >> - (substitute* (find-files "cmd" "asm.c") >> - (("/lib/ld-linux.*\\.so\\.[0-9]") loader)) >> + (substitute* (find-files "cmd" "\\.go") >> + (("/lib(64)?/ld-linux.*\\.so\\.[0-9]") loader)) > > The substitution that is removed here would still patch some files. > Shouldn't we adjust the old substitution to also match '/lib64', as > well > as add the new substitution? > > I've attached a patch for that.