From: Vinicius Monego <monego@posteo.net>
To: pinoaffe <pinoaffe@gmail.com>
Cc: 66199-done@debbugs.gnu.org
Subject: bug#66199: [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0.
Date: Sat, 7 Oct 2023 01:16:45 +0000 [thread overview]
Message-ID: <f3ce70e4-de2e-4048-8759-9cb9f82bf3c2@posteo.net> (raw)
In-Reply-To: <87y1gjz1ks.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2569 bytes --]
Hello,
Em 03/10/2023 20:39, pinoaffe escreveu:
> Thanks again!
>
> Vinicius Monego<monego@posteo.net> writes:
>>> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0.
>>> [inputs]: Add various dependencies (both new ones and old ones that are now
>>> debundled).
>> If the change is not automated, then every input should be listed,
>> separated by commas.
> Done, I hope this is more or less what you meant
>
>>> [arguments]: Remove overriding of configure phase. Replace test
>>> phase. Debundle various dependencies.
>> Avoid words like "various", list all items whenever possible.
> Okay
>
>>> [build-system]: Use cmake-build-system.
>>> [native-inputs]: Add googletest.
>> pkg-config was also added to native-inputs.
> I added it to the commit message
>
>> And don't worry too much about the commit message, I can change it
>> later.
> Aight
>
>>> + (list fontconfig
>>> + fontobene-qt5
>>> + glu
>>> + hoedown
>>> + muparser
>>> + opencascade-occt
>>> + clipper
>> Nitpick: 'clipper' is out of order
> Whoops!
>
>>> + `(#:phases (modify-phases %standard-phases
>>> + (replace 'check
>>> + (lambda* (#:key tests? #:allow-other-keys)
>>> + (when tests?
>>> + (setenv "QT_QPA_PLATFORM" "offscreen")
>>> + (setenv "QT_QUICK_BACKEND" "software")
>>> + (display "Running unittests...\n")
>>> + (invoke "./tests/unittests/librepcb-unittests" "--help")))))
>>> +
>> Why --help?
> Oops, that's a leftover artifact of me testing some stuff
>
>> I ran librepcb-unittests with no arguments and found that
>> ~20 tests failed out of ~2100. If it's not possible to skip them
>> manually, you could skip all tests and leave a comment reporting what
>> happened. I didn't check the output of --help.
> I manually skipped them, though I feel a bit "dirty" skipping 22 tests
> without properly knowing why they fail, especially since it's just a
> constant list of 22 strings in the middle of a package definition.
>
>> #:configure-flags is usually placed above #:phases.
> Okay, I moved it
>
>> I think this patch is ready after fixing the test suite.
> Great!
>
> Kind regards,
> pinoaffe
Great job! I pushed the patches after rewriting the commit message for
librepcb and doing some minor tweaks.
It's OK to skip some tests, and even better to add a comment stating
that they pass after the package is built.
Thanks,
Vinicius
[-- Attachment #2: Type: text/html, Size: 4958 bytes --]
next prev parent reply other threads:[~2023-10-07 1:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 20:27 [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-26 0:37 ` Vinicius Monego
2023-09-26 12:08 ` pinoaffe
2023-09-27 0:35 ` Vinicius Monego
2023-09-27 16:06 ` pinoaffe
2023-09-26 12:16 ` [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-09-26 12:16 ` [bug#66199] [PATCH v2 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-27 0:39 ` [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5 Vinicius Monego
2023-09-27 16:11 ` pinoaffe
2023-09-27 16:14 ` [bug#66199] [PATCH v3 " pinoaffe
2023-09-27 16:14 ` [bug#66199] [PATCH v3 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-27 18:45 ` pinoaffe
2023-09-27 18:46 ` [bug#66199] [PATCH v4 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-09-27 18:46 ` [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
2023-09-30 1:34 ` Vinicius Monego
2023-10-03 23:39 ` pinoaffe
2023-10-07 1:16 ` Vinicius Monego [this message]
2023-10-04 0:15 ` [bug#66199] [PATCH v5 1/2] gnu: Add fontobene-qt5 pinoaffe
2023-10-04 0:15 ` [bug#66199] [PATCH v5 2/2] gnu: librepcb: Update to 1.0.0 pinoaffe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ce70e4-de2e-4048-8759-9cb9f82bf3c2@posteo.net \
--to=monego@posteo.net \
--cc=66199-done@debbugs.gnu.org \
--cc=pinoaffe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.