From: swedebugia@riseup.net
To: iyzsong@member.fsf.org
Cc: 33575@debbugs.gnu.org,
Guix-patches <guix-patches-bounces+swedebugia=riseup.net@gnu.org>
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted.
Date: Fri, 07 Dec 2018 23:58:43 -0800 [thread overview]
Message-ID: <f2b8429f1eaf8611fcb148c055733e04@riseup.net> (raw)
In-Reply-To: <87sgz8ekvk.fsf@member.fsf.org>
On 2018-12-08 04:51, iyzsong@member.fsf.org wrote:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
>> (%checkers): Add it.
>> [...]
>>
>> +(define (check-inputs-should-be-sorted package)
>> + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
>> + ;; are not lexicographically ordered.
>
> Hello, consider 'gspell', it has some native-inputs for build and some
> for test:
>
> (native-inputs
> `(("glib" ,glib "bin")
> ("pkg-config" ,pkg-config)
> ("xmllint" ,libxml2)
>
> ;; For tests.
> ("aspell-dict-en" ,aspell-dict-en)
> ("xorg-server" ,xorg-server)))
>
> Currently I'd seperated them by a comment like this.
>
> If they are sorted, I have to add comment for each test input:
>
> `(("aspell-dict-en", aspecll-dict-en) ; for test
> ("glib" ,glib "bin")
> ("pkg-config" ,pkg-config)
> ("xmllint" ,libxml2)
> ("xorg-server" ,xorg-server)) ; for test
>
> Which will be a little annoying...
You convinced me sorting is a bad idea. Thanks for providing a good
argument :)
--
Cheers
Swedebugia
next prev parent reply other threads:[~2018-12-08 7:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 7:42 [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted Arun Isaac
2018-12-03 13:31 ` Ludovic Courtès
2018-12-04 9:13 ` Tobias Geerinckx-Rice
2018-12-08 13:29 ` Ludovic Courtès
2018-12-06 0:42 ` Oleg Pykhalov
2018-12-06 12:31 ` swedebugia
2018-12-07 13:08 ` Maxim Cournoyer
2018-12-08 3:51 ` 宋文武
2018-12-08 7:58 ` swedebugia [this message]
2018-12-08 13:34 ` Arun Isaac
2018-12-09 22:49 ` Maxim Cournoyer
2018-12-10 11:45 ` 宋文武
2018-12-10 11:19 ` 宋文武
2018-12-18 20:36 ` bug#33575: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b8429f1eaf8611fcb148c055733e04@riseup.net \
--to=swedebugia@riseup.net \
--cc=33575@debbugs.gnu.org \
--cc=guix-patches-bounces+swedebugia=riseup.net@gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.