From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QD9wJD1HbWKLJgAAbAwnHQ (envelope-from ) for ; Sat, 30 Apr 2022 16:27:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GIdzJD1HbWIdIAAAauVa8A (envelope-from ) for ; Sat, 30 Apr 2022 16:27:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 292A228562 for ; Sat, 30 Apr 2022 16:27:09 +0200 (CEST) Received: from localhost ([::1]:46900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nko3w-0003zz-BZ for larch@yhetil.org; Sat, 30 Apr 2022 10:27:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nko3q-0003y3-C9 for guix-patches@gnu.org; Sat, 30 Apr 2022 10:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nko3q-00062T-3O for guix-patches@gnu.org; Sat, 30 Apr 2022 10:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nko3p-0007j6-VI for guix-patches@gnu.org; Sat, 30 Apr 2022 10:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55080] [PATCH shepherd] service: Gracefully handle non-existing log directories. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 Apr 2022 14:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55080 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55080@debbugs.gnu.org Received: via spool by 55080-submit@debbugs.gnu.org id=B55080.165132880829677 (code B ref 55080); Sat, 30 Apr 2022 14:27:01 +0000 Received: (at 55080) by debbugs.gnu.org; 30 Apr 2022 14:26:48 +0000 Received: from localhost ([127.0.0.1]:58786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nko3c-0007ib-3Y for submit@debbugs.gnu.org; Sat, 30 Apr 2022 10:26:48 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:41574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nko3Z-0007iN-HL for 55080@debbugs.gnu.org; Sat, 30 Apr 2022 10:26:46 -0400 Received: by mail-ej1-f68.google.com with SMTP id dk23so20326735ejb.8 for <55080@debbugs.gnu.org>; Sat, 30 Apr 2022 07:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=WvNNoaDC0BJB+h22qXCIdCYszNSI2AsUj4op9xzVdwY=; b=YpOM6OaVkQV6Uqh9giAXdh/YBySygXy9tJMl3V6tVPqTepCnKIbdD1ut0JcAuGfrBG CY6411N7647lfiSEvGJqZDVrpf8XYM2FIwdPiYV8wK7ALby3/ZL93sRykKeRWHjQqb+r hGKjpasXVg/mG+0XmnCh9ezYayyCRA89Fht5vmqG+lr6yR6aUdnsxvqzO7JkI+o7RYOH NA3rhjRhOKBwkYEBw19vTysh/nalaYdm+TCy4dxFT5JiWbtBg+3gz72gAxAfHtA+fSV0 9CndLLqrsAAgSOWHdMY9ah4RqFbTvyeFKtsCwL39H/AsiQHhtVwK4nsi7fu8BtxjiZTS 15vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=WvNNoaDC0BJB+h22qXCIdCYszNSI2AsUj4op9xzVdwY=; b=PC4+Y2z9rUZg/OtDj05+cJfDl91gXed0BQ8ci1/ry0El7kIIphAiDivjsZETJgMBYK pdmpIIukevhHCMzMFpuE+Nu6+5CA2BGSlQvKBPM7Rcyg3ZjiLFMOcrxicWLTnD0xYjq1 fE6Z617zCONeAN+l7eATd7fbe2VihKrGxJMCAVN3PS4lGpoEiZ+/7uWvYdILl89l6595 mle1+mC4Ov+6fRCujf3thEFQEyloS12L+FQx3V8pgyDvl1oBqg4fygYv5gSKQnXx7jbG 3mH7PnY85WZyBedWGDI98OeMcIzTrRH3ah+qXCaRua8cINw/+mLExe2n9wmgWnyiEVZy e6uA== X-Gm-Message-State: AOAM531UkqhNA5vf09SsaNxa7udc+ykcfeX7GyrF4fB1wzURsPsPhEXH aWEsdaDZW1B99bYtkdhAMDI= X-Google-Smtp-Source: ABdhPJxS1Ku6D27KVuzJJUyx6L70bTwS+CdVHB8sy3z7EbFhHfdtmn0yjgTm9E3r3awk5/WIE1bM5g== X-Received: by 2002:a17:907:c07:b0:6f3:a3b2:9582 with SMTP id ga7-20020a1709070c0700b006f3a3b29582mr4117086ejc.91.1651328799545; Sat, 30 Apr 2022 07:26:39 -0700 (PDT) Received: from nijino.fritz.box ([85.127.52.93]) by smtp.gmail.com with ESMTPSA id jx22-20020a170907761600b006f3ef214df6sm1648566ejc.92.2022.04.30.07.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Apr 2022 07:26:38 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sat, 30 Apr 2022 16:26:29 +0200 In-Reply-To: <8735hu64je.fsf@gnu.org> References: <2e5292c2d45e525aa1b8e4c495704104d4121291.camel@gmail.com> <8735hu64je.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651328829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WvNNoaDC0BJB+h22qXCIdCYszNSI2AsUj4op9xzVdwY=; b=hjSUSRF6RarQapcKtGahdnn2lK1ySdNQwmGgeECJTN4xC9B/eclRVWfRF+X8IrtYhiq7eH 0qNjRFPwdpYVEm+gFQ56yCHvVfYcUOYhn3jwDrfjrt/3t72C6f6VkntvCxhtn3oh7Z2GDx WHv4Nn0ar0pRFaYM2HZ024I7XbLn4xsk32XaUqgLdQgw8c3aDbcFUmYsIol5Dc0mVgATre NV2a9d2HKNOmM23SAlX9qUqx3EQ8jD+bKTcjDIAttQtxchBeDpYHUqXBf+M62UM+bqOL8H iEHd+QzYXiiwAlZnT4IDdljHYLGrGmZ9s0BqjeYzrc55LrW2mzxF7rgbYuNqYQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651328829; a=rsa-sha256; cv=none; b=aO8WKlKQWDSgO/dupM04Mawztw9CWHo/3HQUKImzPzs6nq6wGRSawPaKsQ2lCHsi1B4Imb fIoEQnk5ixCXUIGVh0IEVQwPBsm3jpYuA2XqxBoNFx152/ovbAma/l2dPvQCz8gP6odEIF PSjyZAMYgJaxYHONQRJcWZDK8vaNXsbI5cReXFe3rYMVTa53KKFl8DBI0vsFdfTU3Q6k9v PFWyWrbtirVqS/oQitO5HWGD682qkvs12ZYV336qScIV0whq//yGdo2PVmvn5T1TgFGiwU KMw+Wg5+2GDbmRZg/w6xggmuGloilk2WU4M1FHi0XiGzVjR4H6tKjBByKtM3Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YpOM6OaV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YpOM6OaV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 292A228562 X-Spam-Score: 7.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: VO7QgbAywe8D Am Samstag, dem 30.04.2022 um 16:15 +0200 schrieb Ludovic Courtès: > > > +(define (service-file-logger file input) > > +  "Return a thunk meant to run as a fiber that reads from INPUT > > and logs it to > > +FILE." > > +  (catch 'system-error > > +    (lambda () > > +      (%service-file-logger file input)) > > +    (lambda args > > +      (if (= ENOENT (system-error-errno args)) > > +          (begin > > +            (mkdir-p (dirname file)) > > +            (%service-file-logger file input)) > > +          (apply throw args))))) > > I wonder to what extent automatically creating log directories is a > good idea.  A potential drawback is if shepherd creates them with > unexpected ownership or permissions. As far as I know, those logs should be managed by shepherd, no? It just redirects stdout/stderr there, or is there something special going on? > Did you encounter this issue while working on services? > > Am I right that the Shepherd 0.8 had the same problem? It might be, I don't know. I've encountered this for non-existing log directory, so a reproducer would be setting #:log-file to $test-tmp- directory/does-not-exist/log and check for each service. Cheers