From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Reza Alizadeh Majd" Subject: bug#38926: pcmanfm-qt unable to open files by double click Date: Tue, 07 Jan 2020 09:53:45 +0330 Message-ID: References: <20200105105655.5dde2d6c@scratchpost.org> <2e3e1ced-2c3c-4084-817d-ac19aca5562d@www.fastmail.com> <20200105233729.10add7f5@scratchpost.org> <20200105235739.6de82e76@scratchpost.org> <20200106173857.09760737@scratchpost.org> <8334f32d-e27e-4c91-896c-096de07fbdf2@www.fastmail.com> <20200106204453.44cc2213@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:36938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioiIa-00052x-Fb for bug-guix@gnu.org; Tue, 07 Jan 2020 01:25:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioiIY-0002Gn-9F for bug-guix@gnu.org; Tue, 07 Jan 2020 01:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41212) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioiIY-0002Gb-2T for bug-guix@gnu.org; Tue, 07 Jan 2020 01:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioiIX-0000Av-Tr for bug-guix@gnu.org; Tue, 07 Jan 2020 01:25:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20200106204453.44cc2213@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 38926@debbugs.gnu.org Hi Danny, > I don't think that will work. According to the glib source code[1], the > variable is read at runtime of the final program. oh, your right !!! I incorrectly thought that GIO_LAUNCH_DESKTOP is a preprocessor macro. > What you could do is use your wrap-program in pcmanfm-qt, but with > GIO_LAUNCH_DESKTOP (value like above) instead of PATH. That should fix > pcmanfm-qt and I don't see any forward incompatibility or side effects > introduced by it either. Also, glib would be unmodified. > > The downside would be that we would have to patch other broken programs > one by one (after *finding* them). > > But I would still be in favor of that fix for now. Could you try it and > send a patch? OK, so I fix and test pcmanfm-qt following this approach and submit the regarding patch. -- Regards Reza Alizadeh Majd PantherX Team