From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yDYDMFmw8mIefAAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 21:07:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6PsEMFmw8mJhmAAA9RJhRA (envelope-from ) for ; Tue, 09 Aug 2022 21:07:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51B1AF8D0 for ; Tue, 9 Aug 2022 21:07:04 +0200 (CEST) Received: from localhost ([::1]:41478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLUZC-00085v-Cf for larch@yhetil.org; Tue, 09 Aug 2022 15:07:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLURL-0001BP-FL; Tue, 09 Aug 2022 14:58:57 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:55696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLURJ-0003Ia-5p; Tue, 09 Aug 2022 14:58:55 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 6ABB52BBD6CA; Tue, 9 Aug 2022 20:58:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1660071524; bh=xvq+ISPajDmteK+JPnqmXtw9GgNPoTwN8Uhy7jJhrTM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=PrwSEKE1o9pqEjJv1sxzudFkZD3H/eybtwFm3BoVBliKOA/6Nq6X0RUPANthv5u9g qobRKzP5BCfhfRow+FwYVSqd+wXOZanLuRfuCK3veEXe+M5O6JtWpeQgKo3BO72gGv n1FhRZLYPlCCnDeiOC71CYXK1OeBQpvlpEQVV2Rs2Ad3/CW7zXj2xz45U0xfL8EFnk Q54mn6FY0p9TAcLcWSI59m8RN+XtifoLM06XYSYqydvolDtikeCfNXd/VTBaOIeneE ypSSJxGHefU9pAtg3HvOTXzvTHP6wIlw3AicUvR4GklC1aPyzz3mfElT/87kraaNDP qjIa3cJLRBr7A== X-Fuglu-Suspect: f036c99803b04236bf51311edf3b1c11 X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Tue, 9 Aug 2022 20:58:38 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 09 Aug 2022 20:58:38 +0200 From: david larsson To: Maxime Devos Cc: Guix-devel , Guix-devel Subject: Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. In-Reply-To: <98da36a2-d0cc-77da-77bf-6984253131ac@telenet.be> References: <98da36a2-d0cc-77da-77bf-6984253131ac@telenet.be> Message-ID: X-Sender: david.larsson@selfhosted.xyz Received-SPF: pass client-ip=217.64.149.7; envelope-from=david.larsson@selfhosted.xyz; helo=server0.selfhosted.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.997, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660072024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=xvq+ISPajDmteK+JPnqmXtw9GgNPoTwN8Uhy7jJhrTM=; b=iDcv45daH+wDbiE6fPCQ9JswgUA6rOzEDlrpTXXEQ9UmMiDFpp9t8hEW2aHEgtV5RfIYDr pndj0nUrRscRuJIfFQ8Lnm69+NC+zcCinxYqnTdwhrnHc8ay4VXVACuGsjC+uZaOuSse4h u7XPIgQL7CC4/iBBmEn0Yz/KWH9CQ8BbWgIGLG6AVixnKQcbbVOzsIaNtabf/XIA0U/ZxS h/9zzA32JrYRZahjWc6SRWTn4Y1fBeMfN4CXyeq7GU2yRdKNe+R1SZXaYzKtlIXwmXu9vt +1WbguJHmjfrQrn/fAgVGROgpWX+7nwIPEggumrfbCTSQSs17tzBZE+H8Ow5wA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660072024; a=rsa-sha256; cv=none; b=pMe92ypcY4CDq0BXK0oB76Nqa9+IzcD/EFCjLoEuCBUhyHmZsSSGN+O6MJ7k3u6xV8t2LA pLhY2cN0VbCiPIPqcGpzcjLDxqMzd0Utksu4gjef2pMVvlYKL+fVggjmKnmoM89On1vM4+ 9BaE4LL2RrEO6yAinXhvZskMz52DbIcSLxIkfWyyeGaO9U3+lWfpVF7S7CiGF5Y3cyV6JL 4MOiPoApytY91Hkq/uf+AO4A6NA/W58NIrBf5iEmZnqlgCk8yBUI0zAdmkb/G4p39DyvaU DFFYB6asDX/KGo49wztFdAaq8+FkvDJw/TZ+H0nsBI58A5/1VhC+r4BFdVJVUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=selfhosted.xyz header.s=dkim header.b=PrwSEKE1; dmarc=pass (policy=none) header.from=selfhosted.xyz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.09 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=selfhosted.xyz header.s=dkim header.b=PrwSEKE1; dmarc=pass (policy=none) header.from=selfhosted.xyz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 51B1AF8D0 X-Spam-Score: -6.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: Oqddjsght0nV On 2022-08-05 15:59, Maxime Devos wrote: [..] > > 20.4.5.3 Fixing technical issues (compilation errors, test failures, > other bugs ...) > > Usually, a bug fix comes in the form of a patch copied from upstream > or another distribution. In that case, simply adding the patch to the > 'patches' field is the most convenient and usually does not cause any > problems; there is no need to rewrite it as a snippet or a phase. > > If no ready-made patch already exists, then choosing between a patch > or a snippet is a matter of convenience. However, there are two things > to keep in mind: > > First, when the fix is not Guix-specific, it is strongly desired to > upstream the fix to avoid the additional maintenance cost to Guix. As > upstreams cannot accept a snippet, writing a patch can be a more > efficient use of time. Secondly, if the fix of a technical issue > embeds a store file name, then it has to be a phase. Otherwise, if a > store file name was embedded in the source, the result of 'guix build > --source' would be unusable on non-Guix systems and likely also > unusable on Guix systems of another architecture. There may be other reasons to add patches: 1. Functionality, that is not yet accepted upstream, because maintainer(s) do not have enough time to review all pull requests, or are simply slow to review. "if no response within X time from upstream, then guix may include your patch" might be a good policy here. 2. Bug fixes - as you mentioned - for such, it might be good with a: "if no response within X time from upstream, then guix may include your bug-fix patch". 3. Unmaintained projects - sometimes there are packages that are nice to include but which may no longer be maintained by upstream, and a few patches could still make the package usable and nice to have for Guix users. IMO such packages should generally be accepted, including minor patches that enhances the package. Examples would include guile-bash, and maybe emacs-company-tern (not in guix, but might be nice to have). There are probably more examples. Im not a guix maintainer, so maintaining above varieties of patches might not be feasible, but there are potential benefits, like maybe guix is just "nicer" than other distros because of it. Or it might have the opposite effect if the maintenance burden is too high. Guix should spread more to mainstream IMO, and being able accept patches that are "nice", would benefit that purpose. Best regards, David