From: david larsson <david.larsson@selfhosted.xyz>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Guix-devel <guix-devel@gnu.org>,
Guix-devel
<guix-devel-bounces+david.larsson=selfhosted.xyz@gnu.org>
Subject: Re: v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.
Date: Tue, 09 Aug 2022 20:58:38 +0200 [thread overview]
Message-ID: <f15a0b305d2873d1b43e2c5100409cda@selfhosted.xyz> (raw)
In-Reply-To: <98da36a2-d0cc-77da-77bf-6984253131ac@telenet.be>
On 2022-08-05 15:59, Maxime Devos wrote:
[..]
>
> 20.4.5.3 Fixing technical issues (compilation errors, test failures,
> other bugs ...)
>
> Usually, a bug fix comes in the form of a patch copied from upstream
> or another distribution. In that case, simply adding the patch to the
> 'patches' field is the most convenient and usually does not cause any
> problems; there is no need to rewrite it as a snippet or a phase.
>
> If no ready-made patch already exists, then choosing between a patch
> or a snippet is a matter of convenience. However, there are two things
> to keep in mind:
>
> First, when the fix is not Guix-specific, it is strongly desired to
> upstream the fix to avoid the additional maintenance cost to Guix. As
> upstreams cannot accept a snippet, writing a patch can be a more
> efficient use of time. Secondly, if the fix of a technical issue
> embeds a store file name, then it has to be a phase. Otherwise, if a
> store file name was embedded in the source, the result of 'guix build
> --source' would be unusable on non-Guix systems and likely also
> unusable on Guix systems of another architecture.
There may be other reasons to add patches:
1. Functionality, that is not yet accepted upstream, because
maintainer(s) do not have enough time to review all pull requests, or
are simply slow to review. "if no response within X time from upstream,
then guix may include your patch" might be a good policy here.
2. Bug fixes - as you mentioned - for such, it might be good with a: "if
no response within X time from upstream, then guix may include your
bug-fix patch".
3. Unmaintained projects - sometimes there are packages that are nice to
include but which may no longer be maintained by upstream, and a few
patches could still make the package usable and nice to have for Guix
users. IMO such packages should generally be accepted, including minor
patches that enhances the package. Examples would include guile-bash,
and maybe emacs-company-tern (not in guix, but might be nice to have).
There are probably more examples.
Im not a guix maintainer, so maintaining above varieties of patches
might not be feasible, but there are potential benefits, like maybe guix
is just "nicer" than other distros because of it. Or it might have the
opposite effect if the maintenance burden is too high. Guix should
spread more to mainstream IMO, and being able accept patches that are
"nice", would benefit that purpose.
Best regards,
David
next prev parent reply other threads:[~2022-08-09 19:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 3:17 A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Maxime Devos
2022-07-25 5:21 ` Julien Lepiller
2022-07-25 11:18 ` Maxime Devos
2022-07-25 11:37 ` Julien Lepiller
2022-08-04 8:51 ` Ludovic Courtès
2022-08-05 3:23 ` Philip McGrath
2022-08-05 8:13 ` Maxime Devos
2022-08-05 3:38 ` Philip McGrath
2022-08-05 8:09 ` Maxime Devos
2022-08-05 10:18 ` Maxime Devos
2022-08-05 13:59 ` v2: " Maxime Devos
2022-08-06 6:55 ` [PATCH] doc: Update contribution guidelines on patches, etc Liliana Marie Prikler
2022-08-06 6:55 ` [PATCH v2] " Liliana Marie Prikler
2022-09-02 13:12 ` Ludovic Courtès
2022-09-02 18:05 ` Maxime Devos
2022-09-05 9:47 ` Ludovic Courtès
2022-09-05 13:12 ` Maxime Devos
2022-09-05 16:05 ` Maxime Devos
2022-08-09 16:45 ` [PATCH] " Maxime Devos
2022-08-09 17:05 ` Liliana Marie Prikler
2022-08-09 18:19 ` Maxime Devos
2022-08-09 19:08 ` Liliana Marie Prikler
2022-08-09 20:30 ` Maxime Devos
2022-08-10 4:25 ` Liliana Marie Prikler
2022-08-09 20:40 ` Maxime Devos
2022-08-08 21:51 ` v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Andreas Enge
2022-08-09 15:06 ` Maxime Devos
2022-08-09 17:10 ` Andreas Enge
2022-09-05 13:03 ` Maxime Devos
2022-09-07 12:17 ` Andreas Enge
2022-09-07 18:08 ` Maxime Devos
2022-08-09 18:58 ` david larsson [this message]
2022-08-09 20:53 ` Maxime Devos
2022-08-10 11:23 ` david larsson
2022-08-05 16:59 ` blake
2022-08-09 16:30 ` Maxime Devos
2022-09-05 14:06 ` Maxime Devos
2022-08-10 6:10 ` blake
2022-08-10 9:06 ` Maxime Devos
2022-08-10 10:33 ` blake
2022-08-10 10:44 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f15a0b305d2873d1b43e2c5100409cda@selfhosted.xyz \
--to=david.larsson@selfhosted.xyz \
--cc=guix-devel-bounces+david.larsson=selfhosted.xyz@gnu.org \
--cc=guix-devel@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.