all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: gemmaro <gemmaro.dev@gmail.com>, 71319@debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#71319] [PATCH v3 3/3] gnu: emacs-ddskk-nicola: Improve package style.
Date: Thu, 20 Jun 2024 18:06:55 +0200	[thread overview]
Message-ID: <f06da2a619dee0d6501f57722233be8347db4358.camel@gmail.com> (raw)
In-Reply-To: <3b7722e4eba090d4b45b739175c5094aa1907f03.1718839586.git.gemmaro.dev@gmail.com>

Am Donnerstag, dem 20.06.2024 um 08:32 +0900 schrieb gemmaro:
> * gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use
> newer
> package style.  This is necessary due to the emacs-ddskk package
> style update
> since emacs-ddskk-nicola inherits this.  It also remove making
> NICOLA-DDSKK-CFG writable, and removes the last #t values from the
> lambda
> expressions in phases.
Again, don't sneak in code changes with formatting ones; and the
ChangeLog formatting hints to the previous patch mostly apply here as
well.

The "this is necessary, because…" part should probably go before the
ChangeLog, with the explanation that it is a follow-up to the previous
commit.

Cheers




  reply	other threads:[~2024-06-20 16:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02  7:56 [bug#71319] [PATCH 0/2] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-02  9:08 ` [bug#71319] [PATCH 1/2] " gemmaro
2024-06-02  9:08 ` [bug#71319] [PATCH 2/2] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-11 11:20 ` [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-11 11:20   ` [bug#71319] [PATCH v2 2/3] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-19 11:16     ` Nicolas Goaziou via Guix-patches via
2024-06-11 11:20   ` [bug#71319] [PATCH v2 3/3] gnu: emacs-ddskk-nicola: " gemmaro
2024-06-19 11:14     ` Nicolas Goaziou via Guix-patches via
2024-06-19 11:12   ` [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 Nicolas Goaziou via Guix-patches via
2024-06-19 23:32 ` [bug#71319] [PATCH v3 " gemmaro
2024-06-19 23:32   ` [bug#71319] [PATCH v3 2/3] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-20 16:04     ` Liliana Marie Prikler
2024-06-19 23:32   ` [bug#71319] [PATCH v3 3/3] gnu: emacs-ddskk-nicola: " gemmaro
2024-06-20 16:06     ` Liliana Marie Prikler [this message]
2024-06-21 23:02 ` [bug#71319] [PATCH v4 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-21 23:02   ` [bug#71319] [PATCH v4 2/3] gnu: emacs-ddskk: Use newer package style gemmaro
2024-06-21 23:02   ` [bug#71319] [PATCH v4 3/3] gnu: emacs-ddskk-nicola: Use new " gemmaro
2024-06-23  8:16     ` bug#71319: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f06da2a619dee0d6501f57722233be8347db4358.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=71319@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=gemmaro.dev@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.