From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UKRxMA7rAGIIcwEAgWs5BA (envelope-from ) for ; Mon, 07 Feb 2022 10:49:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aJ8bLQ7rAGKnggAAauVa8A (envelope-from ) for ; Mon, 07 Feb 2022 10:49:02 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F53642FF9 for ; Mon, 7 Feb 2022 10:49:02 +0100 (CET) Received: from localhost ([::1]:53270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nH0dp-00018T-Ed for larch@yhetil.org; Mon, 07 Feb 2022 04:49:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGzcy-0002Ji-Ew for guix-patches@gnu.org; Mon, 07 Feb 2022 03:44:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGzcv-0000yW-KN for guix-patches@gnu.org; Mon, 07 Feb 2022 03:44:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGzcv-0008Pt-J0 for guix-patches@gnu.org; Mon, 07 Feb 2022 03:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53648] [PATCH] gnu: fcitx5-gtk: Add GTK 4 support. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Feb 2022 08:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53648 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zhu Zihao Cc: 53648@debbugs.gnu.org Received: via spool by 53648-submit@debbugs.gnu.org id=B53648.164422338632283 (code B ref 53648); Mon, 07 Feb 2022 08:44:01 +0000 Received: (at 53648) by debbugs.gnu.org; 7 Feb 2022 08:43:06 +0000 Received: from localhost ([127.0.0.1]:40876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGzc1-0008Od-OT for submit@debbugs.gnu.org; Mon, 07 Feb 2022 03:43:05 -0500 Received: from xavier.telenet-ops.be ([195.130.132.52]:43168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGzc0-0008OU-6q for 53648@debbugs.gnu.org; Mon, 07 Feb 2022 03:43:05 -0500 Received: from [172.20.10.9] ([213.119.168.30]) by xavier.telenet-ops.be with bizsmtp id s8j2260060fhH05018j2hz; Mon, 07 Feb 2022 09:43:02 +0100 Message-ID: From: Maxime Devos Date: Mon, 07 Feb 2022 09:42:57 +0100 In-Reply-To: <86czjz8fmt.fsf@163.com> References: <86ilu09yzs.fsf@163.com> <8635kwasnn.fsf@163.com> <86czjz8fmt.fsf@163.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-35V19UqnQWl/9xFieSUs" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1644223382; bh=/6O/1+3p96Hhg88cESF/hwXuvD8eqSihMmvLhQ5OaaA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=dJ525FdUAKJBcjp2nyb7r2zcDs83nnzfjhebl0nyL57Zi9P1eDD2jFGQKqC76Hp4h OpU/RYQ+7Nt0EboOeWEUlpAiWZSltvWsrvuMSYbafFkMpqwLeiz8q/TMp3qSOBdfWp OQlifvjguTtfVP02NJaAolOjwJkZ/0C1wJ+cDwd6qHEIkJy2vJCb91b/VmNoqw7xsq F3E/7s+aw0y9DKVW9V+YzvqOUwwTBvzf/r029uXfv1MIPllEp6+NdyCmbuVixuMBLl c68xQhmkQCkJB7bvoFvwPEZivpExm/fwaTZCJApwsIat+Xbijjo0hVMOreywYZ2Pm7 rI/k6w5+ADHsA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644227342; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/6O/1+3p96Hhg88cESF/hwXuvD8eqSihMmvLhQ5OaaA=; b=gID9KTFxBeDPFJ/Jx25O9Vx6fnyc8G0BiCsfMY2aZCklS1HF65LRoiRfS0SyMg5cq8unjC Av0bzOK3MbhBjho3IEXpcq3KGGe2eBS4NLA+YFXZVn/m871bxoPMFbXZPxMZtUWLCXnWiM euXrIk2tJQCgZACm6tvoe9TkQDIPoPXTx87PRbIVXoiQ98gmuH+nChFbSs+SNooaTjdKhO FHEIiLBqkmxPumLqpTBxsu5VhTfbJPMXMH3GCOQE32L8mQr+rjxYtGhGlwPpdbsmRebAPL iYEmtaOFcz/ytSUtn0s6cHMsqSC8zDbxTAQEXN1mauPUsW6wjVWBJ6Nckjnlyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644227342; a=rsa-sha256; cv=none; b=XiBogBx9tpCB/9B5tn+B7lxom2RQ91NQWcssJSeTvZmn+SxnYHYgTpvLXmdFYpP/l+wcrr Czc/5EQ/F4k/02vomLoF6qIaOTQncJIvYTy791a+BPz6EIHfbWAhYM6YzwKnrFk3ipf/js J2C7lJ17qMXbc15mayxXMCmzDnSN3KJIt0pSZHp/cW8a0IN4c01kXFqoZysfoWdEWmYd7D 9EPPrReLZuJ/UvcdrkiL4SBoViBZ7hF84u077heMMTjX+FI+/ZNVsrlxoaFumfeA2vdWdx 5flJdCjn0UMn31jBOwkKyNLQXSAIG2Udr6bQ1dG5EeS455gpqLJyhbDUwDK0bg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dJ525FdU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dJ525FdU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6F53642FF9 X-Spam-Score: -4.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZqByBFOi5fM0 --=-35V19UqnQWl/9xFieSUs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Zhu Zihao schreef op ma 07-02-2022 om 12:25 [+0800]: > It matters, because fcitx5-gtk is not a GTK *application*, it > provides IM module for GTK applications. Guix users may have both > GTK3 & GTK4 application in same environment. If we drop gtk3 (or even > gtk2), their input method will be broken. Ok, that's a good reason, but it would deserve a comment in the package definition to explain matters to future readers. > I just check the comment left by iyzsong, and I think it's better to > make the glib client in "out", and make IM module for different GTK > version in "gtk2" "gtk3" "gtk4" output. Thoughts? It would be useful to explain in the description that the output that needs to be installed, depends on what other software in in the profile. E.g.: "Fcitx5-gtk provides a Glib-based D-bus client and IM module for GTK+2/GTK+3/GTK4 applications. The output that needs to be installed, depends on which variant of GTK that applications use. When in doubt, it is sufficient to simply install all outputs." Greetings, Maxime. --=-35V19UqnQWl/9xFieSUs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYgDbkRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nMgAP9Hz+QGnyapK6XvD7Sk/E0y0SfL nC2mzrMS2nlS+SwtpgEAx8nHWruzm4Sf9VIyKMkZFOh7T+YXMBlqyLcDHCOtNAI= =5kWj -----END PGP SIGNATURE----- --=-35V19UqnQWl/9xFieSUs--