From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qAJaBSOvUGB2CwAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 13:14:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8Ns3ASOvUGCyKgAA1q6Kng (envelope-from ) for ; Tue, 16 Mar 2021 13:14:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7914119B1B for ; Tue, 16 Mar 2021 14:14:10 +0100 (CET) Received: from localhost ([::1]:34522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lM9WT-0000Pz-MA for larch@yhetil.org; Tue, 16 Mar 2021 09:14:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lM9WM-0000Oa-Kh for guix-patches@gnu.org; Tue, 16 Mar 2021 09:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lM9WM-0001gg-Cj for guix-patches@gnu.org; Tue, 16 Mar 2021 09:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lM9WM-0006F0-8a for guix-patches@gnu.org; Tue, 16 Mar 2021 09:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44492] [PATCH v5 09/51] gnu: Add rust-gspell-sys-0.4. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Mar 2021 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44492 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo To: Efraim Flashner Cc: 44492@debbugs.gnu.org Received: via spool by 44492-submit@debbugs.gnu.org id=B44492.161590038423919 (code B ref 44492); Tue, 16 Mar 2021 13:14:02 +0000 Received: (at 44492) by debbugs.gnu.org; 16 Mar 2021 13:13:04 +0000 Received: from localhost ([127.0.0.1]:38496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM9VP-0006Di-TG for submit@debbugs.gnu.org; Tue, 16 Mar 2021 09:13:04 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM9VO-0006DP-CN for 44492@debbugs.gnu.org; Tue, 16 Mar 2021 09:13:02 -0400 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4F0DHJ1TB6z3wN4; Tue, 16 Mar 2021 14:13:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1615900380; bh=3IkZSdJ6IN5lqjtLbVqaRm4JJLcRulgaCEXjMLWpogY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Wtx9UoD9TQILMhfsXDQ7KK9u0Abgbs7XhuOXf1s7suKBQcS7ekyInfo4QZU5jEduu i9Y4FO7PyqGUt2UywcyfmAwarGoUhTF2RrZJ4vVR545UKslcfo/meTtRnxfi+DKi6o IVOyk8EZISwc3/YUS2snP3Ga2ZDLzHBoLFYprnJg= Message-ID: From: Leo Prikler Date: Tue, 16 Mar 2021 14:12:59 +0100 In-Reply-To: References: <20210315154342.9437-1-leo.prikler@student.tugraz.at> <20210315154342.9437-9-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615900450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3IkZSdJ6IN5lqjtLbVqaRm4JJLcRulgaCEXjMLWpogY=; b=Jypfe0VLh2XMY6ocnKU2drlMihe9t+B6wQ7ETrFffJSb24CSAFNof6syTrEWViwQUttmD4 R6eUv/fhwLXtdfY3HuXuvdjlY5MlH2WCkwEfbFJZAjfn2biPmxTySIy9qV/ob4z8//2dNy eoLg9ANY+srM5Irsb/8QKSLaSr92PyCV3oGZunLpASFT+SpfnqYD4aG9K+8UTlC4SUuETY uyHdUdvppWPwTYEnF/JzEkL271/C6mGXVTBJ1+SuoppdXyn53Fzx43xeNlucnrsqiCXtxr XtX1T2io/pwmJ7WvWenMnrYxulnQAMaN1V/OdcOoqRr5nv0xBnOqMMdNuvylDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615900450; a=rsa-sha256; cv=none; b=roGbqkiX3ueOTmYseLn8aKmkR1LHLNrunwBrvM9YSWRcBFZUOg0G8/aio68grq3qIs8Xfh MI70IA+GEBqA5ozQIgByESStZt16QoXvRGQj3jQOkirOMylntVfJ5AYn+2eiTiJBCQHBRI bSLFGC1tOAzfdsYmQZG/Sfb44CZm310V2rI5LlmLsGGyCL1cc7MMKwacnOd/9Kom1BfK7A Y5vIm21mM/5lxAnMfK55QYt65AU80NO/+kEkG+euoFXDaZbVSpzXz6/ajA2UN4UIbNG5KV tiAtAyzVd4Z/KGHQ2gC7+67TIBe+YIB1g21jjQaOjCvkSyXBgWeSV2FegAOR5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Wtx9UoD9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Wtx9UoD9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7914119B1B X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: TI+JwnS9EIE1 Am Dienstag, den 16.03.2021, 14:42 +0200 schrieb Efraim Flashner: > Sometimes the rust-*-sys packages bundle the source code for the > package > they wrap, is that the case here? That it wants pkg-config is good, > but > it's worth checking. As far as I'm aware, none of the GNOME crates do this. Fractal would even use a version of the gettext crate, that doesn't bundle gettext, but alas, we ship the bundled one in Guix. > On Mon, Mar 15, 2021 at 04:43:42PM +0100, Leo Prikler wrote: > > * gnu/packages/crates-gtk.scm (rust-gspell-sys-0.4): New variable. > > --- > > gnu/packages/crates-gtk.scm | 48 > > ++++++++++++++++++++++++++++++++++++- > > 1 file changed, 47 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/crates-gtk.scm b/gnu/packages/crates- > > gtk.scm > > index 0d72fbf321..09aa79daba 100644 > > --- a/gnu/packages/crates-gtk.scm > > +++ b/gnu/packages/crates-gtk.scm > > @@ -26,7 +26,8 @@ > > #:use-module (gnu packages crates-io) > > #:use-module (gnu packages crates-graphics) > > #:use-module (gnu packages glib) > > - #:use-module (gnu packages gtk)) > > + #:use-module (gnu packages gtk) > > + #:use-module (gnu packages pkg-config)) > > > > ;;; > > ;;; Please: Try to add new module packages in alphabetic order. > > @@ -887,6 +888,51 @@ > > (("rust-shell-words" ,rust-shell-words-0.1) > > ("rust-tempfile" ,rust-tempfile-3)))))) > > > > +(define-public rust-gspell-sys-0.4 > > + (package > > + (name "rust-gspell-sys") > > + (version "0.4.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (crate-uri "gspell-sys" version)) > > + (file-name > > + (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + "07snannzd36wlms2x880ylkq7h1162g0kv9y54wlrc2nd11kjc2c"))) > > ) > > + (build-system cargo-build-system) > > + (arguments > > + `(#:cargo-inputs > > + (("rust-glib-sys" ,rust-glib-sys-0.9) > > + ("rust-gobject-sys" ,rust-gobject-sys-0.9) > > + ("rust-gtk-sys" ,rust-gtk-sys-0.9) > > + ("rust-libc" ,rust-libc-0.2) > > + ("rust-pkg-config" ,rust-pkg-config-0.3)) > > + #:cargo-development-inputs > > + (("rust-shell-words" ,rust-shell-words-0.1) > > + ("rust-tempfile" ,rust-tempfile-3)) > > + #:phases > > + (modify-phases %standard-phases > > + (add-before 'check 'pre-check > > + (lambda* (#:key inputs #:allow-other-keys) > > + (setenv "CC" (which "gcc")) > > Even if it can't be cross compiled now it should still be > (cc-for-target) Good catch, will do so in v8. > > + #t))))) > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (inputs > > + `(("atk" ,atk) > > + ("cairo" ,cairo) > > + ("glib" ,glib) > > + ("gspell" ,(module-ref (resolve-module '(gnu packages > > gnome)) > > + 'gspell)) > > Unless there's a problem with circular package modules you should > really > just import gnome into the package module. That's exactly the problem though. Rust packages in gnome.scm need stuff from crates-gtk and doing it this way helps resolve the issue. Should I add a comment about that? Regards, Leo