From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er8wM-00068L-Qx for guix-patches@gnu.org; Wed, 28 Feb 2018 16:07:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er8wI-000192-Q5 for guix-patches@gnu.org; Wed, 28 Feb 2018 16:07:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1er8wI-00018I-I8 for guix-patches@gnu.org; Wed, 28 Feb 2018 16:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1er8wI-0006MR-3c for guix-patches@gnu.org; Wed, 28 Feb 2018 16:07:02 -0500 Subject: [bug#30654] giflib / khtml build failures Resent-Message-ID: References: <20180228201202.1481-1-h.goebel@crazy-compilers.com> <0a80adad-2621-d2e6-3df9-5bab94471727@crazy-compilers.com> <20180228225742.77c7707e@scratchpost.org> From: Hartmut Goebel Message-ID: Date: Wed, 28 Feb 2018 22:06:06 +0100 MIME-Version: 1.0 In-Reply-To: <20180228225742.77c7707e@scratchpost.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 30654@debbugs.gnu.org Am 28.02.2018 um 22:57 schrieb Danny Milosavljevic: > I would prefer to remove reallocarray from giflib entirely. But this is a much more invasive change. I'd leave this to upstream. IMHO To do it correctly, we would need to use conditional compilation - which I can not do anyway due to lack of glibc knowledge. What about renaming the one in giflib into __giflib__reallocmemory? It's only used 9 times in the whole code. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |