From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GIx1Jzirs2GF4AAAgWs5BA (envelope-from ) for ; Fri, 10 Dec 2021 20:32:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QOJGIzirs2H5XgAA1q6Kng (envelope-from ) for ; Fri, 10 Dec 2021 19:32:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64D82214D8 for ; Fri, 10 Dec 2021 20:32:08 +0100 (CET) Received: from localhost ([::1]:49936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvlcl-0002lf-HU for larch@yhetil.org; Fri, 10 Dec 2021 14:32:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvlcg-0002lE-EM for guix-patches@gnu.org; Fri, 10 Dec 2021 14:32:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvlcg-0001Yf-5i for guix-patches@gnu.org; Fri, 10 Dec 2021 14:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mvlcg-0001Rb-2l for guix-patches@gnu.org; Fri, 10 Dec 2021 14:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52371] [PATCH 0/2] Update tdlib and emacs-telega. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Dec 2021 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52371 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , Nicolas Goaziou Cc: zevlg@yandex.ru, 52371@debbugs.gnu.org Received: via spool by 52371-submit@debbugs.gnu.org id=B52371.16391646965518 (code B ref 52371); Fri, 10 Dec 2021 19:32:02 +0000 Received: (at 52371) by debbugs.gnu.org; 10 Dec 2021 19:31:36 +0000 Received: from localhost ([127.0.0.1]:47932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvlcG-0001Qw-8k for submit@debbugs.gnu.org; Fri, 10 Dec 2021 14:31:36 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvlcD-0001Qi-Ax for 52371@debbugs.gnu.org; Fri, 10 Dec 2021 14:31:35 -0500 Received: by mail-wm1-f68.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so9748683wmj.5 for <52371@debbugs.gnu.org>; Fri, 10 Dec 2021 11:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=sq8NswjlcSGwTpa5zppMI3dAO11QZy7Jz9796cmbkHY=; b=j7eIXRSHpogH0//qswwG7fSnH9ivzAW6WbJxY4o2sm5OGZBsRvFv+vrzY9GNBbcgHs JuVTNsDxiihbVYpPbXls5ORj9ZCliqGqpE306QCybe/13R9AP5RZjJBtMqNGVtbgsAYl b7I5lK3aLTdEWLO85xH8gF4MqZIL/+629mhx9ABvlqa6tf0QkG5Ot8MYaS7vY933xZue oyEC3Qryv9o2wus7WodTbb8Z3Cjb5Rl+11wzulSpWf8CvgDrI2HwyqmpGeX/fgU4gtG6 IOaER8XOk0EidBkIRbEgSvjBcYXkYCpMbAasbIEs5OY0or9PrGWG9qRdXA4kRL/yBhtZ +dUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=sq8NswjlcSGwTpa5zppMI3dAO11QZy7Jz9796cmbkHY=; b=ZmCl2L/WXp0E8twVx2Q1yTf6WGQ4/evc3lZ0uz+4FPg7vj3KxlwP/3km1WIDs6TsDy IFzghGXCZpgn6z4CMjR/AUXbmZonOtTMKrMmRp14RSsBnvmECtrfoBo4CrlkRxXGzVAq X8dY5X+qogagBZlgtSUwu7Dk+dWxHo4d4g2nQAkNAlvSqaDxepv9GLGQ6bTF125vFGoi dltm6wpPebPJPMHTbLPkw0Q1TYmfwIZ0iTwxB04TRm88mXF9Dw1UiP6IcuRpnsd/mSJs 7z3lu5bkZIY0ejvnZcNIx3Fgz9SWG/zPrwM6HcXvkAEdJiq4tvU2N8yjslcd2sRmQmy3 fhyA== X-Gm-Message-State: AOAM531NpSb5P8kuUBy2AlruBXf1FHs/0VtGoSsD0i3CY+JDFA/yK6Xi rfq3NT++cd74pKXkm7++XzN10JV0UaQ= X-Google-Smtp-Source: ABdhPJzybq1ge9YZvcq5XEXVGblnVFSORhUixQbDREwh/kXaXAX4IXcuUcyIctLr3J4NcGqKvIVofQ== X-Received: by 2002:a05:600c:29a:: with SMTP id 26mr19134841wmk.86.1639164687635; Fri, 10 Dec 2021 11:31:27 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a198sm3616975wmd.42.2021.12.10.11.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 11:31:27 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 10 Dec 2021 20:31:25 +0100 In-Reply-To: <878rwsj4bb.fsf@trop.in> References: <875yrzh2ee.fsf@trop.in> <87bl1qtc7y.fsf@nicolasgoaziou.fr> <87k0gdg5b9.fsf@trop.in> <6dfdd2d52bf2b52aa5022c4a085015ac535fccd6.camel@gmail.com> <878rwsj4bb.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639164728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sq8NswjlcSGwTpa5zppMI3dAO11QZy7Jz9796cmbkHY=; b=qY718k5/BkH0HtOM80WpbbrIXQ6BLE8+AM0GcmRMV4kcutZXkONlP6BQ1WZHgHEq94ks05 JAcbagg9Ygr51LY+ZD2eRVV1btGAaoJB0J9RTi/BKCHgmhEUKbW/YOyoocv7xIzHkqX+T5 z0Sq/Nzc1vPGLFaKwiyEeDR/MJCZhEuyKIQNKesXajQZm9Ykkfhh6kEF4YIg4pDmGn8pOz PmweBfb/HHJacifI/wlRnJkick/3aUgPdF8WrW6MGcWdx6Sc+300NT0MXsVQU8RWC+b4B9 tT1mujT64yR20SExCSUPHP3KotVDr2VwFAlKTI6coav4R3VosiUFI1Ha1yKjyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639164728; a=rsa-sha256; cv=none; b=tNDuVo4aRE9Leacd4zJmY5EuXROy8/LBMfTSmM+uPG5LEoewI3MonE+/syc8PAOC9v793p AOfuI6Das28Gd4fFRH6eo7jgI8qGsLYAYx9aSirbg9+cf4WbCHQ6pLtTL5CO/ABof0pK9N Fbmy9LrIpBtGgQ+/3Oi/U6wbldC2GL38TJWO6OisGW84JayJP2Q3nxfoSFVmCFGCOo3D7i Kh6TUE1b/JlVZuTX2+T1rD2wGxfk+pTqkDDlVQEQ5+p26RfyJ0S6CPc9NelhP2Ntz5vDzD ThM/+luwX4HB6YsFxM3SZbSEpMxcHuGNyQi2NxbiR+d0kQy+5Dd8ZoSU+gQ6qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j7eIXRSH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=j7eIXRSH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 64D82214D8 X-Spam-Score: -1.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: dlVQEWzU3Rqv Am Freitag, den 10.12.2021, 10:40 +0300 schrieb Andrew Tropin: > On 2021-12-09 20:39, Liliana Marie Prikler wrote: > > > Hi, > > > > note to self: I'm not trying to build tdlib again. Last build was > > not finished after almost a day and power went out so I don't even > > know whether it succeeded after I went to work or not. > > Ouch, IIRC it took a few dozens of minutes for my laptop. Do you use > underpowered hardware or something was wrong with compilation > process? It's the check phase that's killing me, but that doesn't really rule out weak hardware. I'm not touching staging or core-updates for that very reason. > > Anyway, > > > > > +-(defcustom telega-server-command "telega-server" > > > ++(defcustom telega-server-command "@TELEGA_SERVER_BIN@" > > [...] > > > - (substitute* "telega-server.el" > > > + (substitute* "telega-customize.el" > > > (("@TELEGA_SERVER_BIN@") > > > (string-append (assoc-ref inputs "emacs-telega- > > > server") > > > "/bin/telega-server"))) > > > > > I know this has existed before your patch, but I'm pretty sure we > > have > > emacs-based routines that could make this substitution in one go. > > Do you mean emacs-substitute-sexps from (guix build emacs-utils) ? I think emacs-substitute-variables is the "correcter" option here, but both are fine. > > If you're interested in further janitor work, you could do this > > either on master, or you could do something in terms of (search- > > input-file) on c-u-f. > > > > Other than that LGTM on a quick glance. > > Cheers > > > > Let's keep it as it is right now, probably I'll be updating this > package later again and will refactor it. > > Also, I'll need to update emacs-telega package to include add-pkg- > file phase if the patch will be merged, so I'll cleanup the other > stuff around it. Very well, you do you. I'll leave the final call to Nicolas then. Thanks for your work and happy hacking :)