From: Simon Tournier <zimon.toutoune@gmail.com>
To: 71697@debbugs.gnu.org
Cc: "Simon Tournier" <zimon.toutoune@gmail.com>,
"Christopher Baines" <guix@cbaines.net>,
"Florian Pelz" <pelzflorian@pelzflorian.de>,
"Josselin Poiret" <dev@jpoiret.xyz>,
"Ludovic Courtès" <ludo@gnu.org>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Matthew Trzcinski" <matt@excalamus.com>,
"Maxim Cournoyer" <maxim.cournoyer@gmail.com>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Tobias Geerinckx-Rice" <me@tobias.gr>
Subject: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers.
Date: Sat, 22 Jun 2024 17:27:08 +0200 [thread overview]
Message-ID: <ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@gmail.com> (raw)
In-Reply-To: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@gmail.com>
* guix/scripts/lint.scm (exclude-package-checkers): New procedure, filter the
checker if the package is marked.
(guix-lint)[show-package-checkers]: New procedure.
* doc/guix.texi: Document it.
Change-Id: Idf8e5c67102a1701ebd917bbc6212cfeb6ea2054
---
doc/guix.texi | 17 ++++++++++++++++-
guix/scripts/lint.scm | 26 +++++++++++++++++++++++++-
2 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 037b1a2f24..1baf3fafe6 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -71,7 +71,7 @@
Copyright @copyright{} 2019 Alex Griffin@*
Copyright @copyright{} 2019, 2020, 2021, 2022 Guillaume Le Vaillant@*
Copyright @copyright{} 2020 Liliana Marie Prikler@*
-Copyright @copyright{} 2019, 2020, 2021, 2022, 2023 Simon Tournier@*
+Copyright @copyright{} 2019, 2020, 2021, 2022, 2023, 2024 Simon Tournier@*
Copyright @copyright{} 2020 Wiktor Żelazny@*
Copyright @copyright{} 2020 Damien Cassou@*
Copyright @copyright{} 2020 Jakub Kądziołka@*
@@ -15444,6 +15444,21 @@ Invoking guix lint
to the new style.
@end table
+Sometimes it is not desired to run the same checker each time
+@command{guix lint} is invoked---e.g., because the checker takes time or
+to avoid to send again and again the same request for archiving.
+Instead of excluding the checker at the command-line via the option
+@code{--exclude}, the package might be marked to skip the checker by
+honoring the property in package definition, e.g.,
+
+@lisp
+(package
+ (name "python-scikit-learn")
+ ;; @dots{}
+ (properties '((lint-exclude-archival? . #t)
+ (lint-exclude-home-page? . #t))))
+@end lisp
+
The general syntax is:
@example
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index b98266c831..7aed467eae 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
-;;; Copyright © 2019, 2020 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2019, 2020, 2024 Simon Tournier <zimon.toutoune@gmail.com>
;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>
;;;
;;; This file is part of GNU Guix.
@@ -39,6 +39,7 @@ (define-module (guix scripts lint)
#:use-module (ice-9 format)
#:use-module (srfi srfi-1)
#:use-module (srfi srfi-37)
+ #:use-module (srfi srfi-26)
#:export (guix-lint
run-checkers))
@@ -59,6 +60,18 @@ (define (emit-warnings warnings)
name version message))))
warnings))
+(define (exclude-package-checkers package checkers)
+ "Filter the CHECKERS list using PACKAGE properties field."
+ (let ((properties (package-properties package)))
+ (filter (lambda (checker)
+ (not (assq-ref properties
+ ((compose string->symbol
+ (cut string-append "lint-exclude-" <> "?")
+ symbol->string
+ lint-checker-name)
+ checker))))
+ checkers)))
+
(define* (run-checkers package checkers #:key store)
"Run the given CHECKERS on PACKAGE."
(let ((tty? (isatty? (current-error-port))))
@@ -223,16 +236,27 @@ (define-command (guix-lint . args)
(proc store))
(proc #f)))
+ (define (show-package-checkers package checkers)
+ (format (current-error-port) "~a@~a checked by~{ ~a~}.~%"
+ (package-name package)
+ (package-version package)
+ (sort (map (compose symbol->string lint-checker-name)
+ (exclude-package-checkers
+ package checkers))
+ string<?)))
+
(call-maybe-with-store
(lambda (store)
(cond
((null? args)
(fold-packages (lambda (p r)
+ (show-package-checkers p checkers)
(when (not (assoc-ref opts 'dry-run?))
(run-checkers p checkers
#:store store))) '()))
(else
(for-each (lambda (package)
+ (show-package-checkers package checkers)
(when (not (assoc-ref opts 'dry-run?))
(run-checkers package checkers
#:store store)))
--
2.41.0
next prev parent reply other threads:[~2024-06-22 15:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 17:22 [bug#71697] [PATCH] guix: lint: Honor 'no-archival?' package property Simon Tournier
2024-06-21 18:33 ` [bug#71697] [PATCH v2] guix: scripts: lint: Honor package property to exclude chercker Simon Tournier
2024-06-21 21:09 ` Liliana Marie Prikler
2024-06-22 14:29 ` MSavoritias
2024-06-22 15:40 ` Simon Tournier
2024-06-24 8:21 ` MSavoritias
2024-06-22 15:27 ` [bug#71697] [PATCH v3 1/2] scripts: lint: Add 'dry-run' option Simon Tournier
2024-06-22 15:27 ` Simon Tournier [this message]
2024-06-23 23:51 ` [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers Maxim Cournoyer
2024-06-25 15:14 ` Ludovic Courtès
2024-06-25 17:14 ` Greg Hogan via Guix-patches
2024-06-26 8:24 ` Ricardo Wurmus
2024-06-26 19:28 ` Maxim Cournoyer
2024-06-27 16:38 ` Greg Hogan
2024-06-29 3:12 ` Maxim Cournoyer
2024-06-30 14:48 ` Dale Mellor
2024-07-01 20:44 ` Maxim Cournoyer
[not found] ` <72a5f3c9d0523b29ed99afd5a551b411f4c0e7f5.camel@rdmp.org>
2024-07-02 1:39 ` Maxim Cournoyer
2024-07-12 13:36 ` Simon Tournier
2024-07-05 7:40 ` Ludovic Courtès
2024-07-12 14:16 ` Simon Tournier
2024-07-25 15:19 ` Greg Hogan
2024-07-12 17:20 ` Simon Tournier
2024-06-23 23:54 ` [bug#71697] [PATCH v3 1/2] scripts: lint: Add 'dry-run' option Maxim Cournoyer
2024-07-12 17:22 ` [bug#71697] [PATCH v4 " Simon Tournier
2024-07-12 17:22 ` [bug#71697] [PATCH v4 2/2] scripts: lint: Honor package property to exclude checkers Simon Tournier
2024-07-18 9:19 ` [bug#71697] [PATCH v4 1/2] scripts: lint: Add 'dry-run' option Ludovic Courtès
2024-07-18 11:00 ` Simon Tournier
2024-07-19 18:27 ` [bug#71697] [PATCH v5 0/3] Add dry-run to guix lint Simon Tournier
2024-07-19 18:38 ` [bug#71697] [PATCH v5 1/3] scripts: lint: Add 'dry-run' option Simon Tournier
2024-07-26 2:06 ` Maxim Cournoyer
2024-07-19 18:38 ` [bug#71697] [PATCH v5 2/3] scripts: lint: Honor package property to exclude checkers Simon Tournier
2024-07-19 18:38 ` [bug#71697] [PATCH v5 3/3] scripts: lint: Add hint for checker typo Simon Tournier
2024-07-26 2:26 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebecdf22c17e3b4964a3fde0afb2651b3b10765e.1719069966.git.zimon.toutoune@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=71697@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=matt@excalamus.com \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=pelzflorian@pelzflorian.de \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.