[bug#55774] [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.

[bug#55774] [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.

[Wamm K. D]

* gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview, keybinder-3.0,
python-musicbrainzngs, and python-pyinotify for plugins to work.
---
 gnu/packages/music.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 554d70f266..afd7ff40cf 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
 ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -179,6 +180,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
@@ -6738,7 +6740,9 @@ (define-public quodlibet
            gst-plugins-ugly
            gstreamer
            gtk+
+           gtksourceview ; undo, redo, multiline text fields
            hicolor-icon-theme
+           keybinder-3.0 ; keybindings outside of GNOME
            librsvg
            libsoup-minimal-2
            python
@@ -6747,9 +6751,11 @@ (define-public quodlibet
            python-feedparser
            python-gst
            python-iniconfig
+           python-musicbrainzngs
            python-mutagen
            python-pycairo
            python-pygobject
+           python-pyinotify
            python-pytest
            python-sgmllib3k
            python-toml))
-- 
2.36.1

[bug#55774] [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.

[Liliana Marie Prikler]

Am Freitag, dem 03.06.2022 um 17:59 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview,
> keybinder-3.0, python-musicbrainzngs, and python-pyinotify for
> plugins to work.
Pushed with a slight change in the commit message.  

Thanks

bug#55774: [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.

[Liliana Marie Prikler]

Am Samstag, dem 04.06.2022 um 09:50 +0200 schrieb Liliana Marie
Prikler:
> Am Freitag, dem 03.06.2022 um 17:59 -0500 schrieb Wamm K. D:
> > * gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview,
> > keybinder-3.0, python-musicbrainzngs, and python-pyinotify for
> > plugins to work.
> Pushed with a slight change in the commit message.  
> 
> Thanks
Forgot to mark as done.

[bug#60294] [PATCH v2] gnu: Add libxapp.

[Wamm K. D]

* gnu/packages/cinnamon.scm (libxapp): New variable.
---
You were right about that copyright; /every/ file (which mentioned the
copyright) referenced regular LGPL other than the "copyright" file
under the "debian" directory, where it specified LGPL-3+.

 gnu/packages/cinnamon.scm | 76 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git a/gnu/packages/cinnamon.scm b/gnu/packages/cinnamon.scm
index fe33e797e4..1b5cd44f65 100644
--- a/gnu/packages/cinnamon.scm
+++ b/gnu/packages/cinnamon.scm
@@ -26,6 +26,7 @@ (define-module (gnu packages cinnamon)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
+  #:use-module (gnu packages admin)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
@@ -37,6 +38,81 @@ (define-module (gnu packages cinnamon)
   #:use-module (gnu packages python)
   #:use-module (gnu packages xorg))
 
+(define-public libxapp
+  (package
+    (name "libxapp")
+    (version "2.4.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/linuxmint/xapp/")
+                    (commit version)))
+              (sha256
+               (base32
+                "0cy9g0zqcbx9zscc9qavqmghfyfb8244cg299llv1ha8n6mpxl3s"))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:modules
+      `((guix build meson-build-system)
+        (guix build utils)
+        ((guix build python-build-system) #:prefix python:))
+      #:imported-modules
+      `(,@%meson-build-system-modules
+        (guix build python-build-system))
+      #:configure-flags
+      #~(list (string-append
+               "-Dpy-overrides-dir="
+               (python:site-packages %build-inputs %outputs) "/gi/overrides"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'configure 'set-gtk-module-path
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (substitute* "libxapp/meson.build"
+                (("gtk3_dep\\.get_pkgconfig_variable[(]'libdir'[)]")
+                 (string-append "'" (assoc-ref outputs "out") "/lib'")))
+
+              (substitute* "scripts/pastebin"
+                (("'nc'") (string-append "'"
+                                         (search-input-file inputs "/bin/nc")
+                                         "'")))
+
+              (substitute* "scripts/upload-system-info"
+                (("'inxi'") (string-append "'"
+                                           (search-input-file inputs "/bin/inxi")
+                                           "'"))
+                (("'/usr/bin/pastebin'") (string-append "'"
+                                                        (assoc-ref outputs "out")
+                                                        "/bin/pastebin'"))
+                (("'xdg-open'") (string-append "'"
+                                               (search-input-file inputs "/bin/xdg-open")
+                                               "'"))))))))
+    (inputs
+     (list dbus
+           glib ; for gio
+           gtk+
+           inxi-minimal ; used by upload-system-info
+           libdbusmenu
+           libgnomekbd
+           netcat ; used by pastebin
+           xdg-utils ; used by upload-system-info
+           ))
+    (native-inputs
+     (list gettext-minimal
+           `(,glib "bin") ; for glib-mkenums
+           gobject-introspection
+           pkg-config
+           python
+           python-pygobject
+           vala))
+    (home-page "https://github.com/linuxmint/xapp")
+    (synopsis "Library for traditional GTK applications")
+    (description
+     "The libxapp package contains the components which are common to multiple
+GTK desktop environments (Cinnamon, MATE and Xfce) and required to implement
+cross-DE solutions.")
+    (license license:lgpl3+)))
+
 (define-public cinnamon-desktop
   (package
     (name "cinnamon-desktop")
-- 
2.38.1

[bug#60294] [PATCH v2] gnu: Add libxapp.

[Jaft]

Just wanted to double check if the changes I made fixed previous problems that were brought up with the first patch.

[bug#60294] [PATCH v2] gnu: Add libxapp.

[Liliana Marie Prikler]

Hi,

Am Donnerstag, dem 19.01.2023 um 16:06 +0000 schrieb Jaft:
> Just wanted to double check if the changes I made fixed previous
> problems that were brought up with the first patch.
Sorry, this flew under the radar.  Your v2 still had some minor errors,
but I have a local version that works and will be pushed with my next
batch on Sunday.

Cheers

[bug#60294] [PATCH v2] gnu: Add libxapp.

[Jaft]

Awesome; thanks so much, Liliana!

bug#60294: [PATCH v2] gnu: Add libxapp.

[Liliana Marie Prikler]

Am Freitag, dem 20.01.2023 um 05:50 +0000 schrieb Jaft:
> Awesome; thanks so much, Liliana!
Pushed now.

Cheers