[bug#59747] [PATCH] services: configuration: rework alist? procedure

[bug#59747] [PATCH] services: configuration: rework alist? procedure

[mirai]

From: Bruno Victal <mirai@makinata.eu>

* gnu/services/configuration.scm: rework alist? procedure
---
 gnu/services/configuration.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index dacfc52ba9..5bbb032c66 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -436,7 +436,11 @@ (define (list-of pred?)
 (define list-of-strings?
   (list-of string?))
 
-(define alist? list?)
+(define alist?
+  (match-lambda
+    (() #t)
+    ((and (= car head) (= cdr tail)) (and (pair? head) (alist? tail)))
+    (_ #f)))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 748ec628826cea3faa3679074d87fae9bc810080
-- 
2.38.1

bug#59747: [PATCH] services: configuration: rework alist? procedure

[Ludovic Courtès]

mirai@makinata.eu skribis:

> From: Bruno Victal <mirai@makinata.eu>
>
> * gnu/services/configuration.scm: rework alist? procedure

I simplified it a bit and applied.

Note that there are two other ‘*-alist?’ procedures…

But really, it’s the kind of predicate that shouldn’t be used because
there’s no disjoint alist data type in the first place.  It may be a
sign that we should use records instead in those places.

Thanks,
Ludo’.

[bug#59747] [PATCH v2] services: configuration: rework alist? procedure

[mirai]

From: Bruno Victal <mirai@makinata.eu>

* gnu/services/configuration.scm: rework alist? procedure
---
 gnu/services/configuration.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 2b3bd4c1f4..e0a5bd6728 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -436,7 +436,8 @@ (define (list-of pred?)
 (define list-of-strings?
   (list-of string?))
 
-(define alist? list?)
+(define alist?
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: fc774ece918d765f871d2fd079e622188e23f2da
-- 
2.38.1

[bug#59747] [PATCH] services: configuration: simplify alist? procedure.

[Bruno Victal]

* gnu/services/configuration.scm (alist?): simplify procedure.
---
 gnu/services/configuration.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 6b0291dc00..d4d9c3b1a6 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -437,10 +437,7 @@ (define list-of-strings?
   (list-of string?))
 
 (define alist?
-  (match-lambda
-    (() #t)
-    ((head . tail) (and (pair? head) (alist? tail)))
-    (_ #f)))
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 0d713e0140f4c4a80de6cbfc58fae17cb69beb98
-- 
2.38.1

[bug#59747] [PATCH v3] services: configuration: simplify alist? procedure.

[Bruno Victal]

* gnu/services/configuration.scm (alist?): simplify procedure.
---

Last patch was sent without prefix.

 gnu/services/configuration.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 6b0291dc00..d4d9c3b1a6 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -437,10 +437,7 @@ (define list-of-strings?
   (list-of string?))
 
 (define alist?
-  (match-lambda
-    (() #t)
-    ((head . tail) (and (pair? head) (alist? tail)))
-    (_ #f)))
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 0d713e0140f4c4a80de6cbfc58fae17cb69beb98
-- 
2.38.1

[bug#59747] [PATCH v3] services: configuration: simplify alist? procedure.

[Bruno Victal]

bump

bug#59747: [PATCH] services: configuration: rework alist? procedure

[Maxim Cournoyer]

Hi,

Bruno Victal <mirai@makinata.eu> writes:

> * gnu/services/configuration.scm (alist?): simplify procedure.
> ---
>
> Last patch was sent without prefix.
>
>  gnu/services/configuration.scm | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
> index 6b0291dc00..d4d9c3b1a6 100644
> --- a/gnu/services/configuration.scm
> +++ b/gnu/services/configuration.scm
> @@ -437,10 +437,7 @@ (define list-of-strings?
>    (list-of string?))
>  
>  (define alist?
> -  (match-lambda
> -    (() #t)
> -    ((head . tail) (and (pair? head) (alist? tail)))
> -    (_ #f)))
> +  (list-of pair?))

Applied, thanks!

-- 
Thanks,
Maxim