From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5GxT-0001BN-Kb for guix-patches@gnu.org; Mon, 01 May 2017 15:26:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5GxO-00046T-Jw for guix-patches@gnu.org; Mon, 01 May 2017 15:26:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5GxO-00046C-GY for guix-patches@gnu.org; Mon, 01 May 2017 15:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5GxO-0001SC-8e for guix-patches@gnu.org; Mon, 01 May 2017 15:26:02 -0400 Subject: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. Resent-Message-ID: References: <20170430214415.3029-1-mail@cbaines.net> <87inlkhby9.fsf@fastmail.com> From: Christopher Baines Message-ID: Date: Mon, 1 May 2017 20:25:08 +0100 MIME-Version: 1.0 In-Reply-To: <87inlkhby9.fsf@fastmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0JA3XDj9p930NJ7O72MIRSgInEQwm2Taj" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 26722@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0JA3XDj9p930NJ7O72MIRSgInEQwm2Taj Content-Type: multipart/mixed; boundary="mjBSujNxVLQ84gLB8tdm3jadK5HfKl3Ts"; protected-headers="v1" From: Christopher Baines To: Marius Bakke , 26722@debbugs.gnu.org Message-ID: Subject: Re: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. References: <20170430214415.3029-1-mail@cbaines.net> <87inlkhby9.fsf@fastmail.com> In-Reply-To: <87inlkhby9.fsf@fastmail.com> --mjBSujNxVLQ84gLB8tdm3jadK5HfKl3Ts Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 01/05/17 15:46, Marius Bakke wrote: > Hello Chris! >=20 > Christopher Baines writes: >=20 >> * gnu/packages/python.scm (python-sockjs-tornado): New variable. >=20 > [...] >=20 >> +(define-public python-sockjs-tornado >> + (package >> + (name "python-sockjs-tornado") >> + (version "1.0.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://pypi.python.org/packages/source/" >> + "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz")) >=20 > Please use 'pypi-uri' here. >=20 >> + (sha256 >> + (base32 >> + "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd")))) >> + (build-system python-build-system) >> + (inputs >> + `(("python-tornado" ,python-tornado))) >=20 > Python does not have a good mechanism for specifying exact versions of > runtime dependencies, so they should normally be propagated. If the > package does not import this at runtime (e.g. only needed for tests) it= > should be a 'native-input'. >=20 > LGTM with those changes. Thanks for the review Marius, I've now sent some updated patches. --mjBSujNxVLQ84gLB8tdm3jadK5HfKl3Ts-- --0JA3XDj9p930NJ7O72MIRSgInEQwm2Taj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlkHi5QRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeJ6w//W4DKikxYuEoitRtZztfUKcEGEtTIEKc9 x++A/dRXd94b38m+BrUy4ClYGD2Tdza0gJ6ZubSbLWg8KZ5yuXhsyJtUvIqeH8Xl QwKjFdv3N1oK6j6ndRZqZkx5EHeNOFG22j7SrCXCykV1KOF8sBDPgU4wyGUO0dL6 yJlyV5fEX51wtJeEppG45XPEigDPc0SMwT/tjTJ/JNOe/JirdsbmPO3CS6Z0L1Lj oWOaDK702kq8lojNiX4jCJDKDBuvg3LCVPnjuyndAbu/WGjMfdmqFpXVLjgwQydh M/R9ASX5IRjvhow1v2Jk18Z5CzDVYujkbjAUrlEoezUfzNtJzv/TlLYCCT3nn/gJ Wi56rbSwsvouQSP57DYVkKEHDh+GjFFinquvwsqC1+rhq8peptyzc+L/CpaHJT58 PwoMITe7wC38Tvb2Pa/szOwbM1NBe8g35yivTPgHgGja8dwvef4KBH19+i0SiE9m qDs7iXGoLlwWXko8UGbdMUcmOf5n0ynuJjvM0jNmkMsnvEdQqmDqKym7qawVPPd+ DXx/yiYB3hB/4DPB3NOdJGUeYCPcvLk+p23ToLFDehtWMMKmCrzzXUn7BUDPeF9F krMbzIwxCR1imW+yOLAAB7HSW6gUc9vckI67rA1j4Ykgc0LBUM1WVcq7lOkEjDiq fJqDN4zfl5U= =9qsj -----END PGP SIGNATURE----- --0JA3XDj9p930NJ7O72MIRSgInEQwm2Taj--