From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kHG1IIPjFWEPsAAAgWs5BA (envelope-from ) for ; Fri, 13 Aug 2021 05:14:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GCp0HIPjFWGNHwAA1q6Kng (envelope-from ) for ; Fri, 13 Aug 2021 03:14:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 316441CF5C for ; Fri, 13 Aug 2021 05:14:11 +0200 (CEST) Received: from localhost ([::1]:50480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mENe6-000402-8c for larch@yhetil.org; Thu, 12 Aug 2021 23:14:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mENdy-0003wn-MC for guix-patches@gnu.org; Thu, 12 Aug 2021 23:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mENdy-0005LS-Fu for guix-patches@gnu.org; Thu, 12 Aug 2021 23:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mENdy-0001nl-Bj for guix-patches@gnu.org; Thu, 12 Aug 2021 23:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50035] [PATCH 3/3] gnu: go-github-com-godbus-dbus-v5: Fix and enable tests. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Aug 2021 03:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50035 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50035@debbugs.gnu.org Received: via spool by 50035-submit@debbugs.gnu.org id=B50035.16288243966846 (code B ref 50035); Fri, 13 Aug 2021 03:14:02 +0000 Received: (at 50035) by debbugs.gnu.org; 13 Aug 2021 03:13:16 +0000 Received: from localhost ([127.0.0.1]:40178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mENdA-0001mB-Nj for submit@debbugs.gnu.org; Thu, 12 Aug 2021 23:13:16 -0400 Received: from out1.migadu.com ([91.121.223.63]:15517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mENd1-0001lp-Rv for 50035@debbugs.gnu.org; Thu, 12 Aug 2021 23:13:07 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628824383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cCtFxbZgYHMwPEBib9YeWnfgoQ+LAdhvDLLlCaBRN0o=; b=Ze+34eBgYhh3IacKxKT3ZroAwv8qekX1pUYT5n8uNrSVM4FCj8c9p1qxCuYVxwh/Q5n/QY JO04o1mi8k3gHlRT4emMCe850FcZZh8bTS9u7RyE/EQb9dhXXHrQR5GFsDFY+WHFuLrzRy 1H1B3Nyi1dQayFb7RNqxaoho4pXZ2QU= From: Sarah Morgensen Date: Thu, 12 Aug 2021 20:12:59 -0700 Message-Id: In-Reply-To: <5d1fcc896c0f6f63e1664f0eadabf73f0965110b.1628823527.git.iskarian@mgsn.dev> References: <5d1fcc896c0f6f63e1664f0eadabf73f0965110b.1628823527.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628824451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cCtFxbZgYHMwPEBib9YeWnfgoQ+LAdhvDLLlCaBRN0o=; b=mkstyzG0AiwbtFG82oSSYJ43F0qcNdHSY97HDG7WOAO9BI7IiJfGpndTn6KP/ejESkIepU 4HaU3com12Pa7sRjPq4QNMaYF4cTsv36IBUmEg1ZG1UVdI9kbM3zdDGiZHmwPmlRTt0pOI 85ceAGmkPRZfwDS0XpxiK/JAW98cE+DSui1Tzc7cC8CyBnOrH6Cq2gSK/+IBLjYrbyN9xC IUYzj5+Wfo9YgNMLNl3l52TjlbGB6rgajDwAGB1RWGB/6op1Xil6tWHMRUxE4g9luKD0uS 9OdCah0RuBiT7Rn9k9uQluVI5j+VkRvt1CqZtXz/HQRHLwTK/I5ABIJnUc1/0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628824451; a=rsa-sha256; cv=none; b=VEzB5xhxaAfYW/ipUwte3rbstFjWd/CPuV8kDoqlpbJjK3UKbhenPm/d/qqikAI7axw5Ll U6ZAWVK9qaEsMrvKRGUxIpfihzcPxRFWEF4no8g2UplP84oxscb48mzGVhFB8EtWQCgrhb GAMAurxG2PU3Lab8GVVwB3qe+6EyxFTWFdM3C+IlpjE6hYA8lKI21uHlaWw4IjwMRB7opD lq++LKSRoIivEYPEPUly/zv5REgGQNpFoI7uShZFJukws/rCGnJ6FqJsSTsiqy0KEW4y8d QUUlay/U21nAf34OOZ6BZjiJKNyBRzaXLKR6zHpkECe4CP6s3gaW4n4fEuG+gw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Ze+34eBg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 3.69 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=Ze+34eBg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 316441CF5C X-Spam-Score: 3.69 X-Migadu-Scanner: scn0.migadu.com X-TUID: Hjq/UXFYtNZN Disable system D-Bus tests. Fix session D-Bus tests by running them within our own session. * gnu/packages/golang.scm (go-github-com-godbus-dbus-v5)[source]: Add snippet to disable system D-Bus tests. [arguments]: Enable tests, override 'check phase to run tests within a dbus session. --- gnu/packages/golang.scm | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 359c5a987d..28ead635f2 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -7431,13 +7431,27 @@ and @code{ioutil} packages that is easy to test.") (url "https://github.com/godbus/dbus") (commit (string-append "v" version)))) (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet + '(begin + ;; Disable tests which require a system D-Bus instance. + (substitute* "conn_test.go" + (("func TestSystemBus") + "func DisabledTestSystemBus") + (("func TestConnectSystemBus") + "func DisabledTestConnectSystemBus")))) (sha256 (base32 "0znax8kskb5gmp5fj75w56bc9p7b22wrdswzlh4d04sprlc471yi")))) (build-system go-build-system) (arguments - `(#:tests? #f ;no /var/run/dbus/system_bus_socket - #:import-path "github.com/godbus/dbus")) + `(#:import-path "github.com/godbus/dbus" + #:phases + (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? import-path #:allow-other-keys) + (when tests? + (invoke "dbus-run-session" "--" "go" "test" import-path))))))) (native-inputs `(("dbus" ,dbus))) ;dbus-launch (home-page "https://github.com/godbus/dbus/") -- 2.31.1