From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oPZ8GSJ1MmdTPQAA62LTzQ:P1 (envelope-from ) for ; Mon, 11 Nov 2024 21:20:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oPZ8GSJ1MmdTPQAA62LTzQ (envelope-from ) for ; Mon, 11 Nov 2024 22:20:34 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=dgg7UhuN; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=nVIoRL+k; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731360034; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=tP9KqCtUlCf1LXKHV49dIIUaiRyz7Yj9p4DgRKbMA5k=; b=KH7i1NRkH+pZz+WEVxyGD7YS7jc9Wmmgp5lF+pSCurNE5+DMykjT6DqHZ3uSYy4/0ooT2l CU7r9vO2cjBJWof/d4rWOCJ3+lUXjrLrGIJrDx9jX9pNjh+JdOnDuk62AUna1FVOU1gDI7 t7PkJdkJ56AbSvxQo9HkAvuRN3gAq6gcuN/AZeef18nwLldVjDaslhe41f1jaCcNdTsjWX iBTRZ7USw0ON7xcQc0LzHvT4RKQtXxzZogAkn3NcbURP0UNxLrf7OfGMO93YFO+HBC/8c6 Khbf3aXV3U9XRpOxiidrJiGUbLHlGWhQCmWEY20KvPTfWBvRXZ6RdmmaS2CDQw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731360034; a=rsa-sha256; cv=none; b=m7xuj8yLbGJazXYwezAxpnRvu8IPDYnwx+1AUa9IlMIMLEa5naVpIxez4O/KSKgY7x03La X/b39TqK8lT0Vw7fgw/s9uQ+d2NlnSY5wQvUJrY3UG8xpul0GUc9OWCReZElicYcsUmfuK Xo3INohsHGn0q3mUJsrTGoWmowuFPdX6DUTtXll0pkJCivegKpw6plFtKvckDY6x7erYaK L5I2pBWpQqBIwWm5dlX2sZzWORmrg/lobCPWlRdEzdOtR+T08ZYO+iiu+hgHRL6ExtueFy e7RgqpRmfChmEI7rVZBE1vq4EtqM2MjX1H4bYReS0gGhQU1T0wNzxE7B7ZlMJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=dgg7UhuN; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=nVIoRL+k; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0478E19D3 for ; Mon, 11 Nov 2024 22:20:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAbpO-0006D9-Nf; Mon, 11 Nov 2024 16:20:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAbpL-0006BT-Vi for guix-patches@gnu.org; Mon, 11 Nov 2024 16:20:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAbpL-0007xu-Mn for guix-patches@gnu.org; Mon, 11 Nov 2024 16:20:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=tP9KqCtUlCf1LXKHV49dIIUaiRyz7Yj9p4DgRKbMA5k=; b=dgg7UhuNwfStpPWSkhEhh4sAuMOXoMFqLwK3Q3dD8R//mJMC5+Qz7nPl9yfn1bhxr5J7WTqypuBR/iVbCP+Aot35go75jNqCqah8hxFhsp0ECsu9us45VmE4CPAbFirbo2fGCHxs0ujGCFamBYKk6f5aUHUvGWMTiLjxzEykhY9EucwT/vrngAt05ca0kKeYvTTBGs/GXTDA1Rk58a5DCXuhXcgT3dWfPFZCTqbTRMKCIzDz8JwQJTgHrSi3+/FgszuZaNEj5HPzGPVRhGOb1/nY+RJKlSsFchenT1L8dlRgC64ZogrciXjmCvmq4vWnyB154JMj3EzN85Ic/oGVHA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAbpK-0004dt-H7 for guix-patches@gnu.org; Mon, 11 Nov 2024 16:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74251] [PATCH] Adding jack-mixer audio package Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Nov 2024 21:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74251 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Divya Ranjan Cc: 74251@debbugs.gnu.org Received: via spool by 74251-submit@debbugs.gnu.org id=B74251.173135998717816 (code B ref 74251); Mon, 11 Nov 2024 21:20:02 +0000 Received: (at 74251) by debbugs.gnu.org; 11 Nov 2024 21:19:47 +0000 Received: from localhost ([127.0.0.1]:59450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAbp5-0004dI-8r for submit@debbugs.gnu.org; Mon, 11 Nov 2024 16:19:47 -0500 Received: from dane.soverin.net ([185.233.34.30]:55877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAbp2-0004d2-80 for 74251@debbugs.gnu.org; Mon, 11 Nov 2024 16:19:45 -0500 Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4XnMqb29grz2xFT; Mon, 11 Nov 2024 21:19:07 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net (Postfix) with ESMTPSA id 4XnMqZ5NnpzPn; Mon, 11 Nov 2024 21:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=soverin1; t=1731359947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tP9KqCtUlCf1LXKHV49dIIUaiRyz7Yj9p4DgRKbMA5k=; b=nVIoRL+kZm13RWZhDQ1dG45Aau7gVugA8OZKSJ/ccsSultxVoiOk2VXFzY+8lEGjhzDFtS NHMHNq+DZft0keALSUdEW1nk/8QZhED0G5fkVbhm+cXL2VnWvWXzr4omwFmDHAU4QydPiy FB0/T7zJ7Mn4QJeuMXjI0L91BD+tNJUzKM908nXGFYBghQ7Li7vmTAA7t2P4pYCUZ/z0+h eqyPObqnZsjcWZRnOgBgpIWF8YexmBiKD8exAy0MUsXSchfgYTbUrRvKtoGK6qR2+IMR/5 e/+P9ZNrfbgitr0pk7hSm2b8pIkB/vNpfKmaJpGD/eUpf00BEk5aNCV2t6vwBA== Message-ID: Date: Mon, 11 Nov 2024 22:19:06 +0100 MIME-Version: 1.0 References: <87r07ibmcs.fsf@subvertising.org> <4258e857-4d68-4692-81c4-099fb4adc1fe@elenq.tech> <87jzd9zqv5.fsf@subvertising.org> <51729a6a-e1f9-48e6-814a-b1a28f0558df@elenq.tech> <875xotzhdx.fsf@subvertising.org> Content-Language: en-US, es-ES, eu From: Ekaitz Zarraga Autocrypt: addr=ekaitz@elenq.tech; keydata= xsFNBGcvh/QBEACePF16wEeQaqfJNgeaSQB6ty6PzLaYtl8UVApPSCF1PYNEhDtxQOOpBXeu k6h68cjhRX7hmug8mAraXotw4aG4Z3kbUro4fzXOYW3rCi/mAm5NFXLUmBX3E1AV1pcD8hDA 5s3LeGzfTo4xRGTW4zTzxGEyrvbChkVib7wTSk52a/WkFas6l3sXnepF8HmIEOWkwQcYdcuo gaNDFP1kjZYvqfKJXmCZnY+lC8Zfe/vlD/x8FZQYBQ5xgXIfbSR0xlRz/XIHfJv6j+3myUUr 2UKMku1dkjlkhNkyfw+RypQzmbJ0oJ4bk76/ju0nnlN65/LvyeTVUh/2O2VnPnZ49keL8sqr APXF4di4pWT+/mPxfoEtiSDtjyzbr8+ajcwLa4SSKLlexqjZj8X6R4tt31Rf/Pliwe4TdPmd 2leE3BIJl9bAuslEvd5tqZ1oa3Zfb62tvpaJCRYMtOEWuGkYdyrwTW7UXJPQpam4X7WoW2jW c5aTpAnpnqIPzaWJmua1lGQjEXgt4xvVdhVmZq32fkTy/rXw9l5a+XU7N4/Zz8AR/0xO+UBc Q1J+wHADjL8Q0v0tZLEaiWL72AsxN3GMWNPXWAplaTPUNPUlNK0JPHwhTX/cQVkIc9avSKc3 BeUofC96d13I7QmRjQ0gcBaLtV9lMOuYwbC+6tb70x2fQsI3bwARAQABzSJFa2FpdHogWmFy cmFnYSA8ZWthaXR6QGVsZW5xLnRlY2g+wsGUBBMBCAA+FiEEXb4j05BTZSZ/jMdq/blSvT9z VtYFAmcvh/QCGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ/blSvT9zVtbW CRAAkbla35s8RKhQBweqwEcdYDV2Zpt16OgENymjLs/qhh7Y9WgWZ0YraSNYDGCt6lemhior vrXX48+yZC98c8ZgCrr4Hmt8i/6TvJqVhwlZ9//3W/z/YuYDtUPBzRHgwM8tejiXmNqYM8lF Jg64pQaczmGAR29Xf0WTQegSociBSUg9eC7BS74Uh7UbHCgytyretoKmqJAp8SKE/Czt5x4R lXKVgGawzg1GerriwnNbudy0eyl1q0Pn7Q+K+tQ14EPDAM+QsGR/fBV4a3uYP6sBF+SdM+DO LX5MRVbWJ8O3kLmbAKQeLgSLlnYydMY/mTvjgxMAakfGCA4q69gmyDSB0fzAUm3c1JV5VwIo 63rykiOEB/k2m4aiiujH5kOC86sjb273+XXWlOhOEO/vKHHdAh+B7dnEEYUPXnUEMQ23PaF4 22u7C62kw3yH/krKr60t5FxcqNWtCOxEWc0WMZw12Q3Gw8+9oA5DI/f4gjlGvQiQWqj6dvoX vIDmifr0R3sTi6xh+udu2Rp8PsKOW8ZRyQ0/VOiwzBfQkf4PFowaiRp8LnkjLEVft6ruuA1h awO2SKKJ8WpgZPw5oMigZR5DgbunxMD4BcqmD7bSoTRV/ljx1I8UgAaQLPqVVnLt31iENtLv 43kPHl56AbYpAzcvf8nGU3KPhGOoByyuyph4RYDOwU0EZy+H9AEQANc9vw7DnBeNGKhq1Bg5 oiGII7npGXCChe7PB6CJjkvN6n1kXrvBYsaORXvZJPNgmBTKu/ETGYS0t0YeGlI4WTOK9dgB /7T8dngRmrGjPmZjryzfk18tXnJq0zoLixLizDT3FqV4jOG5KjPTxQvpdBMiX9oX4Je2OMqF d14fopLGav0rW7Fh5p83OSREpXbJUJJiUaH3p9U9Ss8IBHzr669PViAqe09EfxL/L0l1JIFj HQjJcg01PUXZAW6aPtd7q6eNCSLTXYPiDRQe2GdRUcB7WfqCogR/LEpzLLcd0NkxCnc0T6da rq2Dupt8rvQ95L4/cOGVcDUDOGE6U92XCkaCvUQkypxQCGKSEjbTFoLRG/4JQj0pAWSaqxPS 7hkTFql4qUAdRwzHN1ib6XedcFfqHSy2Mk5ttW8DaBGKhCm7Mn6+4smXENHSuQxCqHlCQ2m+ 9ogpbxavNVfAblE/ucxyfyo6FlDbGHEG3Yu5296kUPT7PqZLiR3KetMPJfCLY2jVPio3t4tD s7Sj41sG5aIwEApb0Zoz3bPBt5O5GUoPFnXyjO306WLxXrM2tjY38jwHxF1Qvs3HQTJgRei2 g3D3KiiR27cXXs/8lrr8tblr5J1tE4TaQCea5lDuEgTCDLnlcopoYcKpFAUBGQtzcNkudT9w sM2nf9y6INcUE3FlABEBAAHCwXwEGAEIACYWIQRdviPTkFNlJn+Mx2r9uVK9P3NW1gUCZy+H 9AIbDAUJA8JnAAAKCRD9uVK9P3NW1td1D/4xx8AbDKAKx9ezT6GdTZbK6FS66qRQCEzTa5MX ZCEogASOla71CB10l5fFtsRWCtNQLzmgwkFwhdxyjqendDgacc5v/71NBb5KpKni6wDJMeiG s3Lq3ZgWfHte3NZ99iSH+La3aBSFbCloJ/Yf/MJBkzrm1sTTKcgF9/i0pzkume5vtpKRDjjS z4abHu7qk4Sgi5gwWpoKFTT38q6nLP+9SUla3JJjNqU3gvn8kwv6KDMKc4marnSp/c+5O6E+ lNrxMdD0n8+io/Bf/UEI6BU8F7JshPq732bHN1NzUXvgMd4cNsAlvsWM8UCKZ4/usFl1euMM FOvnadZinsTHpXhahJzkYWA7nAKbCoNNq9LPtWxfjHsIfhs+QQafF31Pw+jqHqruB4tH0eiL abrz7kejaZvJdVipNIzRUWYnpP+18khep2UtT1n9VNs6QNb4cHPsoe+s4ga4ZK/klCdEhLya XtbcaNEHb7NZUOBj3HhKFgIY8PD1AptAObHjsUNF5+jfEnl+5WjwyTZTIgDRiOrwn8LWOANQ 0JpR69t06uJwmiogQgnlYe36YFaauHGQZFa+L+R2zgnGn8TnR4C3tH7gNAef9+PKqgmJT5pN IkFzlDmZi05E9xzhj4WQ/OOsqU64eHL2PaDk+2TdfrzNwNFbkABJ+C7BHNAytQ6h9cpUbg== In-Reply-To: <875xotzhdx.fsf@subvertising.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.64 X-Spam-Score: -4.64 X-Migadu-Queue-Id: 0478E19D3 X-Migadu-Scanner: mx13.migadu.com X-TUID: rmzTI6BWEvH/ On 2024-11-11 20:42, Divya Ranjan wrote: > Ekaitz Zarraga writes: > >> Sorry mate I didn't explain it properly. >> >> The commit message has two parts: a title and a body. >> >> The title you used before was correct, you were only missing the >> body. This is how the whole commit message should look like: >> >> gnu: audio: Add jack-mixer >> >> * gnu/packages/audio.scm (jack-mixer): New variable. >> > > Okay, I think this is the final patch. > > > Regards, Yes, this is almost there but there are still a couple of warnings by `guix lint`: jack-mixer@19: the source file name should contain the package name This is complaining because when it clones the source code it is called "jack_mixer" but your package is called "jack-mixer" instead. You could fix it using something like this in the `origin`: (file-name (git-file-name name version)) If you add that and fix the indentation (you can use `guix style` for that), I think this is ready to go. You are almost there! PS: The other warning I think we can ignore for the moment. We have some other packages with the same warning I think it's because of the expansion of the `(,gtk+ "bin")