Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

[Ben Woodcroft]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hi Ricardo,


> -------- Forwarded Message --------
> Subject: 	16/35: gnu: r-ggplot2: Update to 2.2.0.
> Date: 	Thu, 29 Dec 2016 20:49:25 +0000 (UTC)
> From: 	Ricardo Wurmus <rekado@elephly.net>
> Reply-To: 	Ricardo Wurmus <rekado@elephly.net>
> To: 	guix-commits@gnu.org
>
>
>
> rekado pushed a commit to branch master
> in repository guix.
>
> commit ab01f1cdb11520f0d56249719bcf627cad802bc2
> Author: Ricardo Wurmus <rekado@elephly.net>
> Date:   Thu Dec 29 20:51:26 2016 +0100
>
>      gnu: r-ggplot2: Update to 2.2.0.
>      
>      * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0.
>      [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and
>      r-tibble.

Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately.

Perhaps this is a consequence of the updater suggesting some inputs can be removed?

Thanks, ben.


[-- Attachment #2: Type: text/html, Size: 2437 bytes --]

Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

[Ricardo Wurmus]

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

>> -------- Forwarded Message --------
>> Subject: 	16/35: gnu: r-ggplot2: Update to 2.2.0.
>> Date: 	Thu, 29 Dec 2016 20:49:25 +0000 (UTC)
>> From: 	Ricardo Wurmus <rekado@elephly.net>
>> Reply-To: 	Ricardo Wurmus <rekado@elephly.net>
>> To: 	guix-commits@gnu.org
>>
>>
>>
>> rekado pushed a commit to branch master
>> in repository guix.
>>
>> commit ab01f1cdb11520f0d56249719bcf627cad802bc2
>> Author: Ricardo Wurmus <rekado@elephly.net>
>> Date:   Thu Dec 29 20:51:26 2016 +0100
>>
>>      gnu: r-ggplot2: Update to 2.2.0.
>>
>>      * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0.
>>      [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and
>>      r-tibble.
>
> Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately.
>
> Perhaps this is a consequence of the updater suggesting some inputs can be removed?

It is.  My apologies!

“r-svglite” is optional and was reported by my modified updater, which
compares the current inputs with the inputs a fresh import would
suggest.  If optional inputs are added it would be good to comment on
why they were added.  I probably wouldn’t have removed them in that
case.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

[Ben Woodcroft]

On 23/01/17 18:57, Ricardo Wurmus wrote:
> Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
>
>>> -------- Forwarded Message --------
>>> Subject: 	16/35: gnu: r-ggplot2: Update to 2.2.0.
>>> Date: 	Thu, 29 Dec 2016 20:49:25 +0000 (UTC)
>>> From: 	Ricardo Wurmus <rekado@elephly.net>
>>> Reply-To: 	Ricardo Wurmus <rekado@elephly.net>
>>> To: 	guix-commits@gnu.org
>>>
>>>
>>>
>>> rekado pushed a commit to branch master
>>> in repository guix.
>>>
>>> commit ab01f1cdb11520f0d56249719bcf627cad802bc2
>>> Author: Ricardo Wurmus <rekado@elephly.net>
>>> Date:   Thu Dec 29 20:51:26 2016 +0100
>>>
>>>       gnu: r-ggplot2: Update to 2.2.0.
>>>
>>>       * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0.
>>>       [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and
>>>       r-tibble.
>> Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately.
>>
>> Perhaps this is a consequence of the updater suggesting some inputs can be removed?
> It is.  My apologies!
>
> “r-svglite” is optional and was reported by my modified updater, which
> compares the current inputs with the inputs a fresh import would
> suggest.  If optional inputs are added it would be good to comment on
> why they were added.  I probably wouldn’t have removed them in that
> case.

OK, np, pushed as e4b6c565beef27a1ce2203a9bc119e84a126e5e0.

I wonder if the importer could import the previous version again and 
compare to those, rather than just the current definition to avoid other 
situations like this.

ben

Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

[Ricardo Wurmus]

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

>> “r-svglite” is optional and was reported by my modified updater, which
>> compares the current inputs with the inputs a fresh import would
>> suggest.  If optional inputs are added it would be good to comment on
>> why they were added.  I probably wouldn’t have removed them in that
>> case.
>
> OK, np, pushed as e4b6c565beef27a1ce2203a9bc119e84a126e5e0.

Thanks!

> I wonder if the importer could import the previous version again and 
> compare to those, rather than just the current definition to avoid other 
> situations like this.

Would this have helped in this instance?  Did the previous version
*depend* on r-svglite?  If it did, how could an editor like me have
known that it was still valuable as an optional input?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0.

[Ben Woodcroft]

On 23/01/17 21:42, Ricardo Wurmus wrote:
> Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
> [..]
>> I wonder if the importer could import the previous version again and
>> compare to those, rather than just the current definition to avoid other
>> situations like this.
> Would this have helped in this instance?  Did the previous version
> *depend* on r-svglite?  If it did, how could an editor like me have
> known that it was still valuable as an optional input?

AIUI, it has always been optional. But I take your point anyway - a 
comment the first time would have been best.

ben