From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: "Mája Tomášek" <maya.tomasek@disroot.org>, 58569@debbugs.gnu.org
Subject: [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension
Date: Mon, 17 Oct 2022 10:18:08 +0200 [thread overview]
Message-ID: <e6c3ddc1e9bd689ef6c7fa1764278309e02a229a.camel@ist.tugraz.at> (raw)
In-Reply-To: <87sfjnad0i.fsf@disroot.org>
Am Sonntag, dem 16.10.2022 um 19:34 +0200 schrieb Mája Tomášek:
>
> Hi,
>
> this patch removes the gnome-console nautilus extension as it crashes
> nautilus (at least on my machine).
I can confirm it working as intended on at least two separate machines,
both configured
> In my opinion it is safe to remove it, as this
> feature is implemented directly into nautilus-43 and the original
> code is purged from the gnome-console repo. (see
> https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/911 and
> https://gitlab.gnome.org/GNOME/console/-/commit/c4bd2312f4b432a33810a8dcdf3cadabae5169d7
> )
>
> This sadly means, that in nautilus-42 there will be no "Open in
> Console", but the issue is on some code that is already deprecated in
> the Console repo. (I have studied gdb info and it appears that
> kgx_nautilus_get_background_items() returns a GList* that is { .next
> = NULL, .prev = NULL, .data = NULL } but nautilus does only perform a
> check that GList* is NULL, otherwise it expects a valid list)
>
> I can maybe supply a patch to gnome-console, but I don't see a reason
> to.
In my opinion, it'd be better to find out why it crashes in the first
place. See [1] for the breaking code. My suspicion is that item ends
up NULL, which would be big if true.
Cheers
[1]
https://gitlab.gnome.org/GNOME/console/-/blob/42.2/nautilus/kgx-nautilus.c#L48
next prev parent reply other threads:[~2022-10-17 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 17:34 [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension guix-patches--- via
2022-10-17 8:18 ` Liliana Marie Prikler [this message]
2022-10-17 16:20 ` guix-patches--- via
2022-10-18 6:19 ` Liliana Marie Prikler
2022-10-18 21:48 ` Dominic Martinez via Guix-patches via
2022-10-20 19:58 ` guix-patches--- via
2022-10-21 6:09 ` Liliana Marie Prikler
2022-10-24 21:54 ` guix-patches--- via
2022-10-25 5:59 ` Liliana Marie Prikler
2022-10-24 21:50 ` guix-patches--- via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c3ddc1e9bd689ef6c7fa1764278309e02a229a.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=58569@debbugs.gnu.org \
--cc=maya.tomasek@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.