From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sACnOWGFy2WQSQAAqHPOHw:P1 (envelope-from ) for ; Tue, 13 Feb 2024 16:06:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id sACnOWGFy2WQSQAAqHPOHw (envelope-from ) for ; Tue, 13 Feb 2024 16:06:10 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=e3FdapUn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707836769; a=rsa-sha256; cv=none; b=iiR8HDBJ5L2wBzXCoiXBi68FPwFc0hOHUo8F7/pcys0VnavoKgNkV/wjrEIiX3nnSDFKP6 v5r0HIR2my1m2h4ukZiJa93ATe1+Uu9zN5r8Jjp4APz9HmaGB/Hc+/+W3jSgGWyHPssXib yK1jjbRVlgyJQG+QRUnmfdhhZzd6C+h/YA5B4HWyocmVBULDt8UPKV3oUyTmjGKqCsYds6 HweihWQlCKkymbFDivNrqcowvf6PGizncsMJgal+qq3qYy/E3+3kmNcaUuiNWUMfw1OjGW i88DWKpfTcJ/WE7Hu6PqLl3tC+HtwE5XeA8GPAPV9UGoIMSZQpy718rSN6tyPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=e3FdapUn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707836769; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kLKecqFSTG8MJw3IECtP5Qngf1PgNMPAZj0AlEG9gug=; b=jt6mNTeEdGlnt1Tm1AV8nAeA4MN1ekMS4jXOepE6YUTF4sZvG/8AkVvbwY9jZkeoGhLhNF LGPc9+MrjwE1vKDJxUklWrGdvlmFmKvAvM555JMKchYaPeaqRq6RhdenXpADTs9n+QRfdp P7ckpOQVRpeJJia3WEqe0fycXOfRfQUbrpUT4MFzM81NAEWgfB6jsncpxwgrTFPCgX3UFo ihyrtTjvUa4nowFtoq/QPIwMklJ+xM8KvQyijX1MyJzQ+ci9B1wQJqYselIz/3TEflO2oM IkpKZvYNktdCuUiWzW36oNKTfMkKsMNVV4gb9xbI/D5et8h+3JM8SoTvkPRrrQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C48946FB02 for ; Tue, 13 Feb 2024 16:06:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZuM5-0003MS-9h; Tue, 13 Feb 2024 10:05:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZuM4-0003MK-5i for guix-patches@gnu.org; Tue, 13 Feb 2024 10:05:52 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZuLx-0005As-8c for guix-patches@gnu.org; Tue, 13 Feb 2024 10:05:51 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZuME-0001Mw-7m for guix-patches@gnu.org; Tue, 13 Feb 2024 10:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68412] [PATCH v2] scripts: edit: Accept generic formatting parameter. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Feb 2024 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68412 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 68412@debbugs.gnu.org Received: via spool by 68412-submit@debbugs.gnu.org id=B68412.17078367425231 (code B ref 68412); Tue, 13 Feb 2024 15:06:02 +0000 Received: (at 68412) by debbugs.gnu.org; 13 Feb 2024 15:05:42 +0000 Received: from localhost ([127.0.0.1]:45443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZuLt-0001MI-Sy for submit@debbugs.gnu.org; Tue, 13 Feb 2024 10:05:42 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:48468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZuLr-0001M4-NB for 68412@debbugs.gnu.org; Tue, 13 Feb 2024 10:05:40 -0500 Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-411bf7e5c6bso4830225e9.1 for <68412@debbugs.gnu.org>; Tue, 13 Feb 2024 07:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707836656; x=1708441456; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kLKecqFSTG8MJw3IECtP5Qngf1PgNMPAZj0AlEG9gug=; b=e3FdapUnhWtx9KKk1yvFgrZIPlrH6ogVdFOxqAwxAXZtQQTeEQeMOW3j6sTa7fOUfX jT+516w08t1pdM/DnFi8bHzle9/locp+ZvOqPBLEPZJzqhdMGVXAx8kwbAMic20hIMEC qrcdHCSU7bi0Qli++WSRzEUnvpkGVG/Joi1FygsYjZqJYRmQJoioIeAzIewvqR6hzuhv OsovZzupn0Fxw7XlxX3Fi8s//kw2QLensCv8MR7NgBjiX12CUt2b7J62bKnFz/Ha94C7 n+VOpgObeVoI5KkNW8GWtgNE9Pd0ZrrGFJifRX03Zc9+Fd64qnzAx4bPx4aOsug/fuSP x85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707836656; x=1708441456; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kLKecqFSTG8MJw3IECtP5Qngf1PgNMPAZj0AlEG9gug=; b=t4Gj5CDMXXqDPvhINyUsa7el8TTV1vZ1NmVuXe/PODrxHwfEMGLtFRvHGuWrN53VkL GvIdurFbekIwkxgUU2oddQ4WsQXEB2+Mjxid2eoptUzCeofaiQoqN6tyalx5q+TYYyLc UTMVWZw3wHwwVgogKi7gKF9lHTc4IWLXAMNAApH8yW7HrRnBPxOQIHbCDyG9tWbGYks4 4LYqM95LJv1n4c3havQo6/DtXZ/eVAVpULXPo2m1EUZLoGDFy1k+ItfNp1sG/vcIEf5l 8STLZcYddkHM8NyRNrYNTnar+yTbomU/Y0tloot5sgXw5yCKSo382Lu4bExvH5WLOns1 krpg== X-Gm-Message-State: AOJu0YxGhH+KtkSEwa0OZLzHTxyeeZ/f49oIHGu0KIsWSQY2+s+KwwCs lJpj+vuPLT2a5vfgaOkQpZHCB9OcTLRd11SBznVkxzttifRnTlR8 X-Google-Smtp-Source: AGHT+IHWt6e5ZdkzNj63i60BTKzHSwb6zSo2P7Vr5ne/iPztsP/KVeazZeS7EXGMhL45mfn+qWY0fw== X-Received: by 2002:a05:600c:45c7:b0:410:d3d9:91a1 with SMTP id s7-20020a05600c45c700b00410d3d991a1mr4115975wmo.10.1707836656155; Tue, 13 Feb 2024 07:04:16 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUk3H+jQOETv2OSr/eq+XNMnDk34jd9nxc9KLb/98LhXeASRVLNg6Uh6VtJBKYuTyVGa7nsf2XxyznIO8w= Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b10-20020a05600c4e0a00b00411d3a414c6sm406561wmq.47.2024.02.13.07.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 07:04:15 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 13 Feb 2024 16:04:14 +0100 In-Reply-To: References: <9a666abbf1cb4b7548c1a117eaa04b0de02145ae.1705103171.git.liliana.prikler@gmail.com> <86b13fd4916ffecb1947d0879805a6d0c32542bf.1706386650.git.liliana.prikler@gmail.com> <87v87ciedd.fsf@gmail.com> <8422a68ebc6545a4587232c404efcfee86337df3.camel@gmail.com> <87h6ij3of4.fsf@gnu.org> <15c08b6053676777c8457ff247b0ab214465cedc.camel@gmail.com> <87eddkk5do.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -5.38 X-Migadu-Queue-Id: C48946FB02 X-Migadu-Spam-Score: -5.38 X-TUID: Sar7YICInfMx Am Samstag, dem 10.02.2024 um 12:01 +0100 schrieb Simon Tournier: > Hi, >=20 > On Sat, 10 Feb 2024 at 10:58, Ludovic Court=C3=A8s wrote: >=20 > > Conventionally the submitter would push the patches past the final > > line. If you agree with the proposal, please go ahead; if you > > don=E2=80=99t, we can discuss it further, though I think the discussion > > should be proportional to the stakes.=C2=A0 (Personally I agree there= =E2=80=99s > > a risk of confusion like Simon noted but I=E2=80=99m fine either way.) >=20 > I agree with this paragraph. >=20 > 1. I think that the current placeholder can be confusing (quote vs > double-quote). Is this something we can fix by pointing out the single quotes, or is it better not to try that? > 2. The envisioned future feature with Gash is not clear for me.=C2=A0 So= =C2=A0 > I do not know what would be better. To make it a little clearer, we currently have more or less implementation-defined behaviour through calling system with a string- join'ed command. (This is not the best way of invoking an editor, but it works, and it also works with EDITORs like "emacsclient -c" if your shell is Bash =E2=80=93 which Guix System has by default.) If we were to p= ull in Gash, we could process the command line a priori and then use system* or invoke. > 3. I do not have a strong opinion and I can live with whatever choice > -- although I would live better if there is no confusion. ;-) >=20 > I propose {LINE} as placeholder because in case of #2 it would easy > to support both {LINE} and ${LINE} then reducing some backward > compatibilities issue. What would be the way forward if we use {LINE} now? Cheers