From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wJWuGQhv+GCARgEAgWs5BA (envelope-from ) for ; Wed, 21 Jul 2021 21:01:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OMhnFQhv+GAKWAAAbx9fmQ (envelope-from ) for ; Wed, 21 Jul 2021 19:01:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC0135B20 for ; Wed, 21 Jul 2021 21:01:27 +0200 (CEST) Received: from localhost ([::1]:51218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6HTD-0004dy-2m for larch@yhetil.org; Wed, 21 Jul 2021 15:01:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6HSo-0004de-8n for guix-patches@gnu.org; Wed, 21 Jul 2021 15:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6HSn-0007e3-Uq for guix-patches@gnu.org; Wed, 21 Jul 2021 15:01:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6HSn-0007yp-MY for guix-patches@gnu.org; Wed, 21 Jul 2021 15:01:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49685] [PATCH] gnu: Add task-spooler. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Jul 2021 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49685 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ivan Gankevich , 49685@debbugs.gnu.org Received: via spool by 49685-submit@debbugs.gnu.org id=B49685.162689404930650 (code B ref 49685); Wed, 21 Jul 2021 19:01:01 +0000 Received: (at 49685) by debbugs.gnu.org; 21 Jul 2021 19:00:49 +0000 Received: from localhost ([127.0.0.1]:38607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6HSb-0007yI-9V for submit@debbugs.gnu.org; Wed, 21 Jul 2021 15:00:49 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:39928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6HSY-0007y9-Jt for 49685@debbugs.gnu.org; Wed, 21 Jul 2021 15:00:47 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id Xv0k2500D0mfAB406v0kH0; Wed, 21 Jul 2021 21:00:44 +0200 Message-ID: From: Maxime Devos Date: Wed, 21 Jul 2021 21:00:26 +0200 In-Reply-To: <20210721183504.9388-1-i.gankevich@spbu.ru> References: <20210721183504.9388-1-i.gankevich@spbu.ru> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xixty6XcRO0UrIgtQFAX" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1626894045; bh=cObyyAcb2yWpzqPLv/D5CjTSRgszHgfS96TlkXBofoQ=; h=Subject:From:To:Date:In-Reply-To:References; b=maRZYbkISam79Dx+Y90/bo71zkyuosbXd254Zqy/EGaJlTlCSzhkDAybhAKKF23Ez nPj7g+L3EhoiBcl/bPG8enph5Ge3PR0XTCAulFdr51MFfjRD1ZeQp22TnpRyOXGYUb TBkbaB4ESJKSoT/TlUU8i0sUkzhoNpms30wtAtBanVjzW/FX186zTXWYxrDSWsSwQ5 KD/b8oPFOR1LTIHdlUQViiKLXSPfrRhbsEmXSjXOcN+wKQHbvAlynDa1xuCD7bpP4v ZmC1yvi6n9osZcHCNFsM2BepqcmWiJRT+rxQSeHk6QLKFj7wyJKI0J3mR6sqlM5gRW TPw8E5jdcpvkA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626894088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cObyyAcb2yWpzqPLv/D5CjTSRgszHgfS96TlkXBofoQ=; b=hUZJnGFkLEI4pRlW92HvtG51sHZsD6UZ3xnA7egJM+IiMMu1Njpg5cY0GSKn5McWbb7Kkd /FAuk8tP4/8wwEFAUsA7xoxgnvIeAYemVZTqaCSFZrrkkvUcYZD9rdDaRcBF23aDsPCFMa LyaevmNZ3uqaTH+AWiWPkwIeQCZb/xt5Tu7FGwO48lokvKfaoqkdmSGR6zfaHWJejqH19/ N56Z9upjUWRRyO2ZFixWFkhJqpTZGLgz6ZFAABZoufpS8pk9v5U8zrGAKrHbOeq2xBBWuL koboxVj7z5znalb5Rq0q0AbxcMJj7pw6fcr1rtRcQ4fjuwEdVc5MMz6HjUjyPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626894088; a=rsa-sha256; cv=none; b=HReJ+MLPwdSf+t3KXrqHwSjpOJQY34GSQvE/mHx559Ikl7gr6bTKj+v3BZ7bLjWuqHQNVZ DtnnT6aBGqLLgoo2f2l3XWOPLJqxtQTiFW+tD6Mp2VH7Sdz88pPL7nkoF3n1WcjfDdHrIS wxE0BLTp4o4b7SM1BWLH9AKJ2jqPA5QwmFiJ8q6JmAiiN+fnzau+7UI5W+orAMLFKnPQTf Dk3iyxm/iX04VOAU9cLoazJRZ4DAdpt87tnJn5UClPjy/aeEoLGgdJvVmh8Na9R5Hw500T 0E9O9VRQNuE9MvYhB4OQmCT+UEygm/O+lPWt4c0VTVchDCgL6UIeSBMI1x5fHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=maRZYbkI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=maRZYbkI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DC0135B20 X-Spam-Score: -3.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5me98qAScwaJ --=-xixty6XcRO0UrIgtQFAX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ivan Gankevich schreef op wo 21-07-2021 om 21:35 [+0300]: > +(define-public task-spooler > + (package > + (name "task-spooler") > + (version "1.0.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://vicerveza.homeunix.net/~viric/soft/ts/ts-" versi= on ".tar.gz")) > + (sha256 (base32 "0y32sm2i2jxs88c307h76449fynk75p9qfw1k11l5ixrn03= z67pl")))) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags > + (let ((c-flags "-g -O2")) > + (list (string-append "PREFIX=3D" (assoc-ref %outputs "out")) > + "CC=3Dgcc" This shoul be ,(string-append "CC=3D" (cc-for-target)), such that the cross= -compiler is used when cross-compililng. > + (string-append "CFLAGS=3D" c-flags) > + (string-append "LDFLAGS=3D" c-flags))) Why are you adding "-g -O2" to LDFLAGS? I understand adding it to CFLAGS, but I don't see why it would be added to CFLAGS. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ;; no configuration script > + (add-after 'unpack 'rename-and-patch-paths > + (lambda _ > + ;; Rename "ts" to "tsp" to not interfere with "ts" command > + ;; from moreutils package. > + (rename-file "ts.1" "tsp.1"); > + (substitute* '("Makefile" "testbench.sh") > + (("\\bts\\b") "tsp")) > + ;; Patch gzip/sendmail/shell paths. > + (substitute* "execute.c" > + (("execlp\\(\"gzip\"") (format #f "execlp(\"~a\"" (which= "gzip")))) This needs to be (search-input-file "bin/gzip") instead of (which "gzip") for cross-compilation purposes ('which' searches for a native "gzip" in $PA= TH) 'search-input-file' is not yet defined on 'master' (it's only on 'core-upda= tes' currently), so you could do something like (string-append (assoc-ref inputs "gzip") "/bin/gzip") > + (substitute* "list.c" > + (("/bin/sh\\b") (which "sh"))) Ditto (and you need to add "bash-minimal" to "inputs"). > + (substitute* "env.c" > + (("execlp\\(\"/bin/sh\"") (format #f "execlp(\"~a\"" (wh= ich "sh")))) Ditto. > + (substitute* "mail.c" > + (("execl\\(\"/usr/sbin/sendmail\"") > + (format #f "execl(\"~a/usr/sbin/sendmail\"" > + (assoc-ref %build-inputs "sendmail")))))) If you fix 'sendemail' to install things in "sbin" instead of "usr/sbin", then you can do (search-input-file inputs "bin/sendmail"). > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (setenv "PATH" (string-join (list (getenv "PATH") (getcw= d)) ":")) Greetings, Maxime. --=-xixty6XcRO0UrIgtQFAX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYPhuyhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lLVAQDttromNVh3RsKLN8QcOj2Fdsz+ C5q40UyLlG0NmyR59QEA1fhdVIZHkp5KJ+6t7NMpEEeoWksTg/v3EmOSGpbSugs= =R7c/ -----END PGP SIGNATURE----- --=-xixty6XcRO0UrIgtQFAX--