From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dfqIb-0000yn-SC
	for guix-patches@gnu.org; Thu, 10 Aug 2017 12:27:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dfqIY-0000in-JM
	for guix-patches@gnu.org; Thu, 10 Aug 2017 12:27:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46004)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dfqIY-0000hN-5n
	for guix-patches@gnu.org; Thu, 10 Aug 2017 12:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dfqIX-0005se-Pq
	for guix-patches@gnu.org; Thu, 10 Aug 2017 12:27:01 -0400
Subject: [bug#28020] [PATCH] gnu: Add emacs-gitpatch.
Resent-Message-ID: <handler.28020.D28020.150238241322590@debbugs.gnu.org>
Message-Id: <e5f48ef7.AEEAOmPO1jwAAAAAAAAAAAPejtMAAAACwQwAAAAAAAW9WABZjIlJ@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 10 Aug 2017 21:56:33 +0530
In-reply-to: <20170810120612.bi33kbdswgtktohr@abyayala>
References: <87wp6ekkef.fsf@gmail.com>
	<4b50a45a.ADkAACnAL5YAAAAAAAAAAAPejtMAAAACwQwAAAAAAAW9WABZjCOA@mailjet.com>
	<20170810120612.bi33kbdswgtktohr@abyayala>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: ng0 <ng0@infotropique.org>
Cc: 28020-done@debbugs.gnu.org


ng0 writes:

>     gnu: Add emacs-gitpatch.
>
>     By the way, “gitpatch.el” says different version than release tarball.
>     Do I need to ask a developer?
>     --8<---------------cut here---------------start------------->8---
>     ;; Author: Feng Shu <tumashu@163.com>
>     ;; Homepage: https://github.com/tumashu/gitpatch
>     ;; Keywords: convenience
>     ;; Package-Requires: ((emacs "24.3"))
>     ;; Version: 0.10
>     --8<---------------cut here---------------end--------------->8---
>
>     >From 9eddf07fa401468738c2f48a25e51ddef2a3ceed Mon Sep 17 00:00:00 2001
>     From: Oleg Pykhalov <go.wigust@gmail.com>
>     Date: Sat, 29 Jul 2017 14:22:48 +0300
>     Subject: [PATCH] gnu: Add emacs-gitpatch.
>
>     * gnu/packages/emacs.scm (emacs-gitpatch): New variable.
>
>     Signed-off-by: Arun Isaac <arunisaac@systemreboot.net>
>
> I appreciate the concerns, but
> I don't think the complete paragraph of "By the way…" should be in the
> commit message. Please place notes like this as "XXX: ..." or "TODO: ..."
> in the code if possible.
> Or is there any reason why this landed in the commit message?

Oops! I didn't notice it was there. Looks like I screwed up big time
while applying the patch. There's no way to change the commit message
now, is there?