From: Arun Isaac <arunisaac@systemreboot.net>
To: ng0 <ng0@infotropique.org>
Cc: 28020-done@debbugs.gnu.org
Subject: [bug#28020] [PATCH] gnu: Add emacs-gitpatch.
Date: Thu, 10 Aug 2017 21:56:33 +0530 [thread overview]
Message-ID: <e5f48ef7.AEEAOmPO1jwAAAAAAAAAAAPejtMAAAACwQwAAAAAAAW9WABZjIlJ@mailjet.com> (raw)
In-Reply-To: <20170810120612.bi33kbdswgtktohr@abyayala>
ng0 writes:
> gnu: Add emacs-gitpatch.
>
> By the way, “gitpatch.el” says different version than release tarball.
> Do I need to ask a developer?
> --8<---------------cut here---------------start------------->8---
> ;; Author: Feng Shu <tumashu@163.com>
> ;; Homepage: https://github.com/tumashu/gitpatch
> ;; Keywords: convenience
> ;; Package-Requires: ((emacs "24.3"))
> ;; Version: 0.10
> --8<---------------cut here---------------end--------------->8---
>
> >From 9eddf07fa401468738c2f48a25e51ddef2a3ceed Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 29 Jul 2017 14:22:48 +0300
> Subject: [PATCH] gnu: Add emacs-gitpatch.
>
> * gnu/packages/emacs.scm (emacs-gitpatch): New variable.
>
> Signed-off-by: Arun Isaac <arunisaac@systemreboot.net>
>
> I appreciate the concerns, but
> I don't think the complete paragraph of "By the way…" should be in the
> commit message. Please place notes like this as "XXX: ..." or "TODO: ..."
> in the code if possible.
> Or is there any reason why this landed in the commit message?
Oops! I didn't notice it was there. Looks like I screwed up big time
while applying the patch. There's no way to change the commit message
now, is there?
next prev parent reply other threads:[~2017-08-10 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 18:02 [bug#28020] [PATCH] gnu: Add emacs-gitpatch Oleg Pykhalov
2017-08-10 9:12 ` bug#28020: " Arun Isaac
2017-08-10 12:06 ` [bug#28020] " ng0
2017-08-10 16:26 ` Arun Isaac [this message]
2017-08-10 16:35 ` Tobias Geerinckx-Rice
2017-08-10 16:39 ` Arun Isaac
[not found] ` <a0b9df8d.AEEAOmPO1j4AAAAAAAAAAAPU2QkAAAACwQwAAAAAAAW9WABZjIlJ@mailjet.com>
2017-08-10 16:55 ` ng0
2017-08-10 17:31 ` Arun Isaac
[not found] ` <9b857f17.AEQAOV3jPRoAAAAAAAAAAAPU5Q8AAAACwQwAAAAAAAW9WABZjJhx@mailjet.com>
2017-08-11 0:25 ` Tobias Geerinckx-Rice
2017-08-11 6:48 ` Arun Isaac
2017-08-11 8:55 ` continued discussion on git commit messages ng0
[not found] ` <4c62b87d.AEQAOV3jPRsAAAAAAAAAAAPU2QkAAAACwQwAAAAAAAW9WABZjJhx@mailjet.com>
2017-08-11 6:56 ` [bug#28020] [PATCH] gnu: Add emacs-gitpatch ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f48ef7.AEEAOmPO1jwAAAAAAAAAAAPejtMAAAACwQwAAAAAAAW9WABZjIlJ@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=28020-done@debbugs.gnu.org \
--cc=ng0@infotropique.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.