all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Fabio Natali via Guix-patches via <guix-patches@gnu.org>
To: 72338@debbugs.gnu.org
Cc: zhengjunjie@iscas.ac.cn, Fabio Natali <me@fabionatali.com>
Subject: [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies.
Date: Tue, 30 Jul 2024 11:58:03 +0100	[thread overview]
Message-ID: <e5efe2bcb63d408f2dd50bc1ac298de164e40a8b.1722336973.git.me@fabionatali.com> (raw)
In-Reply-To: <9b857352fd100cf73aef76cd4a2e82333301d31c.1722177963.git.me@fabionatali.com>

* gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.

Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
---
Hi Zheng,

Thanks for reviewing my patch. Please find below an updated version. Let me know
should you spot anything else. 🙏

Thanks, cheers, Fabio.

 gnu/packages/upnp.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
index aab68a6414..d85e1da956 100644
--- a/gnu/packages/upnp.scm
+++ b/gnu/packages/upnp.scm
@@ -26,6 +26,7 @@
 (define-module (gnu packages upnp)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
@@ -154,12 +155,17 @@ (define-public readymedia
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-source
-           (lambda _
+           (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "Makefile.am"
-               ((".*LIBAVUTIL_LIBS.*") "")))))))
+               ((".*LIBAVUTIL_LIBS.*") ""))
+             (substitute* "minidlna.c"
+               (("rm -rf")
+                (string-append
+                 (search-input-file inputs "/bin/rm") " -rf"))))))))
     (native-inputs (list autoconf automake gettext-minimal))
     (inputs
-     (list ffmpeg
+     (list coreutils-minimal
+           ffmpeg
            flac
            libexif
            libid3tag

base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
-- 
2.45.2





  parent reply	other threads:[~2024-07-30 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 15:20 [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies Fabio Natali via Guix-patches via
2024-07-30  5:17 ` Zheng Junjie
2024-07-30 10:58 ` Fabio Natali via Guix-patches via [this message]
2024-08-01 15:55   ` bug#72338: " Z572
2024-08-01 16:54     ` [bug#72338] " Fabio Natali via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5efe2bcb63d408f2dd50bc1ac298de164e40a8b.1722336973.git.me@fabionatali.com \
    --to=guix-patches@gnu.org \
    --cc=72338@debbugs.gnu.org \
    --cc=me@fabionatali.com \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.