all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#74565: `guix import egg' fails to import packages recursively
@ 2024-11-28  1:05 lobo
  2024-11-28  9:34 ` bug#74565: [PATCH] import: egg: Fix recursive imports Ekaitz Zarraga
  0 siblings, 1 reply; 2+ messages in thread
From: lobo @ 2024-11-28  1:05 UTC (permalink / raw)
  To: 74565; +Cc: ekaitz

Hello Guix,

While testing the CHICKEN Scheme egg importer, I noticed it currently errors when importing recursively, as such:

```
lobo@drimys ~$ guix import egg spiffy -r
Backtrace:
           7 (primitive-load "/home/lobo/.config/guix/current/bin/gu…")
In guix/ui.scm:
   2330:7  6 (run-guix . _)
  2293:10  5 (run-guix-command _ . _)
In guix/scripts/import.scm:
     82:6  4 (guix-import . _)
In guix/scripts/import/egg.scm:
    96:19  3 (guix-import-egg . _)
In guix/import/utils.scm:
   667:27  2 (recursive-import "spiffy" #:repo->guix-package _ # _ . #)
   659:33  1 (lookup-node "spiffy" #f)
In guix/import/egg.scm:
   325:41  0 (_ _ #:version _ #:repo _)

guix/import/egg.scm:325:41: Unrecognized keyword: #:repo->guix-package
```

This is running on a foreign distro (Debian), if it happens to be relevant. Below is the output of `guix describe' and `guix --version' in my machine, I pulled just before sending this bug report to make sure that it's still valid as of now (my installation was a couple weeks old):

```
lobo@drimys ~$ guix describe
Generation 4    Nov 27 2024 22:03:33    (current)
  guix 8a28ba7
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 8a28ba76126cbbd2a6d61e864f576e7a7bd7a763
lobo@drimys ~$ guix --version
guix (GNU Guix) 8a28ba76126cbbd2a6d61e864f576e7a7bd7a763
Copyright (C) 2024 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
```

---
Lobo Torres
https://quiltro.org




^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#74565: [PATCH] import: egg: Fix recursive imports.
  2024-11-28  1:05 bug#74565: `guix import egg' fails to import packages recursively lobo
@ 2024-11-28  9:34 ` Ekaitz Zarraga
  0 siblings, 0 replies; 2+ messages in thread
From: Ekaitz Zarraga @ 2024-11-28  9:34 UTC (permalink / raw)
  To: 74565; +Cc: Ekaitz Zarraga

Fixes #74565.

* guix/import/egg.scm (egg-recursive-import) <#:repo->guix-package>: Add
`#:allow-other-keys`.

Change-Id: I97ad2d1aaf664c8dc18965eb2a497aa0a76062d7
---
 guix/import/egg.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/guix/import/egg.scm b/guix/import/egg.scm
index e3bc158475..9691f8c5ff 100644
--- a/guix/import/egg.scm
+++ b/guix/import/egg.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2021 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2024 Ekaitz Zarraga <ekaitz@elenq.tech>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -322,8 +323,9 @@ (define egg->guix-package/m                   ;memoized variant
 (define* (egg-recursive-import package-name #:optional version)
   (recursive-import package-name
                     #:version version
-                    #:repo->guix-package (lambda* (name #:key version repo)
-                                           (egg->guix-package/m name version))
+                    #:repo->guix-package
+                    (lambda* (name #:key version repo #:allow-other-keys)
+                             (egg->guix-package/m name version))
                     #:guix-name egg-name->guix-name))
 
 \f

base-commit: faf8ba9b43323dc61988a368690b20008611fc87
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-28  9:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-28  1:05 bug#74565: `guix import egg' fails to import packages recursively lobo
2024-11-28  9:34 ` bug#74565: [PATCH] import: egg: Fix recursive imports Ekaitz Zarraga

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.