all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Heads-up: git.sv.gnu.org now rejects unsigned commits
@ 2016-07-25  8:59 Ludovic Courtès
  2016-07-25 10:02 ` Cyril Roelandt
  2016-07-25 15:02 ` Leo Famulari
  0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2016-07-25  8:59 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hello!

All the Guix repositories on Savannah now reject unsigned Git commits:

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112

Please report any problems.

In the future the hook will also check that commits are signed by
authorized keys, but the details need to be laid out.

Ludo’.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Heads-up: git.sv.gnu.org now rejects unsigned commits
  2016-07-25  8:59 Heads-up: git.sv.gnu.org now rejects unsigned commits Ludovic Courtès
@ 2016-07-25 10:02 ` Cyril Roelandt
  2016-07-25 13:00   ` Tobias Geerinckx-Rice
                     ` (2 more replies)
  2016-07-25 15:02 ` Leo Famulari
  1 sibling, 3 replies; 6+ messages in thread
From: Cyril Roelandt @ 2016-07-25 10:02 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

On 07/25/2016 10:59 AM, Ludovic Courtès wrote:
> Hello!
> 
> All the Guix repositories on Savannah now reject unsigned Git commits:
> 
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> 

This could probably be useful:
https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work


What will we do about patches sent by casual contributors, that will
probably be unsigned? Should the committer sign them?


Cyril.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Heads-up: git.sv.gnu.org now rejects unsigned commits
  2016-07-25 10:02 ` Cyril Roelandt
@ 2016-07-25 13:00   ` Tobias Geerinckx-Rice
  2016-07-25 14:58   ` Leo Famulari
  2016-07-25 20:49   ` Andreas Enge
  2 siblings, 0 replies; 6+ messages in thread
From: Tobias Geerinckx-Rice @ 2016-07-25 13:00 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel, Guix-devel

Cyril,

On 2016-07-25 12:02, Cyril Roelandt wrote:
> What will we do about patches sent by casual contributors, that will
> probably be unsigned? Should the committer sign them?

Yes. (Most already do this, though.)

Kind regards,

T G-R
-- 
Sent from a web browser. Excuse my brevity.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Heads-up: git.sv.gnu.org now rejects unsigned commits
  2016-07-25 10:02 ` Cyril Roelandt
  2016-07-25 13:00   ` Tobias Geerinckx-Rice
@ 2016-07-25 14:58   ` Leo Famulari
  2016-07-25 20:49   ` Andreas Enge
  2 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2016-07-25 14:58 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

On Mon, Jul 25, 2016 at 12:02:11PM +0200, Cyril Roelandt wrote:
> On 07/25/2016 10:59 AM, Ludovic Courtès wrote:
> > Hello!
> > 
> > All the Guix repositories on Savannah now reject unsigned Git commits:
> > 
> >   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> > 
> 
> This could probably be useful:
> https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work
> 
> 
> What will we do about patches sent by casual contributors, that will
> probably be unsigned? Should the committer sign them?

Yes. Signing a patch that is emailed is a separate action from signing a
Git commit (`git commit --gpg-sign`). Submitters are invited to sign
their emails, but those signatures will not appear in the Git repo.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Heads-up: git.sv.gnu.org now rejects unsigned commits
  2016-07-25  8:59 Heads-up: git.sv.gnu.org now rejects unsigned commits Ludovic Courtès
  2016-07-25 10:02 ` Cyril Roelandt
@ 2016-07-25 15:02 ` Leo Famulari
  1 sibling, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2016-07-25 15:02 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Mon, Jul 25, 2016 at 10:59:07AM +0200, Ludovic Courtès wrote:
> All the Guix repositories on Savannah now reject unsigned Git commits:
> 
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> 
> Please report any problems.

Since the repo disables forced-pushing, we instead delete branches and
recreate them to get the same effect. We do this for WIP branches, and
perhaps some others?

If those branches contain unsigned commits (from before we decided to
sign everything), we won't be able to push them to Savannah. I ran into
this problem with my pre-push hook that prevents me from pushing
unsigned commits.

Just a heads up. I don't know whether or not it will be a problem in
practice.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Heads-up: git.sv.gnu.org now rejects unsigned commits
  2016-07-25 10:02 ` Cyril Roelandt
  2016-07-25 13:00   ` Tobias Geerinckx-Rice
  2016-07-25 14:58   ` Leo Famulari
@ 2016-07-25 20:49   ` Andreas Enge
  2 siblings, 0 replies; 6+ messages in thread
From: Andreas Enge @ 2016-07-25 20:49 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

On Mon, Jul 25, 2016 at 12:02:11PM +0200, Cyril Roelandt wrote:
> This could probably be useful:
> https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work

Indeed, thanks a lot!

Andreas

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-07-25 20:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25  8:59 Heads-up: git.sv.gnu.org now rejects unsigned commits Ludovic Courtès
2016-07-25 10:02 ` Cyril Roelandt
2016-07-25 13:00   ` Tobias Geerinckx-Rice
2016-07-25 14:58   ` Leo Famulari
2016-07-25 20:49   ` Andreas Enge
2016-07-25 15:02 ` Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.