From: Vivien Kraus via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 66034@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#66034] [PATCH gnome-team 1/3] gnu: glib: fix required.private reference to pcre.
Date: Sun, 17 Sep 2023 06:07:34 +0200 [thread overview]
Message-ID: <e4f56294cd812d203939b1fde0f323ef3c5aff17.camel@planete-kraus.eu> (raw)
In-Reply-To: <89a69bc554af84b3f7ea979ab4df8a05dffe23c7.camel@gmail.com>
Le samedi 16 septembre 2023 à 20:52 +0200, Liliana Marie Prikler a
écrit :
> Am Samstag, dem 16.09.2023 um 11:55 +0200 schrieb Vivien Kraus:
> > * gnu/packages/glib.scm (glib) [#:phases 'patch-pkg-config-files]:
> > Replace the reference to libpcre-8 to libpcre2-8.
> > ---
> Logic-wise LGTM, but…
> > gnu/packages/glib.scm | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> > index 8af89d60e0..dcc61802a4 100644
> > --- a/gnu/packages/glib.scm
> > +++ b/gnu/packages/glib.scm
> > @@ -449,7 +449,12 @@ (define glib
> > (("^bindir=.*")
> > "")
> > (("=\\$\\{bindir\\}/")
> > - "=")))))))
> > + "="))
> > + ;; Update the required.private pcre pkg-config name
> > + (substitute*
> > + (list (search-input-file outputs
> > "lib/pkgconfig/glib-2.0.pc"))
> Is there a reason to use a list here? Also, can we not do this
> earlier?
I am confused. This is not required at all, glib already points to the
correct libpcre2-8.pc. I don’t know why I thought this would not be the
case; maybe I checked the glib output on the wrong branch.
Anyway, can you just ignore this patch, or do you prefer that I send
the series again, without this one?
Vivien
next prev parent reply other threads:[~2023-09-17 4:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 15:19 [bug#66034] [PATCH gnome-team 0/3] Fix qemu Vivien Kraus via Guix-patches via
2023-09-16 9:55 ` [bug#66034] [PATCH gnome-team 1/3] gnu: glib: fix required.private reference to pcre Vivien Kraus via Guix-patches via
2023-09-16 18:52 ` Liliana Marie Prikler
2023-09-17 4:07 ` Vivien Kraus via Guix-patches via [this message]
2023-09-17 5:19 ` Liliana Marie Prikler
2023-09-16 12:25 ` [bug#66034] [PATCH gnome-team 2/3] gnu: pcre2: install static libraries Vivien Kraus via Guix-patches via
2023-09-16 12:27 ` [bug#66034] [PATCH gnome-team 3/3] gnu: qemu: Switch to pcre2 Vivien Kraus via Guix-patches via
2023-09-24 10:00 ` bug#66034: " Liliana Marie Prikler
2023-09-16 17:30 ` [bug#66034] [PATCH gnome-team 0/3] Fix qemu Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f56294cd812d203939b1fde0f323ef3c5aff17.camel@planete-kraus.eu \
--to=guix-patches@gnu.org \
--cc=66034@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.