From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] Add php Date: Sun, 30 Oct 2016 15:03:39 +0100 Message-ID: References: <20161030130828.3797d37d@polymos.lepiller.eu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JoHU3dqTf4sNGcLDoNL666HWPNJqr0gOh" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0qiE-00033r-PJ for guix-devel@gnu.org; Sun, 30 Oct 2016 10:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0qiB-0000Fm-Ja for guix-devel@gnu.org; Sun, 30 Oct 2016 10:03:50 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:34148) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0qiB-0000El-Dh for guix-devel@gnu.org; Sun, 30 Oct 2016 10:03:47 -0400 In-Reply-To: <20161030130828.3797d37d@polymos.lepiller.eu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: julien@lepiller.eu, guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JoHU3dqTf4sNGcLDoNL666HWPNJqr0gOh Content-Type: multipart/mixed; boundary="IIVLJwCti7oHEG0U1F28mqJpJBFFIxGoc"; protected-headers="v1" From: Tobias Geerinckx-Rice To: julien@lepiller.eu, guix-devel@gnu.org Message-ID: Subject: Re: [PATCH] Add php References: <20161030130828.3797d37d@polymos.lepiller.eu> In-Reply-To: <20161030130828.3797d37d@polymos.lepiller.eu> --IIVLJwCti7oHEG0U1F28mqJpJBFFIxGoc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien, On 30/10/16 13:08, Julien Lepiller wrote: > here is a patch to add php to guix. Excellent! I see you've broken into my machine (probably through PHP), stolen my bitrotting PHP 7 package and greatly improved it. Thanks! An incomplete review: > + (chdir "ext") [...] > + (chdir "..")))) Try with-directory-excursion. > + "--enable-fpm" "-with-openssl" s/-with-openssl/--with-openssl/, although the option would seem unnecessary if the result is the same. > + ;"--with-snmp" Best add a comment explaining why this is unavailable, desirable, and, if possible, what's needed to fix it. + #:tests? #f)) There are tests, but many fail. This should be explained in a comment (or fixed ;-). I keep tests enabled on my machine because I hate PHP and like to hear it scream. Bonus fun fact: catastrophic test failure is non-fatal and the thing installs fine. > + (synopsis "PHP programming language") > + (description > + "PHP is one of the most commonly used programming language > the web") s/language/languages/ and a missing full stop, but it would be nice to add even more. For example: PHP (PHP Hypertext Processor) is a server-side (CGI) scripting language designed primarily for web development but is also used as a general-purpose programming language. PHP code may be embedded into HTML code, or it can be used in combination with various web template systems, web content management systems and web frameworks. Thanks again for working on this! Kind regards, T G-R --IIVLJwCti7oHEG0U1F28mqJpJBFFIxGoc-- --JoHU3dqTf4sNGcLDoNL666HWPNJqr0gOh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEqBAEBCgAUBQJYFf28DRxtZUB0b2JpYXMuZ3IACgkQkczbm0hUG5lBOgf/W9aP vqpEDEQFhNql1t7a13v0XMpiFfAYCQasa9sPCO3HTiauRtS6FAoEmUddQQ4e8e3s H5WjOLbl91Y6R6acY7uJxmMi7fOfn2K324ovGYhV36UxFMDLqR+roh2kw0Zp0fq6 2y5ovGUpzeJy4MXVQRqACONX+31scGzSn9iZ9gwHA2uPZaB3En2jPjXYbGLEX+li 3Momooj0imp8pExOfFFjszsrj7G+7zO/0iq+RvyhoE/XV78RQYRfXDCKRIEGrKMw +oSQ4Dkip6sTb1AD1vKwqXERlJ0qX4XFlsYpF5TPB/lIo8D+TVxZlDwAWU5NjfCs LD1MxrDX5DHt4UrORA== =xXCM -----END PGP SIGNATURE----- --JoHU3dqTf4sNGcLDoNL666HWPNJqr0gOh--