From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8J4IDjxsfWYQfgEAe85BDQ:P1 (envelope-from ) for ; Thu, 27 Jun 2024 13:42:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8J4IDjxsfWYQfgEAe85BDQ (envelope-from ) for ; Thu, 27 Jun 2024 15:42:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=alphapapa.net header.s=dreamhost header.b=MJgT2Rn0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:mailchannels.net:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719495740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pA/XxfilXpcEdHrhz/CdmXMnYnC0Dq7H4/s8lpnBucs=; b=KnydMqprMx+RAcbmGnLGD3cIGUBsfpR6j52g0X9x7lTLFdpDI572CgTjZoBRhSJdrzPJHO NInpw3dzNdKON9+8ZQDawNQ4F/7GreuHLDkNZ/Ytc4IOrPUfUVlgFVLwzjcPDFtD1O4Np/ TQvkcHZ0jA+05Hui3CxsiNqD0lsGd6l+TuffGvFyX7JyAfCXBEf92JN0Q6esBf9oTEL6FY LdJyr9UkibSG3ju2vCalx6PE8njON9dJH7lKHUsATUxKYuyb/P0kUbo4VrsNI9IXjVQP7R GdQ3VW8FJpFKDC6XidTYn/4CmtKL65gfbVLkxot7uAuKpNkWLoA4OjXjZN7Evw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=alphapapa.net header.s=dreamhost header.b=MJgT2Rn0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:mailchannels.net:reject}") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1719495740; a=rsa-sha256; cv=fail; b=oCKc1d7vNaOKBvEhLM7iSI/3Esu1CUq8Av132jqPnZ8mTkKKq7NCC7WyRnBrFgwJNo1HP/ 3Z/u9j2gJWZWTNJMECG9bIL87u1kfiCjdj1u5rBt82wtfBJBhvgC/Ic94m9Ya9Ab37/eNz I8Q3R8UKYSdDYJo38nM8l+25Z3V422XWVL8ubVuLWnj2VTMGYTqeWvPii8UgRCUsQUMeDU X9RY2WdjjWdq1p2HmRgi3tnUUmq/hr52M2XOyvypRdj4YkVB8VSpTvbSj36d1Z+VPs5+BH LMPl+f7xVKtaUOUdd6djkVyhRCDPxg8AxltwFOnGHe+3yJFvXjGgnGqmuTCqtg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4800F12848 for ; Thu, 27 Jun 2024 15:42:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMpO4-0003JA-9w; Thu, 27 Jun 2024 09:42:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMpNw-0003EO-1k for guix-patches@gnu.org; Thu, 27 Jun 2024 09:42:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMpNv-0007S7-OL for guix-patches@gnu.org; Thu, 27 Jun 2024 09:41:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMpNy-0001TH-G5 for guix-patches@gnu.org; Thu, 27 Jun 2024 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71592] [PATCH 0/3] gnu: emacs-org: Update to 9.7.4. Resent-From: Adam Porter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Jun 2024 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71592 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Suhail Singh Cc: 71592@debbugs.gnu.org Received: via spool by 71592-submit@debbugs.gnu.org id=B71592.17194956625580 (code B ref 71592); Thu, 27 Jun 2024 13:42:02 +0000 Received: (at 71592) by debbugs.gnu.org; 27 Jun 2024 13:41:02 +0000 Received: from localhost ([127.0.0.1]:41302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMpMz-0001Re-BM for submit@debbugs.gnu.org; Thu, 27 Jun 2024 09:41:02 -0400 Received: from tiger.tulip.relay.mailchannels.net ([23.83.218.248]:59903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMpMv-0001RQ-GX for 71592@debbugs.gnu.org; Thu, 27 Jun 2024 09:40:59 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2EAFC816AC; Thu, 27 Jun 2024 13:40:52 +0000 (UTC) Received: from pdx1-sub0-mail-a271.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9BD9581699; Thu, 27 Jun 2024 13:40:51 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1719495651; a=rsa-sha256; cv=none; b=NlUWAhwrOSEUt31tU0srglQTfVT3Pgabh7xzhrMbvsKrvGD2kDnk283m9OvgFGNl0bme2f 8atF6W3toZxDdnLz4lNW6Bu4fgiGI/g8kiX5AGg9ApFxnrei7LcEJBZU65VR9hqtTBGXDv en8GrXgLFVxH2od6CHP4TegZfE+ElxSt8wySLYrvz3EnIpMbAkcgVb7lrjiTfKCAUT0OYJ WmRCp39DM4ElpiICn6Ev74+WRUqt1tVtThJjha1/zs+n5XWVjGNre2j2nZicZkz8eUoo2x hpKwRkG+9HLcKzEHKnOBc9FcGsjJLEajC266tvHwzJVhxsxQMmcsBjZ0EhqXMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1719495651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pA/XxfilXpcEdHrhz/CdmXMnYnC0Dq7H4/s8lpnBucs=; b=Nd511qpEFILIfHDowhVt+DRT2h8HZ67HDZPai/I0n/mCMBW6BJjcfGeLI2xKGsn7pi7uQ+ +C/Y4WERmNu8+FP63Urh2gKE/x6MSPcJKbVGIBakXZL4krPhj27rcdFPgfhaUFgYA+Emf5 5zy73LGoP6GRV/j8pwfwqo0UPNH40aSngLVuYpyDu3VvNx5ktCqlWBj0M/3GJGomq6h9od K45nMTzXErcAWXXE5L34nr73xtysznb/0UFIl4msqwhgc703B3/xF/0cLH+tx2MQMEnIlG WOXkIyKc8pW9V3fQCMOq9PTc7TPl3ZRl2D632LJ9k+RUeml9QjU+kMPNNJW32A== ARC-Authentication-Results: i=1; rspamd-7f76976655-5g6gp; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Oafish-Interest: 4cb1ff2770f4de37_1719495652007_738559163 X-MC-Loop-Signature: 1719495652007:2803539908 X-MC-Ingress-Time: 1719495652006 Received: from pdx1-sub0-mail-a271.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.118.105.142 (trex/6.9.2); Thu, 27 Jun 2024 13:40:52 +0000 Received: from [10.66.43.177] (unknown [91.193.232.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a271.dreamhost.com (Postfix) with ESMTPSA id 4W90825LXgzGP; Thu, 27 Jun 2024 06:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1719495651; bh=pA/XxfilXpcEdHrhz/CdmXMnYnC0Dq7H4/s8lpnBucs=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=MJgT2Rn0hxGGObb2JGWdsmtH2z4IWhoctefg0aPdbuKprC0i1DKjDFkJP1/oPBcJf 5mZrLRNM9ZTcNjdcapbUrWAp1phATc70GW6Y/wHIp9Mw8Y8+aIMuatci/a3XGOKb0o 4ydOVpSkuGW4DDSug4pDvp3GMZVn2Q4xfsq7YXYbbQNv2+w7INKDnnhWTz9bxKhz6c vUIagjdd4/4gGAjo3rT0hkb1y4+VrMtmO7ueYNCg65vSDoMEM4qIyGnax5zmQVjjqo z9q0AfpDrvCN7Gc5SIyNEva+oooFjl7lUCyjBb6SL6pkuugG2cVdEd7rgJu6Y41t49 smIiW75epv6EQ== Message-ID: Date: Thu, 27 Jun 2024 08:40:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87frt4ns9m.fsf@gmail.com> Content-Language: en-US From: Adam Porter In-Reply-To: <87frt4ns9m.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 4800F12848 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.36 X-Spam-Score: -4.36 X-TUID: kg7qI5qJQePc Hi Suhail, On 6/23/24 00:27, Suhail Singh wrote: > >> but have these failing tests been reported as bugs upstream? > > I have not made any bug reports regarding the failing tests yet. I > don't know if others have (or rather didn't, before I started > writing this email). I did try and see if a newer commit from > org-super-agenda was immune from the test failures, but didn't have > any luck. > > It's not clear to me whether the test failures point to bug(s) in > org-super-agenda, bug(s) in its test suite, bug(s) in Org mode, or > (less likely, but still possible) false positive(s) arising due to > the tests not being designed necessarily to run on Guix. I was > planning to look into it further, but since I don't personally use > org-super-agenda it's not been a priority. Regardless, for the > benefit of others, I am glad that you pay attention to this mailing > list and are now aware. I don't subscribe to nor watch the Guix lists; I don't have enough personal bandwidth for that. I only noticed this report because I was trying to understand a problem with building Emacs 29.4 and was looking for related issues on the tracker. >> You mention in a code comment an obsolete variable, but I don't >> know anything about that, and I can't find a bug reported on the >> tracker about it. > > The "obsolete" variable in question is > `org-super-agenda-retain-sorting'. The tests making use of the > older user option are `org-super-agenda-test--with-retained-sorting' > and `org-super-agenda-test--without-retained-sorting'. In commit > `27aa0db4243b835494f4836b82d0fbf3c5be7392' on 2021-09-28, it seems > you renamed that option to `org-super-agenda-keep-order'. The tests > were not updated. The FIXME comment in the former test notes: > > #+begin_src emacs-lisp ;; FIXME: This seems to be slightly broken on > Org 9.6.6. Maybe > ? > #+end_src > > The bug #207 seems to have been first noted about 3 years ago, is > currently open and assigned to you, and targeted for the 1.4 > milestone. Thanks for your thorough investigation. The problem you've described is simply that, when I renamed a symbol in a contributor's code before merging it, I overlooked to rename it in the associated test as well--and this is the first I've heard about it. The issue mentioned in the FIXME is related to the functionality, but is not about the test itself, and the test does not appear to fail there due to the incorrect symbol (IOW the test would fail anyway due to the "real" problem). >> Please, if you know about a bug, > > Not being a user of the package, my awareness is limited to the > presence of test failures. I am not sure if you have CI configured > for the project, but if you have and aren't seeing these failures, it > may be worth your while to understand where those differences stem > from. If you do and do see the same failures, your awareness and > understanding of the issues probably exceeds my own limited > understanding, so please excuse most of this email. If you don't > have CI configured, you may want to consider doing so. >> I maintain a number of Emacs/Org packages, and keeping up with the >> changes in Org, and trying to maintain compatibility across >> versions which have incompatibilities, is trying, especially if >> users don't report them (I don't always run the latest release of >> Org). > > I agree user reports are invaluable. In fact, I'd go further and > say that user time is invaluable. However, given that their time is > precious, it seems wasteful to rely on them for something that can > be adequately addressed by a properly configured CI system (at least > in this instance). In my candid opinion, their time is better > served reporting on usability concerns that aren't (yet) covered by > tests. As you can see in the respective git repositories, there are extensive lints and tests, and they are run on GitHub CI using my bespoke makem.sh system for linting and testing Emacs Lisp packages, across a variety of Emacs versions. I also use this system extensively to test changes locally before pushing, and I have for years (the whole reason I wrote makem.sh 5 years ago, because catching these kinds of problems after the fact is utterly impractical to deal with). Nevertheless, due to the fact that multiple versions of Emacs and of Org are supported by these packages, it is not always possible for the lints and tests to pass cleanly on all supported versions at the same time--and that can cause actual problems, such as this test having a wrong symbol name, to be obscured, which appears to be the case here. IOW, for some projects, the lints and/or tests are always going to fail on some combination of Emacs/Org versions, even though the project in question may actually work on it. So a "properly configured CI system" is not a panacea; software being software, there will always be holes in the various layers, and when they align... > Whether these failures are false positives or not, is not clear to > me. If I had spent more time analyzing it, I am sure eventually I > would have understood it and either added to the existing issues, or > opened new ones, or submitted one or more patch/pull request > upstream. Alas, there's only so much time in the day and we must all > prioritize. All I ask is that, if you know about an obvious problem like a symbol name being wrong, that you drop me a line, either as an issue on the tracker or via email. When you mentioned an "obsolete symbol," I thought you meant one defined in Org itself (because, strictly speaking, the symbol in org-super-agenda was never in a released version, having been renamed before it was even merged, so it was not "obsolete", a term that has a specific meaning, especially in Emacs-related contexts; and Org itself frequently obsoletes symbols across versions). So I was wondering what new Org symbol I needed to add compatibility code for in org-super-agenda. >> and especially if you know about a solution, > > As noted in my patch, my attempt to naively rename > `org-super-agenda-retain-sorting' to `org-super-agenda-keep-order' > did not fix the failures I observed. The actual fix, whatever it is, > isn't one I'm aware of. That would be issue #207, and it appears to be one of those things that changes across Org versions, making it hard or impossible to fix in a way that comprehensively passes testing (especially since I've no control over the versions of Emacs and Org used in Guix). It's also a minor bug, essentially a cosmetic issue, which has made it a low priority to work on with my limited time, which I'm sure you can appreciate. Anyway, as a longtime user of and contributor to distributions that package upstream software for downstream users, such as Debian and Guix, I appreciate the role of the "middleman" packager/maintainer. Also being an upstream maintainer, I appreciate the challenge from that perspective as well. The best way to smooth over these issues is to have good communication in both directions. So as an upstream developer, I try to make changes small, atomic, and well-documented, and to make bug-fix releases on stable branches, to make it easier for downstream maintainers to incorporate such changes between major releases. My only request as such an upstream maintainer is that, when a downstream maintainer finds a problem, that it be reported to me, especially when it may indicate an underlying bug rather than a downstream compatibility issue (e.g. one specific to Guix; but note that I'm keen to help compatibility with Guix as well). Thanks, Adam