From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KKHHBQR45GFATgAAgWs5BA (envelope-from ) for ; Sun, 16 Jan 2022 20:54:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ENElAwR45GEA6QAA9RJhRA (envelope-from ) for ; Sun, 16 Jan 2022 20:54:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C04F01F2FD for ; Sun, 16 Jan 2022 20:54:43 +0100 (CET) Received: from localhost ([::1]:41388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9Bbu-0004Bo-UT for larch@yhetil.org; Sun, 16 Jan 2022 14:54:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9BbQ-000459-12 for guix-patches@gnu.org; Sun, 16 Jan 2022 14:54:13 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9BbG-0001BL-JY for guix-patches@gnu.org; Sun, 16 Jan 2022 14:54:11 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9BbG-00055V-CQ for guix-patches@gnu.org; Sun, 16 Jan 2022 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#48463] gnu: Add j. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: elaexuotee@wilsonb.com Cc: Maxime Devos , 48463@debbugs.gnu.org Received: via spool by 48463-submit@debbugs.gnu.org id=B48463.164236281919527 (code B ref 48463); Sun, 16 Jan 2022 19:54:02 +0000 Received: (at 48463) by debbugs.gnu.org; 16 Jan 2022 19:53:39 +0000 Received: from localhost ([127.0.0.1]:44304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Bat-00054t-HD for submit@debbugs.gnu.org; Sun, 16 Jan 2022 14:53:39 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Bar-00054g-Nf for 48463@debbugs.gnu.org; Sun, 16 Jan 2022 14:53:38 -0500 Received: by mail-wm1-f65.google.com with SMTP id 25-20020a05600c231900b003497473a9c4so19485562wmo.5 for <48463@debbugs.gnu.org>; Sun, 16 Jan 2022 11:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=tlTC491pnqjsi565i7zJHtObnMseSjyX9hffAsKUMmk=; b=Mqx0+9qGt1XdeaiwX13jNS2lRd4IfqxT6N7Sp+HYWoEIB09ydcBp/+hIQDl6/TfaA3 v+WCSR4bJNR9RAgMhiasT9NCkiKNsoAMzaFHJwQsU0sigQkVUSArr3rRnr+rnSI7g0H4 u71M2e2splKniSlHsYMCifSJLiynMWhUfG0AuU2JWskiCjZZI7JI6OwUnS2R0fpN6/8p jClG14kveZsSK8gcW3QWdBpSXHmFAY+nnwnFrGNn+wbVg3RMaGj2vlDwTBLTE/ZyHlwh +wBe6ZnlctZKAKmbdG0n6fdyRReWJ0Nlwdy6c/2+r5UA/5R7C0eH1QAaiLl7lcOCbqtd NRHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=tlTC491pnqjsi565i7zJHtObnMseSjyX9hffAsKUMmk=; b=v5BVkI07dJP3jzJCay7+YhGSoTh81g5/ljBOQHkg0UKYvdGuRSTKsprFNaHbvHOqnn Az/m+o8Ncpk2E6axp67+uHtjXBbz8qOYK2DxW8cWs+E0i1THGwXPr22FIQF8Huo4KIvL LjCS1UBT8C1iwRlTzpy/125olN149KCk8+J7cMHyg97Sq46zFs9knbgiPLd16yw1MXHW USJQKbJkPXZkB1iKDMgr0+TJOmN55Sk3Lm6qgfVRkKQ2+bt8B9HRJHXp7QZofUnMuZUc PD0Cf3+c4CcKxe/sslPXQ8D/rbIA8qeQlZErJfOOu7l2wrLTFSoe+GpFLCWr+uh5UkbG 93Nw== X-Gm-Message-State: AOAM530dUiVPbatdnNd3Lhke/waH9F63OTeA7o/n6K6kvPAIkEOxGDrS Npp2IM/yF2rB1kchzUvrcLc= X-Google-Smtp-Source: ABdhPJxa/hsJbYxiDKH9uQrAvqJHztK2wNHq5Siy18vAtOBeSSxB7ffyrFGze/b9qqO7Nl0KGOoilw== X-Received: by 2002:a1c:f205:: with SMTP id s5mr17786315wmc.33.1642362811611; Sun, 16 Jan 2022 11:53:31 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g6sm262038wmq.11.2022.01.16.11.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 11:53:31 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sun, 16 Jan 2022 20:53:29 +0100 In-Reply-To: <24FU0VP6N4ZZ7.3PE5LG30BSNUQ@wilsonb.com> References: <3LOAUDT0FLL4U.2SOD925YP915T@wilsonb.com> <8b853d0585505ce29c9afc638b644fa34805e6c0.camel@student.tugraz.at> <293L8YPQS4CLB.3VK1B1A36XNAY@wilsonb.com> <5d30160bd2a4592459cd407f99cbd3edadb1db1b.camel@student.tugraz.at> <27DCD25Y68ZWJ.2HRC4G65PWIA7@wilsonb.com> <94f4625dcb0479d873cf60449631527e841fd457.camel@gmail.com> <2JQJMV0O718S1.31FZE8GKCTLPF@wilsonb.com> <90704c2259f576a14fb1268219e8c0dc2b3bf289.camel@telenet.be> <2P322C327XW0Q.21O5A4IFGMNDI@wilsonb.com> <72aff035c93f9f91afa54ef5b51c7381b0b02ccb.camel@gmail.com> <3MMTDZQJQ8IR6.334ZWY8AD0487@wilsonb.com> <62d37956f16c08bc4ce26e44da16dce704ddd0f8.camel@gmail.com> <24ZUUMG4QYSHN.2OS7YAMCKREUA@wilsonb.com> <83aba994536bec60f79900d551d4801c967742bd.camel@gmail.com> <25Z6NGGGNJYD1.3S7A1QLFX7I9Y@wilsonb.com> <24FU0VP6N4ZZ7.3PE5LG30BSNUQ@wilsonb.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642362883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tlTC491pnqjsi565i7zJHtObnMseSjyX9hffAsKUMmk=; b=Wmba+SU2ku105jZZEOUo5BWVLKU/ETtYoFptusuHB3exCwTcF4rMC3w6mnqNNxYWrMwnyg pcRzWTls9G6fl/P63/X+hZ51xX0hU3PCUeZuEGtmCJK1/0DhFi7Ev9dzwlt+cK5I5EK4jp EeZuTh2Rcviqpw2X98/yfcbLODI9I/2ugs9cS3ROowQeGyAuonKQxc2F0bYj21fH5B8ngK N7BWTufDIBBCF0TPvXRXLauqVTa7rQRjcTycXkTy6hG/6iRs51ggTIxrJL/XSdgMx6NA6O JHA9p8XtnK8nffUQFrqkZKkxLDJt+/4ZA3oHfgboAOCjzBuvLxNgZPqvl/ho1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642362883; a=rsa-sha256; cv=none; b=Gm0+riRuaF+q/QRD6YMR0/2UxC52ddE8NHYX/2Zm/Ex3lJzMEStqx2VnlDPQEMGmPDCZif y3dlOny/TSaxgAY21tW6YHvVuyLsNbPdrqAQnbFuDQiPczSrbnPEOfgalBx6SR1MAy9Pv1 6U65cG2CwIzP+MWbhGBkoXW1xDAQh4KVSgKEumY41Rb/J6k/5NGB7yh0yTlhgzUaM4AevY 7E76KBXJMsedcETbqB0stEMUYTW9eD+d0zlffbNmjwxQ/ls9ObGCNaAss8AHD037J8Obj7 Z4UNH9uGn/o1ni1tlTh3orCYuRR7qvNfMBa8oHpZIMfZgWDZDyMKBF0vbu/LJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Mqx0+9qG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Mqx0+9qG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C04F01F2FD X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: BnJ+ziP4xDhm Hi, Am Montag, dem 17.01.2022 um 00:19 +0900 schrieb elaexuotee@wilsonb.com: > > > Interesting idea. How about just always forcing a MINOR part, > > > setting to "0" if upstream doesn't have one? > > That'd declare regular releases as MAJOR.0 in the version field, > > which I'm not sure if we want that.  In the case of random commits > > I'm less reserved, as they don't correspond to releases anyway. > > I see your point. In fact, upstream releases start with MINOR part "a" > and "count up" through the letters over the course of a year. It's a > pretty simple scheme. For example, J 901 started at "j901-release-a" > and ended at "j901-release-f". > > When I originally wrote this package, I noticed that the release tag > for the first J 902 was "j902-release", and so treaded MINOR as > potentially optional. > However, after checking upstream's forums, this looks to just be a git > tag mishap. > > How about we just go ahead and treat MINOR as mandatory as well? In other words minor should always have a value >= "a" and 902 was just missing it? Fair enough, in that case making version mandatory sounds like the way to go. > > > If you have a better idea, I am all ears. > > You could define that file-union right after ijconsole.  If you want > > to > > golf even more, you could define ijconsole inside that file-union, > > i.e. > >   (define jsoftware-aux-files > >     (file-union "jsoftware-aux-files" > >       `(("profile.ijs" ,(search-aux-file ...) > >         ("ijconsole" ,(program-file ...)))) > > > > I'm not quite sure if you want to use jsoftware-aux-files directly as > > input or whether it's wiser to stuff it into another union like > > (file-union "jsoftware-aux-input" `(("aux" ,jsoftware-aux-files))). > > search-input-file will probably do the right thing regardless. > > The new style should also still work with assoc-ref, it'd just be > > weirder to look at.  Lastly, you could code up a (search-file-input) > > just in case; I'm not sure if we have one already. > > The file-union seems like a cludgy workaround to me. What we really > want is an easy, direct way to get handles on the input files. Heck, > program-file objects already have a name property; why can't we use > that? Attached patches are a proof-of-concept. That proof of concept does look nice, but for one we're trying to move away from labels, and for the other, it's on a scale that I don't want to decide as part of a package addition. If you feel it has value outside of the proposed usage for j, discussing it under a different number or perhaps on guix-devel might be worth it. > That said, if this is going to turn into a big rabbit hole, can we just > munge the J package inputs into whatever you think is best? As said in my previous mail, that'd be > > (define jsoftware-aux-files > > (file-union "jsoftware-aux-files" > > `(("profile.ijs" ,(search-aux-file ...) > > ("ijconsole" ,(program-file ...)))) In my personal opinion, you can then simply add jsoftware-aux-files as input and (search-input-file "ijconsole") instead of the current assoc- ref. WDYT? Don't worry, I don't plan to drag this out too long, but I also don't planning on pushing this today. There are definitely some stylistic choices that I want to make under the considerations here (basically, we can just merge major and minor into a single base that'd be "903.a", for example), but it's almost bedtime and I want to relax a little before going to sleep. Cheers