From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 8/8] gnu: python-dulwich: Fix tests. Date: Wed, 18 Jan 2017 00:38:48 +0100 Message-ID: References: <20170117222548.13995-1-dannym@scratchpost.org> <20170117222548.13995-9-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTdL7-00014B-B0 for guix-devel@gnu.org; Tue, 17 Jan 2017 18:38:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTdL2-0005He-CW for guix-devel@gnu.org; Tue, 17 Jan 2017 18:38:57 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:44109) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTdL2-0005GM-4o for guix-devel@gnu.org; Tue, 17 Jan 2017 18:38:52 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3v364V1b1Bz3hnHC for ; Wed, 18 Jan 2017 00:38:50 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3v364V0NNHzvkcm for ; Wed, 18 Jan 2017 00:38:50 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id e-OdY7ynJJKB for ; Wed, 18 Jan 2017 00:38:49 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-46-244-157-46.dynamic.mnet-online.de [46.244.157.46]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Wed, 18 Jan 2017 00:38:49 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 4F3EC604E8 for ; Wed, 18 Jan 2017 00:38:48 +0100 (CET) In-Reply-To: <20170117222548.13995-9-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Am 17.01.2017 um 23:25 schrieb Danny Milosavljevic: > + ;(substitute* "dulwich/hooks.py" > + ; (("f[.]write[(]args[[]0[]][)]") "f.write(args[0].encode('utf-8'))")) This is an interesting but quite unusual way to escape the special characters. I suggest using the more common type with back-slash, esp. since "[[]" and "[]]" are very hard to get. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |